Compile failure with v9fs
The following patch deletes an assignment to the variable p9_debug_level, which is never defined and isn't used anywhere else I can see.
PATCH 1/1 fs/9p/v9fs.c: Delete unused p9_debug_level setting
From: Horst H. von Brand <[email protected]>
Signed-off-by Horst H. von Brand <[email protected]>
--- fs/9p/v9fs.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
fs/9p/v9fs.c +0 -1
@@ -131,7 +131,6 @@ static void v9fs_parse_options(char *options, struct v9fs_session_info *v9ses)switch (token) {case Opt_debug: v9ses->debug = option; - p9_debug_level = option;break ;case Opt_port: v9ses->port = option;
Signature · 1 line
1.5.2.3
Re: [PATCH] fs/9p/v9fs.c: Delete unused p9_debug_level setting
Quoted 12 lines · Horst H. von Brand
From: Horst H. von Brand <[email protected]>
Signed-off-by Horst H. von Brand <[email protected]>--- fs/9p/v9fs.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)fs/9p/v9fs.c +0
-0
fs/9p/v9fs.c static void v9fs_parse_options(char *options, struct v9fs_session_info *v9ses) · line 136
Quoted 7 lines
fs/9p/v9fs.c +0
-1@@ -131,7 +131,6 @@ static void v9fs_parse_options(char *options, struct v9fs_session_info *v9ses)switch (token) {case Opt_debug: v9ses->debug = option; - p9_debug_level = option;break ;case Opt_port: v9ses->port = option;
It doesn't seem to be unused:
$ grep -r p9_debug_level *
fs/9p/v9fs.c: p9_debug_level = option;
include/net/9p/9p.h:extern unsigned int p9_debug_level;
include/net/9p/9p.h: if ((p9_debug_level & level) == level) \
net/9p/mod.c:unsigned int p9_debug_level = 0; /* feature-rific global debug level */
net/9p/mod.c:EXPORT_SYMBOL(p9_debug_level);
net/9p/mod.c:module_param_named(debug, p9_debug_level, uint, 0);
net/9p/mux.c: if ((p9_debug_level&P9_DEBUG_FCALL) == P9_DEBUG_FCALL) {
net/9p/mux.c: if ((p9_debug_level&P9_DEBUG_FCALL) == P9_DEBUG_FCALL) {
net/9p/sysctl.c: .data = &p9_debug_level,
$ cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed