Skip to contentSkip to conversation

: remove unused return within void return function

PATCH In review Denis Cheng 3 participants 3 messages Jul 19, 2007 – Jul 21, 2007

Subsystems (3)
Block layer Kernel janitors Network block device (NBD)
lore
Share & tools
lore

Denis Cheng

author
#0 lore raw

PATCH 1/1 : remove unused return within void return function

Signed-off-by Denis Cheng <[email protected]>
---
 drivers/block/nbd.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/block/nbd.c +0 -1
index c129510..95dd97c 100644
@@ -478,7 +478,6 @@ error_out:
 		nbd_end_request(req);
 		spin_lock(q->queue_lock);
 	}
-	return;
 }
 
 static int nbd_ioctl(struct inode *inode, struct file *file,
Signature · 1 line
1.5.2.2
#1 lore raw

drivers/block/nbd.c error_out: · line 481

Quoted 8 lines · Denis Cheng
drivers/block/nbd.c +0 -1
@@ -478,7 +478,6 @@ error_out:
 		nbd_end_request(req);
 		spin_lock(q->queue_lock);
 	}
-	return;
 }

Yes, but we have many such places.

#2 lore raw
In reply to Denis Cheng
Quoted 1 line · Denis Cheng
Signed-off-by Denis Cheng <[email protected]>

ACK.

Pavel

Quoted 10 lines
drivers/block/nbd.c +0 -1
@@ -478,7 +478,6 @@ error_out:
 		nbd_end_request(req);
 		spin_lock(q->queue_lock);
 	}
-	return;
 }
 
 static int nbd_ioctl(struct inode *inode, struct file *file,
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html