Skip to contentSkip to conversation

fs: remove the unused mempages parameter

PATCH New Denis Cheng 1 participant 1 message Jul 23, 2007 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: remove the unused mempages parameter

Since the mempages parameter is actually not used, they should be removed.

---
If applied, now there is only files_init use the mempages parameter,
files_init(mempages);
but i don't think the adaptation to mempages in files_init is really useful; and if files_init also changed to the prototype void (*func)(void), the wrapper vfs_caches_init would also not need the mempages parameter.

 fs/dcache.c        |    8 ++++----
 fs/inode.c         |    2 +-
 fs/namespace.c     |    2 +-
 include/linux/fs.h |    4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)
fs/dcache.c +4 -4
index 678d39d..4895959 100644
@@ -2108,7 +2108,7 @@ static void __init dcache_init_early(void)
 		INIT_HLIST_HEAD(&dentry_hashtable[loop]);
 }
 
-static void __init dcache_init(unsigned long mempages)
+static void __init dcache_init(void)
 {
 	int loop;
 
@@ -2170,10 +2170,10 @@ void __init vfs_caches_init(unsigned long mempages)
 	filp_cachep = kmem_cache_create("filp", sizeof(struct file), 0,
 			SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL);
 
-	dcache_init(mempages);
-	inode_init(mempages);
+	dcache_init();
+	inode_init();
 	files_init(mempages);
-	mnt_init(mempages);
+	mnt_init();
 	bdev_cache_init();
 	chrdev_init();
 }
fs/inode.c +1 -1
index 29f5068..d7431e6 100644
@@ -1378,7 +1378,7 @@ void __init inode_init_early(void)
 		INIT_HLIST_HEAD(&inode_hashtable[loop]);
 }
 
-void __init inode_init(unsigned long mempages)
+void __init inode_init(void)
 {
 	int loop;
 
fs/namespace.c +1 -1
index ddbda13..07daa79 100644
@@ -1791,7 +1791,7 @@ static void __init init_mount_tree(void)
 	set_fs_root(current->fs, ns->root, ns->root->mnt_root);
 }
 
-void __init mnt_init(unsigned long mempages)
+void __init mnt_init(void)
 {
 	struct list_head *d;
 	unsigned int nr_hash;
include/linux/fs.h +2 -2
index d33bead..41b37bc 100644
@@ -301,9 +301,9 @@ struct kstatfs;
 struct vm_area_struct;
 struct vfsmount;
 
-extern void __init inode_init(unsigned long);
+extern void __init inode_init(void);
 extern void __init inode_init_early(void);
-extern void __init mnt_init(unsigned long);
+extern void __init mnt_init(void);
 extern void __init files_init(unsigned long);
 
 struct buffer_head;
Signature · 1 line
1.5.2.2