Skip to contentSkip to conversation

i386: flush_cpumask doesn't need "or"

PATCH New Benjamin Herrenschmidt 1 participant 1 message Jul 31, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i386: flush_cpumask doesn't need "or"

Did I miss something or do we needlessly do an "or" to flush_cpumask while we could just assign it ? We never exit that function with the mask not empty and we have a spinlock...

---

arch/i386/kernel/smp.c +2 -1
Index: linux-work/arch/i386/kernel/smp.c
===================================================================
@@ -375,7 +375,8 @@ void native_flush_tlb_others(const cpuma
 	
 	flush_mm = mm;
 	flush_va = va;
-	cpus_or(flush_cpumask, cpumask, flush_cpumask);
+	flush_cpumask = cpumask;
+
 	/*
 	 * We have to send the IPI only to
 	 * CPUs affected.