Skip to contentSkip to conversation

8641hpcn: Do correct sized pointer math.

PATCH New Jon Loeliger 2 participants 3 messages Aug 6, 2007 – Aug 10, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 8641hpcn: Do correct sized pointer math.

When I rebased Ed's patch and cleaned up a few compilation problems, I apparently rebased my brain on crack first. Fix that by doing (char *) sized pointer math as needed.

---
 board/mpc8641hpcn/mpc8641hpcn.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
board/mpc8641hpcn/mpc8641hpcn.c +2 -2
index d2182ab..bdb834b 100644
@@ -268,8 +268,8 @@ void pci_init_board(void)
 		 * Activate ULI1575 legacy chip by performing a fake
 		 * memory access.  Needed to make ULI RTC work.
 		 */
-		in_be32((unsigned *) CFG_PCI1_MEM_BASE
-			+ CFG_PCI1_MEM_SIZE - 0x1000000);
+		in_be32((unsigned *) ((char *)(CFG_PCI1_MEM_BASE
+				       + CFG_PCI1_MEM_SIZE - 0x1000000));
 
 	} else {
 		puts("PCI-EXPRESS 1: Disabled\n");
Signature · 1 line
1.5.0.3
#1 lore raw

PATCH 1/1 8641hpcn: Do correct sized pointer math.

Jon,

Quoted 6 lines · in message <1186440102.5970.49.camel@ld0161-tx32> you wrote:

When I rebased Ed's patch and cleaned up a few compilation problems, I apparently rebased my brain on crack first. Fix that by doing (char *) sized pointer math as needed.

Will you add this to the 86xx repo and send a pull request later, or do you want me to pick this up directly?

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
READ THIS BEFORE OPENING PACKAGE: According to Certain Suggested Ver-
sions of the Grand Unified Theory, the Primary Particles Constituting
this Product May Decay to Nothingness Within the  Next  Four  Hundred
Million Years.
#2 lore raw

PATCH 1/1 8641hpcn: Do correct sized pointer math.

Quoted 4 lines · Wolfgang Denk

Jon,

Quoted 1 line · in message <1186440102.5970.49.camel@ld0161-tx32> you wrote:
Quoted 8 lines
Quoted 5 lines

When I rebased Ed's patch and cleaned up a few compilation problems, I apparently rebased my brain on crack first. Fix that by doing (char *) sized pointer math as needed.

Will you add this to the 86xx repo and send a pull request later, or do you want me to pick this up directly?

I plan on adding it to the 8641 repo and having you pull it all!

I will also add Joe's SBC8641 patch there first.

I have just pushed out an updated -mpc86xx repo that has the former, and needs the latter still.

Thanks,
jdl