Skip to contentSkip to conversation

hexdump: use const notation

PATCH New Artem Bityutskiy 2 participants 2 messages Aug 7, 2007 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hexdump: use const notation

Trivial fix: mark the buffer to hexdump as const so callers could avoid casting their const buffers when calling print_hex_dump().

The patch is really trivial and I suggest to consider it as a fix (it fixes GCC warnings) and push it to current tree.

include/linux/kernel.h +1 -1
index 4300bb4..b4f5b81 100644
@@ -224,7 +224,7 @@ extern void hex_dump_to_buffer(const void *buf, size_t len,
 				char *linebuf, size_t linebuflen, bool ascii);
 extern void print_hex_dump(const char *level, const char *prefix_str,
 				int prefix_type, int rowsize, int groupsize,
-				void *buf, size_t len, bool ascii);
+				const void *buf, size_t len, bool ascii);
 extern void print_hex_dump_bytes(const char *prefix_str, int prefix_type,
 			void *buf, size_t len);
 #define hex_asc(x)	"0123456789abcdef"[x]
lib/hexdump.c +2 -2
index 473f5ae..16f2e29 100644
@@ -145,9 +145,9 @@ EXPORT_SYMBOL(hex_dump_to_buffer);
  */
 void print_hex_dump(const char *level, const char *prefix_str, int prefix_type,
 			int rowsize, int groupsize,
-			void *buf, size_t len, bool ascii)
+			const void *buf, size_t len, bool ascii)
 {
-	u8 *ptr = buf;
+	const u8 *ptr = buf;
 	int i, linelen, remaining = len;
 	unsigned char linebuf[200];
 
Signature · 2 lines
Best regards,
Artem Bityutskiy (Битюцкий Артём)
#1 lore raw

PATCH 1/1 hexdump: use const notation

From: Artem Bityutskiy <[email protected]>
Date: Tue, 7 Aug 2007 23:43:14 +0300
Subject: [PATCH] hexdump: use const notation

Trivial fix: mark the buffer to hexdump as const so callers could avoid casting their const buffers when calling print_hex_dump().

The patch is really trivial and I suggest to consider it as a fix (it fixes GCC warnings) and push it to current tree.

---

include/linux/kernel.h |    2 +-
lib/hexdump.c          |    4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
include/linux/kernel.h +0 -0
index 4300bb4..b4f5b81 100644
@@ -224,7 +224,7 @@ extern void hex_dump_to_buffer(const void *buf, size_t len,
				char *linebuf, size_t linebuflen, bool ascii);

extern void print_hex_dump(const char *level, const char *prefix_str,
int prefix_type, int rowsize, int groupsize,
- void *buf, size_t len, bool ascii);
+ const void *buf, size_t len, bool ascii);
extern void print_hex_dump_bytes(const char *prefix_str, int prefix_type,

			void *buf, size_t len);

#define hex_asc(x) "0123456789abcdef"[x]

lib/hexdump.c +0 -0
index 473f5ae..16f2e29 100644
@@ -145,9 +145,9 @@ EXPORT_SYMBOL(hex_dump_to_buffer);
 */

void print_hex_dump(const char *level, const char *prefix_str, int prefix_type,
int rowsize, int groupsize,
- void *buf, size_t len, bool ascii)
+ const void *buf, size_t len, bool ascii)
{
- u8 *ptr = buf;

+	const u8 *ptr = buf;
	int i, linelen, remaining = len;
	unsigned char linebuf[200];
Signature · 2 lines
Best Regards,
Artem Bityutskiy (Артём Битюцкий)