Skip to contentSkip to conversation

is_power_of_2 in drivers/rtc/rtc-s3c.c

kj vignesh babu 1 participant 1 message Aug 13, 2007

Subsystems (2)
Kernel janitors Real time clock (RTC)
lore
Share & tools
lore

vignesh babu

author
#0 lore raw

Replacing n & (n - 1) for power of 2 check by is_power_of_2(n)

Signed-off-by vignesh babu <[email protected]>

---

drivers/rtc/rtc-s3c.c +2 -1
index 8c1012b..9b06dc3 100644
@@ -20,6 +20,7 @@
 #include <linux/rtc.h>
 #include <linux/bcd.h>
 #include <linux/clk.h>
+#include <linux/log2.h>
 
 #include <asm/hardware.h>
 #include <asm/uaccess.h>

@@ -311,7 +312,7 @@ static int s3c_rtc_ioctl(struct device *dev,
 	case RTC_IRQP_SET:
 		/* check for power of 2 */
 
-		if ((arg & (arg-1)) != 0 || arg < 1) {
+		if (!is_power_of_2(arg)) {
 			ret = -EINVAL;
 			goto exit;
 		}
Signature · 12 lines
Vignesh Babu BM 
_____________________________________________________________ 
"Why is it that every time I'm with you, makes me believe in magic?"

_______________________________________________
REMINDER: this mailing list moved to vger.kernel.org and current one will be discontinued soon.
To resubscribe, send email to [email protected] with
&quot;subscribe kernel-janitors&quot; in message body and follow instructions.

Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors