Some musb Blackfin porting issues

Dear David and Tony:

I almost imported the musb stack to our Blackfin tree. But there are some code highly coupled with ARM Linux architecture. Please give me some idea about following issues:

1. Clock framework is not available in Blackfin Linux arch currently. Is it possible to skip it?

2. Registers layout in musb-regs.h is different with BF54x processor. I plan to write a musb-bf54x.h to replace the whole definition in musb-regs.h. Is that possible or do it conflict with current musb design?
in musb-regs.h:
---
#ifdef CONFIG_BF54x
#include "musb-bf54x.h"
#else
..... /* original code from musb-regs.h */
#endif
--

Thanks a lot
- Bryan Wu

Yes, you can have custom clock enable/disable functions, see tusb_set_clock() in arch/arm/mach-omap2/board-n800-usb.c.

I guess that's the way to go for now to get things working. Dave?

Tony

One minor issue would then be needing stub implementations of the clk_*() functions so the driver can link. The same issue comes up on x86 builds, which would be good to allow as part of routine build tests.

Maybe you can just provide a set of inlined NOP clock stubs in the musb code that would be included as needed. I'd suggest you avoid trying to solve that general cross-arch problem, at least initially.

Something like that, sure. But I'd like it better if it were more like two different #include files, one for Blackfin and one for the standard register layouts (matching Mentor specs).

Are those registers the same widths? If the differences go beyond just addressing, I'd forsee trouble ahead.

- Dave