Skip to contentSkip to conversation

USB touchscreen

PATCH Applied Vladimir Shebordaev 2 participants 2 messages Sep 6, 2007 – Sep 7, 2007 Input drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB touchscreen

This patch fixes a nasty typo in usbtouchscreen driver.

The typo is inherited from the original mtouchusb. It used to make the input subsytem to incorrectly report the physical device ids to userspace that in turn is much confusing for, e.g. XInput hotplug facilities in setups with multiple identical touchscreens.

---
 drivers/input/touchscreen/usbtouchscreen.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/input/touchscreen/usbtouchscreen.c +1 -1
index e3f2285..c32f447 100644
@@ -734,7 +734,7 @@ static int usbtouch_probe(struct usb_interface *intf,
 			 le16_to_cpu(udev->descriptor.idProduct));
 
 	usb_make_path(udev, usbtouch->phys, sizeof(usbtouch->phys));
-	strlcpy(usbtouch->phys, "/input0", sizeof(usbtouch->phys));
+	strlcat(usbtouch->phys, "/input0", sizeof(usbtouch->phys));
 
 	input_dev->name = usbtouch->name;
 	input_dev->phys = usbtouch->phys;
Signature · 1 line
1.5.2.2
#1 lore raw
Quoted 9 lines · Vladimir Shebordaev

This patch fixes a nasty typo in usbtouchscreen driver.

The typo is inherited from the original mtouchusb. It used to make the input subsytem to incorrectly report the physical device ids to userspace that in turn is much confusing for, e.g. XInput hotplug facilities in setups with multiple identical touchscreens.

Applied, thank you Vladimir.

Signature · 1 line
Dmitry