Skip to contentSkip to conversation

Delay creation of khcvd thread

PATCH In review Rusty Russell 2 participants 4 messages Sep 25, 2007 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Delay creation of khcvd thread

This changes hvc_init() to be called only when someone actually uses the hvc_console driver. Dave Jones complained when profiling bootup.

hvc_console used to only be for Power aka pSeries: now lguest and Xen both want it built-in in case the kernel is a guest under one of those, even though usually it will be a native boot.

---
 drivers/char/Kconfig       |    8 ++---
 drivers/char/hvc_console.c |   66 ++++++++++++++++++++++++++++++--------------
 2 files changed, 49 insertions(+), 25 deletions(-)

===================================================================

drivers/char/Kconfig +2 -2
@@ -568,10 +568,10 @@ config HVC_DRIVER
 config HVC_DRIVER
 	bool
 	help
-	  Users of pSeries machines that want to utilize the hvc console front-end
-	  module for their backend console driver should select this option.
+	  Generic "hypervisor virtual console" infrastructure for various
+	  hypervisors (pSeries, Xen, lguest).
 	  It will automatically be selected if one of the back-end console drivers
 	  is selected.
 
 
 config HVC_CONSOLE

===================================================================

drivers/char/hvc_console.c +45 -21

103 lines not on this page · raw message

#1 lore raw
Quoted 2 lines · On Tue, 25 Sep 2007 13:46:24 +1000 Rusty Russell <[email protected]> wrote:

hvc_console used to only be for Power aka pSeries: now lguest and Xen

Also legacy iSeries :-)

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#2 lore raw
Quoted 5 lines · Stephen Rothwell
Quoted 2 lines · On Tue, 25 Sep 2007 13:46:24 +1000 Rusty Russell <[email protected]> wrote:

hvc_console used to only be for Power aka pSeries: now lguest and Xen

Also legacy iSeries :-)

OK, how's this:
---
HVC console is also used by iSeries, so add that to HVC_DRIVER help.

drivers/char/Kconfig +1 -1
diff -r 85d39cbbd21c drivers/char/Kconfig
@@ -569,7 +569,7 @@ config HVC_DRIVER
 	bool
 	help
 	  Generic "hypervisor virtual console" infrastructure for various
-	  hypervisors (pSeries, Xen, lguest).
+	  hypervisors (pSeries, iSeries, Xen, lguest).
 	  It will automatically be selected if one of the back-end console drivers
 	  is selected.
 
#3 lore raw

Hi Rusty,

Quoted 9 lines · On Tue, 25 Sep 2007 14:27:41 +1000 Rusty Russell <[email protected]> wrote:

HVC console is also used by iSeries, so add that to HVC_DRIVER help.

diff -r 85d39cbbd21c drivers/char/Kconfig

drivers/char/Kconfig config HVC_DRIVER · line 574

Quoted 7 lines
drivers/char/Kconfig +1 -1
@@ -569,7 +569,7 @@ config HVC_DRIVER
 	bool
 	help
 	  Generic "hypervisor virtual console" infrastructure for various
-	  hypervisors (pSeries, Xen, lguest).
+	  hypervisors (pSeries, iSeries, Xen, lguest).
 	  It will automatically be selected if one of the back-end console drivers
 	  is selected.

;-)

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/