Skip to contentSkip to conversation

xpad_probe: undefined reference to `led_classdev_register'

DISCUSSION [email protected] 3 participants 4 messages Sep 26, 2007

lore
Share & tools
lore
#0 lore raw

Hi.

Current linus' git tree:

x86_64-unknown-linux-gnu-ld: BFD 2.15 assertion fail /home/thomas/source/crosstool-0.43/build/x86_64-unknown-linux-gnu/gcc-3.4.5-glibc-2.3.6/binutils-2.15/bfd/linker.c:619 drivers/built-in.o(.text+0x20749d): In function `xpad_probe':
: undefined reference to `led_classdev_register'
drivers/built-in.o(.text+0x20756c): In function `xpad_disconnect':
: undefined reference to `led_classdev_unregister'
make: *** [.tmp_vmlinux1] Fehler 1

any ideas?

mfg
thomas

#1 lore raw
Quoted 12 lines · On Wed, 26 Sep 2007 23:25:33 +0200 [email protected] wrote:

Hi.

Current linus' git tree:

x86_64-unknown-linux-gnu-ld: BFD 2.15 assertion fail /home/thomas/source/crosstool-0.43/build/x86_64-unknown-linux-gnu/gcc-3.4.5-glibc-2.3.6/binutils-2.15/bfd/linker.c:619 drivers/built-in.o(.text+0x20749d): In function `xpad_probe':
: undefined reference to `led_classdev_register'
drivers/built-in.o(.text+0x20756c): In function `xpad_disconnect':
: undefined reference to `led_classdev_unregister'
make: *** [.tmp_vmlinux1] Fehler 1

Quoted 1 line

any ideas?

Please send .config file.

Ix xpad driver built-in (yes, it is) and led driver is modular? We can fix that...

---
~Randy
Phaedrus says that Quality is about caring.

#2 lore raw

Hi,

Quoted 14 lines · Randy Dunlap
Quoted 12 lines · On Wed, 26 Sep 2007 23:25:33 +0200 [email protected] wrote:

Hi.

Current linus' git tree:

x86_64-unknown-linux-gnu-ld: BFD 2.15 assertion fail /home/thomas/source/crosstool-0.43/build/x86_64-unknown-linux-gnu/gcc-3.4.5-glibc-2.3.6/binutils-2.15/bfd/linker.c:619 drivers/built-in.o(.text+0x20749d): In function `xpad_probe':
: undefined reference to `led_classdev_register'
drivers/built-in.o(.text+0x20756c): In function `xpad_disconnect':
: undefined reference to `led_classdev_unregister'
make: *** [.tmp_vmlinux1] Fehler 1

Quoted 7 lines
Quoted 1 line

any ideas?

Please send .config file.

Ix xpad driver built-in (yes, it is) and led driver is modular? We can fix that...

I have the patch below in mytree. I guess I need to forward it to Linus insterad of waiting for 2.6.24 as too many people hit this.

Signature · 24 lines
Dmitry
 
Input: xpad - fix dependancy on LEDS class

The driver can not be built-in when LEDS class is a module.

Signed-off-by: Dmitry Torokhov <[email protected]>
---
 drivers/input/joystick/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: work/drivers/input/joystick/Kconfig
===================================================================
--- work.orig/drivers/input/joystick/Kconfig
+++ work/drivers/input/joystick/Kconfig
@@ -277,7 +277,7 @@ config JOYSTICK_XPAD_FF
 
 config JOYSTICK_XPAD_LEDS
 	bool "LED Support for Xbox360 controller 'BigX' LED"
-	depends on LEDS_CLASS && JOYSTICK_XPAD
+	depends on JOYSTICK_XPAD && (LEDS_CLASS=y || LEDS_CLASS=JOYSTICK_XPAD)
 	---help---
 	  This option enables support for the LED which surrounds the Big X on
 	  XBox 360 controller.
#3 lore raw
Quoted 19 lines · On Wed, 26 Sep 2007 18:33:22 -0400 Dmitry Torokhov wrote:

Hi,

Quoted 16 lines · Randy Dunlap
Quoted 13 lines · On Wed, 26 Sep 2007 23:25:33 +0200 [email protected] wrote:

Hi.

Current linus' git tree:

x86_64-unknown-linux-gnu-ld: BFD 2.15 assertion fail /home/thomas/source/crosstool-0.43/build/x86_64-unknown-linux-gnu/gcc-3.4.5-glibc-2.3.6/binutils-2.15/bfd/linker.c:619 drivers/built-in.o(.text+0x20749d): In function `xpad_probe':
: undefined reference to `led_classdev_register'
drivers/built-in.o(.text+0x20756c): In function `xpad_disconnect':
: undefined reference to `led_classdev_unregister'
make: *** [.tmp_vmlinux1] Fehler 1

any ideas?

Quoted 17 lines
Quoted 5 lines

Please send .config file.

Ix xpad driver built-in (yes, it is) and led driver is modular? We can fix that...

I have the patch below in mytree. I guess I need to forward it to Linus insterad of waiting for 2.6.24 as too many people hit this.

Signature · 7 lines
Dmitry
 
Input: xpad - fix dependancy on LEDS class

The driver can not be built-in when LEDS class is a module.

Signed-off-by: Dmitry Torokhov <[email protected]>

Yes, looks good. Thanks.

Quoted 9 lines
---
 drivers/input/joystick/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: work/drivers/input/joystick/Kconfig
===================================================================

drivers/input/joystick/Kconfig config JOYSTICK_XPAD_FF

Quoted 9 lines
drivers/input/joystick/Kconfig +1 -2
@@ -277,7 +277,7 @@ config JOYSTICK_XPAD_FF
 
 config JOYSTICK_XPAD_LEDS
 	bool "LED Support for Xbox360 controller 'BigX' LED"
-	depends on LEDS_CLASS && JOYSTICK_XPAD
+	depends on JOYSTICK_XPAD && (LEDS_CLASS=y || LEDS_CLASS=JOYSTICK_XPAD)
 	---help---
 	  This option enables support for the LED which surrounds the Big X on
 	  XBox 360 controller.
-

---
~Randy
Phaedrus says that Quality is about caring.