Skip to contentSkip to conversation

2.6.23.git build error

PATCH Applied Mike Galbraith 4 participants 10 messages Oct 12, 2007 – Oct 17, 2007 1 message not in the archive x86

lore
Share & tools
lore
#0 lore raw

Greetings,

Freshly pulled 2.6.23.git failed to build:

make[1]: *** No rule to make target arch/x86/kernel/asm-offsets.c', needed by arch/x86/kernel/asm-offsets.s'. Stop.
make: *** [prepare0] Error 2
make: *** Waiting for unfinished jobs....

-Mike

#1 lore raw
Quoted 7 lines · Mike Galbraith

Greetings,

Freshly pulled 2.6.23.git failed to build:

make[1]: *** No rule to make target arch/x86/kernel/asm-offsets.c', needed by arch/x86/kernel/asm-offsets.s'. Stop.
make: *** [prepare0] Error 2
make: *** Waiting for unfinished jobs....

You are the only reporter of this bug.
I do not see it here and I have the asm-offset.c file.

Have you figured out more about this bug?
For now I assume you did something bad when you updated your kernel tree. Could you as minimum check the content of the arch/x86/kernel/ directory.

Thanks,
Sam

#2 lore raw
Quoted 11 lines · Sam Ravnborg
Quoted 7 lines · Mike Galbraith

Greetings,

Freshly pulled 2.6.23.git failed to build:

make[1]: *** No rule to make target arch/x86/kernel/asm-offsets.c', needed by arch/x86/kernel/asm-offsets.s'. Stop.
make: *** [prepare0] Error 2
make: *** Waiting for unfinished jobs....

You are the only reporter of this bug.
I do not see it here and I have the asm-offset.c file.

Yeah, I noticed nobody else was griping.

Quoted 3 lines

Have you figured out more about this bug?
For now I assume you did something bad when you updated your kernel tree. Could you as minimum check the content of the arch/x86/kernel/ directory.

I just re-pulled, and the little bugger showed up. Elves and Gremlins at play I guess.

-Mike

#3 lore raw
Quoted 6 lines · Mike Galbraith
Quoted 5 lines · Sam Ravnborg
Quoted 4 lines · Mike Galbraith

Greetings,

Freshly pulled 2.6.23.git failed to build:

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

make[1]: *** No rule to make target arch/x86/kernel/asm-offsets.c', needed by arch/x86/kernel/asm-offsets.s'. Stop.
make: *** [prepare0] Error 2
make: *** Waiting for unfinished jobs....

You are the only reporter of this bug.
I do not see it here and I have the asm-offset.c file.

Yeah, I noticed nobody else was griping.

I also saw this behaiour, but make mrproper solved the problem.

ciao
cate

#4 lore raw
Quoted 10 lines · Giacomo Catenazzi
Quoted 9 lines · Mike Galbraith
Quoted 8 lines · Sam Ravnborg
Quoted 7 lines · Mike Galbraith

Greetings,

Freshly pulled 2.6.23.git failed to build:

make[1]: *** No rule to make target arch/x86/kernel/asm-offsets.c', needed by arch/x86/kernel/asm-offsets.s'. Stop.
make: *** [prepare0] Error 2
make: *** Waiting for unfinished jobs....

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

You are the only reporter of this bug.
I do not see it here and I have the asm-offset.c file.

Yeah, I noticed nobody else was griping.

I also saw this behaiour, but make mrproper solved the problem.

Pulled 2.6.23 tree and did a build
Added latest -linus on top of it.
Did a new build (x86_64).

As expected it failed due to wrong asm symlink but nothing like the error Mike posted.
So I'm a bit puzzeled here.

I anyone can explain how to reproduce it I will chase it but otherwise it will be left as a "consequence of the x86 merge".

Sam

#5 lore raw
Quoted 5 lines · Sam Ravnborg

Pulled 2.6.23 tree and did a build
Added latest -linus on top of it.
Did a new build (x86_64).

Quoted 7 lines

As expected it failed due to wrong asm symlink but nothing like the error Mike posted.
So I'm a bit puzzeled here.

I anyone can explain how to reproduce it I will chase it but otherwise it will be left as a "consequence of the x86 merge".

What I did was to pull, then diff against my working tree (/me=SCM weenie;) for review as usual, and then apply that diff to working tree and make oldconfig as usual. That left me with the same failure this morning, despite the file being verified present in the git tree. I then used git-archive --format=tar | (cd work_tree;tar -xvf -). That spewed chunks when I tried to build it even though diff said the trees were identical. After make mrproper and restoring my saved .config, all was peachy.

Methinks dontdiff bit me.

-Mike

#6 lore raw
Quoted 24 lines · Mike Galbraith
Quoted 5 lines · Sam Ravnborg

Pulled 2.6.23 tree and did a build
Added latest -linus on top of it.
Did a new build (x86_64).

Quoted 7 lines

As expected it failed due to wrong asm symlink but nothing like the error Mike posted.
So I'm a bit puzzeled here.

I anyone can explain how to reproduce it I will chase it but otherwise it will be left as a "consequence of the x86 merge".

What I did was to pull, then diff against my working tree (/me=SCM weenie;) for review as usual, and then apply that diff to working tree and make oldconfig as usual. That left me with the same failure this morning, despite the file being verified present in the git tree. I then used git-archive --format=tar | (cd work_tree;tar -xvf -). That spewed chunks when I tried to build it even though diff said the trees were identical. After make mrproper and restoring my saved .config, all was peachy.

Quoted 1 line

Methinks dontdiff bit me.

After a quick look:
[sam@neptun x86.git]$ find -name '*.i' ./include/asm-x86/alternative-asm_64.i ./include/asm-x86/alternative-asm_32.i ./include/asm-x86/frame.i ./include/asm-x86/alternative-asm.i ./include/asm-um/frame.i ./include/asm-um/alternative-asm.i
[sam@neptun x86.git]$ grep '*.i' Documentation/dontdiff *.i

But I cannot see how this could result in the bug you reported..
Anyway at least one dontdiff buglet - or we should preferably drop the .i files in the kernel src.

Sam

#7 lore raw
Quoted 4 lines · Sam Ravnborg

But I cannot see how this could result in the bug you reported..
Anyway at least one dontdiff buglet - or we should preferably drop the .i files in the kernel src.

I have a patch from Adrian staged to do this.

tglx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#9 lore raw

PATCH 1/1 x86: delete vsyscall files during make clean

make clean failed to delete a few files in x86/kernel. This is because kbuild does not see the correct/full kernel/Makefile.

As a workaround until the Makefiles are merged specify the files to be deleted in the common Makefile.

Reported by Mike Galbraith <[email protected]>

Cc Mike Galbraith <[email protected]>

---

arch/x86/kernel/Makefile +4 -0
index 45855c9..3857334 100644
@@ -3,3 +3,7 @@ include ${srctree}/arch/x86/kernel/Makefile_32
 else
 include ${srctree}/arch/x86/kernel/Makefile_64
 endif
+
+# Workaround to delete .lds files with make clean
+# The problem is that we do not enter Makefile_32 with make clean.
+clean-files := vsyscall*.lds vsyscall*.so
#10 lore raw

Re: [PATCH] x86: delete vsyscall files during make clean

Quoted 17 lines · Sam Ravnborg

make clean failed to delete a few files in x86/kernel. This is because kbuild does not see the correct/full kernel/Makefile.

As a workaround until the Makefiles are merged specify the files to be deleted in the common Makefile.

Reported by Mike Galbraith <[email protected]>

Cc Mike Galbraith <[email protected]>

---

arch/x86/kernel/Makefile +0 -0
index 45855c9..3857334 100644

arch/x86/kernel/Makefile include ${srctree}/arch/x86/kernel/Makefile_32 · line 9

Quoted 7 lines
arch/x86/kernel/Makefile +4 -0
@@ -3,3 +3,7 @@ include ${srctree}/arch/x86/kernel/Makefile_32
 else
 include ${srctree}/arch/x86/kernel/Makefile_64
 endif
+
+# Workaround to delete .lds files with make clean
+# The problem is that we do not enter Makefile_32 with make clean.
+clean-files := vsyscall*.lds vsyscall*.so

Thanks applied,

tglx