Skip to contentSkip to conversation

Fix the issue of usb_kbd driver missing the scan code of key 'z'.

PATCH New Zhang Wei 3 participants 3 messages Oct 25, 2007 – Nov 3, 2007

lore
Share & tools
lore

Zhang Wei

author
#0 lore raw

PATCH 1/1 Fix the issue of usb_kbd driver missing the scan code of key 'z'.

The scan code of the key 'z' is 0x1d, which should be handled.

The change has be tested on NOVATEK USB keyboard and ULI PCI OHCI controller.

---
 common/usb_kbd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
common/usb_kbd.c +1 -1
index aec558a..7bdfcc0 100644
@@ -257,7 +257,7 @@ static int usb_kbd_translate(unsigned char scancode,unsigned char modifier,int p
 		repeat_delay=REPEAT_DELAY;
 	}
 	keycode=0;
-	if((scancode>3) && (scancode<0x1d)) { /* alpha numeric values */
+	if((scancode>3) && (scancode<=0x1d)) { /* alpha numeric values */
 		keycode=scancode-4 + 0x61;
 		if(caps_lock)
 			keycode&=~CAPITAL_MASK; /* switch to capital Letters */
Signature · 1 line
1.5.2
#1 lore raw

PATCH 1/1 Fix the issue of usb_kbd driver missing the scan code of key 'z'.

Quoted 6 lines · Zhang Wei

The scan code of the key 'z' is 0x1d, which should be handled.

The change has be tested on NOVATEK USB keyboard and ULI PCI OHCI controller.

Thanks, add to USB custodian repo.

Best regards

Markus Klotzb?cher

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de

#2 lore raw

PATCH 1/1 Fix the issue of usb_kbd driver missing the scan code of key 'z'.

In reply to Zhang Wei
Quoted 6 lines · In message <[email protected]> you wrote:

The scan code of the key 'z' is 0x1d, which should be handled.

The change has be tested on NOVATEK USB keyboard and ULI PCI OHCI controller.

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The face of war has never changed.  Surely it is more logical to heal
than to kill.
	-- Surak of Vulcan, "The Savage Curtain", stardate 5906.5