lpfc 8.2.3 : Miscellaneous Small Fixes - part 1
Subsystems (2)
PATCH 4/9 lpfc 8.2.3 : Miscellaneous Small Fixes - part 1
Miscellaneous Small Fixes - part 1
- Fix typo kmzlloc -> kzalloc
- Fix discovery ndlp use after free panic
- Fix link event causing flood of 0108 messages
- Relieve some mbox congestion on link up with 100 vports
- Fix broken vport parameters
- Prevent lock recursion in logo_reglogin_issue
- Split uses of error variable in lpfc_pci_probe_one into retval and error
- Remove completion code related to dev_loss_tmo
- Remove unused LPFC_MAX_HBQ #define
- Don't compare pointers to 0 for sparse
- Make 2 functions static for sparse
- Fix default rpi cleanup code causing rogue ndlps to remain on the NPR list
- Remove annoying ELS messages when driver is unloaded
- Fix Cannot issue Register Fabric login problems on link up
- Remove LPFC_EVT_DEV_LOSS_DELAY
- Fix FC port swap test leads to device going offline
- Fix vport CT flags to only be set when accepted
- Add code to handle signals during vport_create
- Fix too many retries in FC-AL mode
- Pull lpfc_port_link_failure out of lpfc_linkdown_port
drivers/scsi/lpfc/lpfc_attr.c +58 -4
@@ -2363,13 +2363,67 @@ struct fc_function_template lpfc_transpo .dev_loss_tmo_callbk = lpfc_dev_loss_tmo_callbk, .terminate_rport_io = lpfc_terminate_rport_io, -/* Vport fields are filled in at runtime based on enable_npiv */ - .vport_create = NULL, - .vport_delete = NULL, - .vport_disable = NULL, .dd_fcvport_size = sizeof(struct lpfc_vport *), }; +struct fc_function_template lpfc_vport_transport_functions = { +/* fixed attributes the driver supports */ + .show_host_node_name =1 , + .show_host_port_name =1 , + .show_host_supported_classes =1 , + .show_host_supported_fc4s =1 , + .show_host_supported_speeds =1 , + .show_host_maxframe_size =1 , + +/* dynamic attributes the driver supports */ + .get_host_port_id = lpfc_get_host_port_id, + .show_host_port_id =1 , + + .get_host_port_type = lpfc_get_host_port_type, + .show_host_port_type =1 , + + .get_host_port_state = lpfc_get_host_port_state, + .show_host_port_state =1 , + +/* active_fc4s is shown but doesn't change (thus no get function) */ + .show_host_active_fc4s =1 , + + .get_host_speed = lpfc_get_host_speed, + .show_host_speed =1 , + + .get_host_fabric_name = lpfc_get_host_fabric_name, + .show_host_fabric_name =1 , + +/* +* The LPFC driver treats linkdown handling as target loss events +* so there are no sysfs handlers for link_down_tmo. +*/ + + .get_fc_host_stats = lpfc_get_stats, + .reset_fc_host_stats = lpfc_reset_stats, + + .dd_fcrport_size =sizeof (struct lpfc_rport_data ), + .show_rport_maxframe_size =1 , + .show_rport_supported_classes =1 , + + .set_rport_dev_loss_tmo = lpfc_set_rport_loss_tmo, + .show_rport_dev_loss_tmo =1 , + + .get_starget_port_id = lpfc_get_starget_port_id, + .show_starget_port_id =1 , + + .get_starget_node_name = lpfc_get_starget_node_name, + .show_starget_node_name =1 , + + .get_starget_port_name = lpfc_get_starget_port_name, + .show_starget_port_name =1 , + + .dev_loss_tmo_callbk = lpfc_dev_loss_tmo_callbk, + .terminate_rport_io = lpfc_terminate_rport_io, + + .vport_disable = lpfc_vport_disable, +}; +void lpfc_get_cfgparam (struct lpfc_hba *phba) {
drivers/scsi/lpfc/lpfc_crtn.h +2 -0
@@ -68,6 +68,7 @@ int lpfc_check_sli_ndlp(struct lpfc_hbavoid lpfc_nlp_init (struct lpfc_vport *,struct lpfc_nodelist *,uint32_t );struct lpfc_nodelist *lpfc_nlp_get (struct lpfc_nodelist *);int lpfc_nlp_put (struct lpfc_nodelist *); +int lpfc_nlp_not_used (struct lpfc_nodelist *ndlp);struct lpfc_nodelist *lpfc_setup_disc_node (struct lpfc_vport *,uint32_t );void lpfc_disc_list_loopmap (struct lpfc_vport *);void lpfc_disc_start (struct lpfc_vport *);
@@ -260,6 +261,7 @@ extern struct class_device_attribute *lpextern struct scsi_host_template lpfc_template;extern struct scsi_host_template lpfc_vport_template;extern struct fc_function_template lpfc_transport_functions; +extern struct fc_function_template lpfc_vport_transport_functions;extern int lpfc_sli_mode;extern int lpfc_enable_npiv;
drivers/scsi/lpfc/lpfc_ct.c +51 -11
98 lines not on this page · raw message
drivers/scsi/lpfc/lpfc_disc.h +1 -1
@@ -36,7 +36,6 @@ enum lpfc_work_type {LPFC_EVT_WARM_START ,LPFC_EVT_KILL ,LPFC_EVT_ELS_RETRY , -LPFC_EVT_DEV_LOSS_DELAY , LPFC_EVT_DEV_LOSS, };
@@ -104,6 +103,7 @@ struct lpfc_nodelist {#define NLP_RM_DFLT_RPI 0x4000000/* need to remove leftover dflt RPI */ #define NLP_NODEV_REMOVE 0x8000000/* Defer removal till discovery ends */ #define NLP_TARGET_REMOVE 0x10000000/* Target remove in process */ +#define NLP_DELAYED_RM 0x20000000/* Defer UNUSED List removal */ /* There are 4 different double linked lists nodelist entries can reside on. * The Port Login (PLOGI) list and Address Discovery (ADISC) list are used
drivers/scsi/lpfc/lpfc_els.c +114 -40
372 lines not on this page · raw message
drivers/scsi/lpfc/lpfc_hbadisc.c +77 -46
242 lines not on this page · raw message
drivers/scsi/lpfc/lpfc_init.c +23 -19
99 lines not on this page · raw message
drivers/scsi/lpfc/lpfc_mbox.c +8 -4
@@ -288,8 +288,10 @@ lpfc_read_sparam(struct lpfc_hba *phba,/* Get a buffer to hold the HBAs Service Parameters */ -if (((mp =kmalloc (sizeof (struct lpfc_dmabuf ),GFP_KERNEL )) ==0 ) || - ((mp->virt =lpfc_mbuf_alloc (phba,0 , &(mp->phys))) ==0 )) { + mp =kmalloc (sizeof (struct lpfc_dmabuf ),GFP_KERNEL ); +if (mp) + mp->virt =lpfc_mbuf_alloc (phba,0 , &mp->phys); +if (!mp || !mp->virt) {kfree (mp); mb->mbxCommand =MBX_READ_SPARM64 ;/* READ_SPARAM: no buffers */
@@ -387,8 +389,10 @@ lpfc_reg_login(struct lpfc_hba *phba, ui mb->mbxOwner =OWN_HOST ;/* Get a buffer to hold NPorts Service Parameters */ -if (((mp =kmalloc (sizeof (struct lpfc_dmabuf ),GFP_KERNEL )) ==NULL ) || - ((mp->virt =lpfc_mbuf_alloc (phba,0 , &(mp->phys))) ==0 )) { + mp =kmalloc (sizeof (struct lpfc_dmabuf ),GFP_KERNEL ); +if (mp) + mp->virt =lpfc_mbuf_alloc (phba,0 , &mp->phys); +if (!mp || !mp->virt) {kfree (mp); mb->mbxCommand =MBX_REG_LOGIN64 ;/* REG_LOGIN: no buffers */
drivers/scsi/lpfc/lpfc_nportdisc.c +1 -1
@@ -1135,7 +1135,7 @@ lpfc_rcv_logo_reglogin_issue(struct lpfc (ndlp == (struct lpfc_nodelist *) mb->context2)) { mp = (struct lpfc_dmabuf *) (mb->context1);if (mp) { -lpfc_mbuf_free (phba, mp->virt, mp->phys); +__lpfc_mbuf_free (phba, mp->virt, mp->phys);kfree (mp); }lpfc_nlp_put (ndlp);
drivers/scsi/lpfc/lpfc_sli.c +5 -5
@@ -1914,8 +1914,8 @@ lpfc_sli_brdkill(struct lpfc_hba *phba)"0329 Kill HBA Data: x%x x%x\n" , phba->pport->port_state, psli->sli_flag); -if ((pmb = (LPFC_MBOXQ_t *)mempool_alloc (phba->mbox_mem_pool, -GFP_KERNEL )) ==0 ) + pmb = (LPFC_MBOXQ_t *)mempool_alloc (phba->mbox_mem_pool,GFP_KERNEL ); +if (!pmb)return 1 ;/* Disable the error attention */
@@ -2809,7 +2809,7 @@ lpfc_sli_next_iocb(struct lpfc_hba *phba/* * Lockless version of lpfc_sli_issue_iocb. */ -int +static int __lpfc_sli_issue_iocb (struct lpfc_hba *phba,struct lpfc_sli_ring *pring,struct lpfc_iocbq *piocb,uint32_t flag) {
@@ -2954,7 +2954,7 @@ lpfc_extra_ring_setup( struct lpfc_hba *return 0 ; } -void +static void lpfc_sli_async_event_handler (struct lpfc_hba * phba,struct lpfc_sli_ring * pring,struct lpfc_iocbq * iocbq) {
@@ -3717,7 +3717,7 @@ lpfc_sli_issue_mbox_wait(struct lpfc_hbaunsigned long flag;/* The caller must leave context1 empty. */ -if (pmboxq->context1 !=0 ) +if (pmboxq->context1)return MBX_NOT_FINISHED ;/* setup wake call as IOCB callback */
drivers/scsi/lpfc/lpfc_sli.h +0 -3
@@ -197,9 +197,6 @@ struct lpfc_hbq_init {uint32_t add_count;/* number to allocate when starved */ } ; -#define LPFC_MAX_HBQ 16 - -/* Structure used to hold SLI statistical counters and info */ struct lpfc_sli_stat {uint64_t mbox_stat_err;/* Mbox cmds completed status error */
drivers/scsi/lpfc/lpfc_vport.c +32 -14
66 lines not on this page · raw message