Skip to contentSkip to conversation

sdio_uart: fix sign of paramter status in sdio_uart_receive_chars()

PATCH In review Andre Haupt 3 participants 3 messages Nov 21, 2007 – Nov 24, 2007

Subsystems (2)
Kernel janitors MMC, SD and SDIO
lore
Share & tools
lore

Andre Haupt

author
#0 lore raw

PATCH 1/1 sdio_uart: fix sign of paramter status in sdio_uart_receive_chars()

I think, the status paramter should be unsigned. Is this correct? This also fixes a sparse warning about different signedness. Only compile tested, because i do not have the hardware.

From: Andre Haupt <[email protected]>

Signed-off-by Andre Haupt <[email protected]>
---
 drivers/mmc/card/sdio_uart.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/card/sdio_uart.c +1 -1
index d552de6..eeea84c 100644
@@ -386,7 +386,7 @@ static void sdio_uart_stop_rx(struct sdio_uart_port *port)
 	sdio_out(port, UART_IER, port->ier);
 }
 
-static void sdio_uart_receive_chars(struct sdio_uart_port *port, int *status)
+static void sdio_uart_receive_chars(struct sdio_uart_port *port, unsigned int *status)
 {
 	struct tty_struct *tty = port->tty;
 	unsigned int ch, flag;
Signature · 1 line
1.4.4.4
#1 lore raw
Quoted 6 lines · On Wed, 21 Nov 2007 12:33:45 +0100 Andre Haupt <[email protected]> wrote:

I think, the status paramter should be unsigned. Is this correct? This also fixes a sparse warning about different signedness. Only compile tested, because i do not have the hardware.

From: Andre Haupt <[email protected]>

Signed-off-by Andre Haupt <[email protected]>

Nicolas, does this seem correct to you? I'm not familiar with the serial stuff.

Rgds

Signature · 5 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
Acked-by
#2 lore raw
Quoted 7 lines · Pierre Ossman
Quoted 4 lines · On Wed, 21 Nov 2007 12:33:45 +0100 Andre Haupt <[email protected]> wrote:

I think, the status paramter should be unsigned. Is this correct? This also fixes a sparse warning about different signedness. Only compile tested, because i do not have the hardware.

Quoted 5 lines
Quoted 2 lines

From: Andre Haupt <[email protected]>

Signed-off-by Andre Haupt <[email protected]>

Nicolas, does this seem correct to you? I'm not familiar with the serial stuff.

Yes, that should be fine.

Acked-by Nicolas Pitre <[email protected]>

Nicolas