pnpacpi : exceeded the max number of IO resources
Subsystems (2)
For what it is worth I too have seen this problem this morning and it DOES appear to be new (in contrast to a previous comment)
The message: pnpacpi: exceeded the max number of mem resources: 12
is displayed each time the system is booted with the 2.6.24-rc3-git5 kernel but is NOT displayed when booting 2.6.24-rc3-git4
I have made no changes in my config file between these two kernels other than to accept any new defaults when running make oldconfig.
If you had already narrowed it down to a change between git4 and git5 I apologize for wasting your time. Have to run to work now.
Chris
Quoted 5 lines · Chris Holvenstot
For what it is worth I too have seen this problem this morning and it DOES appear to be new (in contrast to a previous comment)
The message: pnpacpi: exceeded the max number of mem resources: 12
Quoted 8 lines
is displayed each time the system is booted with the 2.6.24-rc3-git5 kernel but is NOT displayed when booting 2.6.24-rc3-git4
I have made no changes in my config file between these two kernels other than to accept any new defaults when running make oldconfig.
If you had already narrowed it down to a change between git4 and git5 I apologize for wasting your time. Have to run to work now.
Thanks, and re-added the proper CCs. Sigh...
Well, yes, the warning is actually new as well. Previously your kernel just silently ignored 8 more mem resources than it does now it seems.
Given that people are hitting these limits, it might make sense to just do away with the warning for 2.6.24 again while waiting for the dynamic code?
Rene.
Quoted 13 lines · Rene Herman
Quoted 11 lines · Chris Holvenstot
For what it is worth I too have seen this problem this morning and it DOES appear to be new (in contrast to a previous comment)
The message: pnpacpi: exceeded the max number of mem resources: 12
is displayed each time the system is booted with the 2.6.24-rc3-git5 kernel but is NOT displayed when booting 2.6.24-rc3-git4
I have made no changes in my config file between these two kernels other than to accept any new defaults when running make oldconfig.
Quoted 8 lines
Quoted 2 lines
If you had already narrowed it down to a change between git4 and git5 I apologize for wasting your time. Have to run to work now.
Thanks, and re-added the proper CCs. Sigh...
Well, yes, the warning is actually new as well. Previously your kernel just silently ignored 8 more mem resources than it does now it seems.
Given that people are hitting these limits, it might make sense to just do away with the warning for 2.6.24 again while waiting for the dynamic code?
Ping. Should these warnings be reverted for 2.6.24?
Rene.
Quoted 23 lines · Rene Herman
Quoted 21 lines · Rene Herman
Quoted 5 lines · Chris Holvenstot
For what it is worth I too have seen this problem this morning and it DOES appear to be new (in contrast to a previous comment)
The message: pnpacpi: exceeded the max number of mem resources: 12
Quoted 8 lines
is displayed each time the system is booted with the 2.6.24-rc3-git5 kernel but is NOT displayed when booting 2.6.24-rc3-git4
I have made no changes in my config file between these two kernels other than to accept any new defaults when running make oldconfig.
If you had already narrowed it down to a change between git4 and git5 I apologize for wasting your time. Have to run to work now.
Thanks, and re-added the proper CCs. Sigh...
Well, yes, the warning is actually new as well. Previously your kernel just silently ignored 8 more mem resources than it does now it seems.
Quoted 8 lines
Quoted 3 lines
Given that people are hitting these limits, it might make sense to just do away with the warning for 2.6.24 again while waiting for the dynamic code?
Ping. Should these warnings be reverted for 2.6.24?
Rene.
Rene -
Thanks for the follow up - from my perspective now that I know that the condition that caused the warning messages has been with us for some time, and that previously the messages were suppressed it really does not make that much difference to me if the warnings are reverted or not.
So I guess that I vote for doing whatever is best for the developer. After all they are the ones doing the heavy lifting. If the warning message is able to provide some insight into the problem so much the better.
At this point my goal is just to learn enough to be an asset as a tester instead of a net loss (defined as someone whose efforts cost the team more man-hours than their contribution is worth)
Chris
Quoted 20 lines · Rene Herman
Quoted 18 lines · Rene Herman
Quoted 5 lines · Chris Holvenstot
For what it is worth I too have seen this problem this morning and it DOES appear to be new (in contrast to a previous comment)
The message: pnpacpi: exceeded the max number of mem resources: 12
Quoted 8 lines
is displayed each time the system is booted with the 2.6.24-rc3-git5 kernel but is NOT displayed when booting 2.6.24-rc3-git4
I have made no changes in my config file between these two kernels other than to accept any new defaults when running make oldconfig.
If you had already narrowed it down to a change between git4 and git5 I apologize for wasting your time. Have to run to work now.
Thanks, and re-added the proper CCs. Sigh...
Quoted 8 lines
Quoted 6 lines
Well, yes, the warning is actually new as well. Previously your kernel just silently ignored 8 more mem resources than it does now it seems.
Given that people are hitting these limits, it might make sense to just do away with the warning for 2.6.24 again while waiting for the dynamic code?
Ping. Should these warnings be reverted for 2.6.24?
Revert the warning doesn't make any sense. I'd suggest changing the IO resources number bigger till Thomas's patch in.
Shaohua
Quoted 25 lines · Shaohua Li
Quoted 23 lines · Rene Herman
Quoted 21 lines · Rene Herman
Quoted 5 lines · Chris Holvenstot
For what it is worth I too have seen this problem this morning and it DOES appear to be new (in contrast to a previous comment)
The message: pnpacpi: exceeded the max number of mem resources: 12
Quoted 8 lines
is displayed each time the system is booted with the 2.6.24-rc3-git5 kernel but is NOT displayed when booting 2.6.24-rc3-git4
I have made no changes in my config file between these two kernels other than to accept any new defaults when running make oldconfig.
If you had already narrowed it down to a change between git4 and git5 I apologize for wasting your time. Have to run to work now.
Thanks, and re-added the proper CCs. Sigh...
Well, yes, the warning is actually new as well. Previously your kernel just silently ignored 8 more mem resources than it does now it seems.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Given that people are hitting these limits, it might make sense to just do away with the warning for 2.6.24 again while waiting for the dynamic code?
Ping. Should these warnings be reverted for 2.6.24?
Revert the warning doesn't make any sense. I'd suggest changing the IO resources number bigger till Thomas's patch in.
Agree.
Change it to 90 works for me, But I think maybe 128 is better.
include/linux/pnp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/pnp.h +1 -1
@@ -13,7 +13,7 @@#include <linux/errno.h> #include <linux/mod_devicetable.h> -#define PNP_MAX_PORT 24 +#define PNP_MAX_PORT 128#define PNP_MAX_MEM 12#define PNP_MAX_IRQ 2#define PNP_MAX_DMA 2
Quoted 43 lines · Dave Young
Quoted 25 lines · Shaohua Li
Quoted 23 lines · Rene Herman
Quoted 21 lines · Rene Herman
Quoted 5 lines · Chris Holvenstot
For what it is worth I too have seen this problem this morning and it DOES appear to be new (in contrast to a previous comment)
The message: pnpacpi: exceeded the max number of mem resources: 12
Quoted 8 lines
is displayed each time the system is booted with the 2.6.24-rc3-git5 kernel but is NOT displayed when booting 2.6.24-rc3-git4
I have made no changes in my config file between these two kernels other than to accept any new defaults when running make oldconfig.
If you had already narrowed it down to a change between git4 and git5 I apologize for wasting your time. Have to run to work now.
Thanks, and re-added the proper CCs. Sigh...
Well, yes, the warning is actually new as well. Previously your kernel just silently ignored 8 more mem resources than it does now it seems.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Given that people are hitting these limits, it might make sense to just do away with the warning for 2.6.24 again while waiting for the dynamic code?
Ping. Should these warnings be reverted for 2.6.24?
Revert the warning doesn't make any sense. I'd suggest changing the IO resources number bigger till Thomas's patch in.
Agree.
Change it to 90 works for me, But I think maybe 128 is better.
include/linux/pnp.h| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)diff -upr
linux/include/linux/pnp.hlinux.new/include/linux/pnp.h
include/linux/pnp.h line 19
Quoted 8 lines
include/linux/pnp.h +1
-1@@ -13,7 +13,7 @@#include <linux/errno.h> #include <linux/mod_devicetable.h> -#define PNP_MAX_PORT 24 +#define PNP_MAX_PORT 128#define PNP_MAX_MEM 12#define PNP_MAX_IRQ 2#define PNP_MAX_DMA 2
I don't think we can increase PNP_MAX_PORT to 128. Only one or two devices need that many, so just bumping the max wastes a LOT of space. A struct resource is seven longs, so on a 32-bit system with sixteen PNP devices, we'd be wasting (128-24)*7*4*16 = almost 47Kbytes.
In hindsight, I should not have removed drivers/acpi/motherboard.c until we had dynamic PNP resource tables. We could revert that change [1], but the driver's been gone since 2.6.21, so I don't think it's that urgent. It's just that we used to silently ignore resources past the limits, and in -mm, we now print a KERN_ERR message.
So I think we should either remove the message altogether (so we're exactly like 2.6.23 in this regard), or at least tone it down to a KERN_WARN or something.
And we need to get Thomas' dynamic patch into -mm ASAP :-)
Bjorn
Quoted 17 lines · Bjorn Helgaas
include/linux/pnp.h line 19
Quoted 5 lines
include/linux/pnp.h +1
-1-#define PNP_MAX_PORT 24 +#define PNP_MAX_PORT 128#define PNP_MAX_MEM 12#define PNP_MAX_IRQ 2#define PNP_MAX_DMA 2I don't think we can increase
PNP_MAX_PORTto 128. Only one or two devices need that many, so just bumping the max wastes a LOT of space. A struct resource is seven longs, so on a 32-bit system with sixteen PNP devices, we'd be wasting (128-24)*7*4*16 = almost 47Kbytes.In hindsight, I should not have removed
drivers/acpi/motherboard.cuntil we had dynamic PNP resource tables. We could revert that change [1], but the driver's been gone since 2.6.21, so I don't think it's that urgent. It's just that we used to silently ignore resources past the limits, and in -mm, we now print aKERN_ERRmessage.
Quoted 5 lines
So I think we should either remove the message altogether (so we're exactly like 2.6.23 in this regard), or at least tone it down to a
KERN_WARNor something.And we need to get Thomas' dynamic patch into -mm ASAP :-)
*ping*! :)
My laptop still hits the PNP_MAX_MEM=12 warning in -rc5-mm1 - what's the status on Thomas's patch? No biggie - I just want to make sure it hasn't been dropped through the cracks someplace....
Len Brown
reviewerQuoted 9 lines
Quoted 7 lines
Well, yes, the warning is actually new as well. Previously your kernel just silently ignored 8 more mem resources than it does now it seems.
Given that people are hitting these limits, it might make sense to just do away with the warning for 2.6.24 again while waiting for the dynamic code?
Ping. Should these warnings be reverted for 2.6.24?
No. I don't think hiding this issue again is a good idea. I'd rather live with people complaining about an addition dmesg line.
-Len
Quoted 11 lines · Len Brown
Quoted 8 lines
Quoted 6 lines
Well, yes, the warning is actually new as well. Previously your kernel just silently ignored 8 more mem resources than it does now it seems.
Given that people are hitting these limits, it might make sense to just do away with the warning for 2.6.24 again while waiting for the dynamic code?
Ping. Should these warnings be reverted for 2.6.24?
No. I don't think hiding this issue again is a good idea. I'd rather live with people complaining about an addition dmesg line.
We're not talking about "a" additional line. In my case [1] we're talking about 22 (!) additional identical lines.
Not fixing this before 2.6.24 seems completely inconsistent:
- either this is a real bug and the ERR level message is correct, in which case the limits should be increased;
- or hitting the limits is harmless and the message should be changed to DEBUG level.
It is great to hear that the memory allocation will become dynamic in the future and maybe that could just justify your standpoint, but having the messages is damn ugly and alarming from a user point of view.
Please keep in mind that depending on distro release schedules, 2.6.24 could live for quite a bit longer than just the period needed to release 2.6.25 (if that is when the dynamic allocation will be implemented).
Cheers,
FJP
On 09-01-08 10:34, Frans Pop wrote:
Bjorn:
Quoted 8 lines
Quoted 6 lines · Len Brown
Quoted 6 lines
Quoted 6 lines
Well, yes, the warning is actually new as well. Previously your kernel just silently ignored 8 more mem resources than it does now it seems.
Given that people are hitting these limits, it might make sense to just do away with the warning for 2.6.24 again while waiting for the dynamic code?
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Ping. Should these warnings be reverted for 2.6.24?
No. I don't think hiding this issue again is a good idea. I'd rather live with people complaining about an addition dmesg line.
We're not talking about "a" additional line. In my case [1] we're talking about 22 (!) additional identical lines.
You lucky devil. Someone else reported 92 if I remember rightly. This really needs to be called a 2.6.24 bug. Stick the word "regression" in the subject line and someone will notice...
The warning might provide useful information to someone looking at a dmesg but given that people are hitting them way too hard with the only difference versus 2.6.23 being tke kernel now complaining about it, they're not useful enough to be printed more than once, or at more then DEBUG level or even at all in fact since we already know the static limit isn't enough for everyone and needs be turned dynamic -- really, what else is someone going to debug with it?
I'd consider Bjorn Helgaas the PnP maintainer and he earlier agreed that this needed something:
http://lkml.org/lkml/2007/12/5/301
Printing the warning only once per type as per attached fixes the problenm as well.
Bjorn, could you push your preference into 2.6.24?
Quoted 10 lines
Not fixing this before 2.6.24 seems completely inconsistent:
- either this is a real bug and the ERR level message is correct, in which case the limits should be increased;
- or hitting the limits is harmless and the message should be changed to DEBUG level.It is great to hear that the memory allocation will become dynamic in the future and maybe that could just justify your standpoint, but having the messages is damn ugly and alarming from a user point of view.
Quoted 8 lines
Please keep in mind that depending on distro release schedules, 2.6.24 could live for quite a bit longer than just the period needed to release 2.6.25 (if that is when the dynamic allocation will be implemented).
Cheers,
FJP
drivers/pnp/pnpacpi/rsparser.c +10 -5
@@ -73,6 +73,7 @@ static void pnpacpi_parse_allocated_irqresource(struct pnp_resource_table *res, u32 gsi, int triggering, int polarity, int shareable) { + static int warned;int i =0 ;int irq;int p, t;
@@ -84,8 +85,9 @@ static void pnpacpi_parse_allocated_irqresource(struct pnp_resource_table *res, i < PNP_MAX_IRQ) i++;if (i >=PNP_MAX_IRQ ) { -printk (KERN_ERR "pnpacpi: exceeded the max number of IRQ " -"resources: %d \n" ,PNP_MAX_IRQ ); +if (!warned++) +printk (KERN_ERR "pnpacpi: exceeded the max number of IRQ " +"resources: %d \n" ,PNP_MAX_IRQ );return ; }/*
@@ -168,6 +170,7 @@ static void pnpacpi_parse_allocated_dmaresource(struct pnp_resource_table *res, u32 dma, int type, int bus_master, int transfer) { + static int warned;int i =0 ; while (i < PNP_MAX_DMA &&
@@ -183,7 +186,7 @@ static void pnpacpi_parse_allocated_dmaresource(struct pnp_resource_table *res, } res->dma_resource[i].start = dma; res->dma_resource[i].end = dma; - }else { + }else if (!warned++) {printk (KERN_ERR "pnpacpi: exceeded the max number of DMA " "resources: %d \n" ,PNP_MAX_DMA ); }
@@ -192,6 +195,7 @@ static void pnpacpi_parse_allocated_dmaresource(struct pnp_resource_table *res,static void pnpacpi_parse_allocated_ioresource (struct pnp_resource_table *res,u64 io,u64 len,int io_decode) { +static int warned;int i =0 ; while (!(res->port_resource[i].flags & IORESOURCE_UNSET) &&
@@ -207,7 +211,7 @@ static void pnpacpi_parse_allocated_ioresource(struct pnp_resource_table *res, } res->port_resource[i].start = io; res->port_resource[i].end = io + len -1 ; - }else { + }else if (!warned++) {printk (KERN_ERR "pnpacpi: exceeded the max number of IO " "resources: %d \n" ,PNP_MAX_PORT ); }
@@ -217,6 +221,7 @@ static void pnpacpi_parse_allocated_memresource(struct pnp_resource_table *res, u64 mem, u64 len, int write_protect) { + static int warned;int i =0 ; while (!(res->mem_resource[i].flags & IORESOURCE_UNSET) &&
@@ -233,7 +238,7 @@ static void pnpacpi_parse_allocated_memresource(struct pnp_resource_table *res, res->mem_resource[i].start = mem; res->mem_resource[i].end = mem + len -1 ; - }else { + }else if (!warned++) {printk (KERN_ERR "pnpacpi: exceeded the max number of mem " "resources: %d\n" ,PNP_MAX_MEM ); }
Quoted 132 lines · Rene Herman
On 09-01-08 10:34, Frans Pop wrote:
Bjorn:
Quoted 8 lines
Quoted 6 lines · Len Brown
Quoted 6 lines
Quoted 6 lines
Well, yes, the warning is actually new as well. Previously your kernel just silently ignored 8 more mem resources than it does now it seems.
Given that people are hitting these limits, it might make sense to just do away with the warning for 2.6.24 again while waiting for the dynamic code?
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Ping. Should these warnings be reverted for 2.6.24?
No. I don't think hiding this issue again is a good idea. I'd rather live with people complaining about an addition dmesg line.
We're not talking about "a" additional line. In my case [1] we're talking about 22 (!) additional identical lines.
You lucky devil. Someone else reported 92 if I remember rightly. This really needs to be called a 2.6.24 bug. Stick the word "regression" in the subject line and someone will notice...
The warning might provide useful information to someone looking at a dmesg but given that people are hitting them way too hard with the only difference versus 2.6.23 being tke kernel now complaining about it, they're not useful enough to be printed more than once, or at more then DEBUG level or even at all in fact since we already know the static limit isn't enough for everyone and needs be turned dynamic -- really, what else is someone going to debug with it?
I'd consider Bjorn Helgaas the PnP maintainer and he earlier agreed that this needed something:
http://lkml.org/lkml/2007/12/5/301
Printing the warning only once per type as per attached fixes the problenm as well.
Bjorn, could you push your preference into 2.6.24?
Quoted 18 lines
Not fixing this before 2.6.24 seems completely inconsistent:
- either this is a real bug and the ERR level message is correct, in which case the limits should be increased;
- or hitting the limits is harmless and the message should be changed to DEBUG level.It is great to hear that the memory allocation will become dynamic in the future and maybe that could just justify your standpoint, but having the messages is damn ugly and alarming from a user point of view.
Please keep in mind that depending on distro release schedules, 2.6.24 could live for quite a bit longer than just the period needed to release 2.6.25 (if that is when the dynamic allocation will be implemented).
Cheers,
FJPdrivers/pnp/pnpacpi/rsparser.c +9
-4@@ -73,6 +73,7 @@ static void pnpacpi_parse_allocated_irqresource(struct pnp_resource_table *res, u32 gsi, int triggering, int polarity, int shareable) { + static int warned;int i =0 ;int irq;int p, t;@@ -84,8 +85,9 @@ static void pnpacpi_parse_allocated_irqresource(struct pnp_resource_table *res, i < PNP_MAX_IRQ) i++;if (i >=PNP_MAX_IRQ ) { -printk (KERN_ERR "pnpacpi: exceeded the max number of IRQ " -"resources: %d \n" ,PNP_MAX_IRQ ); +if (!warned++) +printk (KERN_ERR "pnpacpi: exceeded the max number of IRQ " +"resources: %d \n" ,PNP_MAX_IRQ );return ; }/* @@ -168,6 +170,7 @@ static void pnpacpi_parse_allocated_dmaresource(struct pnp_resource_table *res, u32 dma, int type, int bus_master, int transfer) { + static int warned;int i =0 ; while (i < PNP_MAX_DMA &&@@ -183,7 +186,7 @@ static void pnpacpi_parse_allocated_dmaresource(struct pnp_resource_table *res, } res->dma_resource[i].start = dma; res->dma_resource[i].end = dma; - }else { + }else if (!warned++) {printk (KERN_ERR "pnpacpi: exceeded the max number of DMA " "resources: %d \n" ,PNP_MAX_DMA ); }@@ -192,6 +195,7 @@ static void pnpacpi_parse_allocated_dmaresource(struct pnp_resource_table *res,static void pnpacpi_parse_allocated_ioresource (struct pnp_resource_table *res,u64 io,u64 len,int io_decode) { +static int warned;int i =0 ; while (!(res->port_resource[i].flags & IORESOURCE_UNSET) &&@@ -207,7 +211,7 @@ static void pnpacpi_parse_allocated_ioresource(struct pnp_resource_table *res, } res->port_resource[i].start = io; res->port_resource[i].end = io + len -1 ; - }else { + }else if (!warned++) {printk (KERN_ERR "pnpacpi: exceeded the max number of IO " "resources: %d \n" ,PNP_MAX_PORT ); }@@ -217,6 +221,7 @@ static void pnpacpi_parse_allocated_memresource(struct pnp_resource_table *res, u64 mem, u64 len, int write_protect) { + static int warned;int i =0 ; while (!(res->mem_resource[i].flags & IORESOURCE_UNSET) &&
drivers/pnp/pnpacpi/rsparser.c static void pnpacpi_parse_allocated_memresource(struct pnp_resource_table *res, · line 244
Quoted 8 lines
drivers/pnp/pnpacpi/rsparser.c +1
-1@@ -233,7 +238,7 @@ static void pnpacpi_parse_allocated_memresource(struct pnp_resource_table *res, res->mem_resource[i].start = mem; res->mem_resource[i].end = mem + len -1 ; - }else { + }else if (!warned++) {printk (KERN_ERR "pnpacpi: exceeded the max number of mem " "resources: %d\n" ,PNP_MAX_MEM ); }
I noticed the port number changed to 40 in 2.6.24-rc8, but it's not enough for me still.
Regards
dave
Quoted 2 lines · Dave Young
I noticed the port number changed to 40 in 2.6.24-rc8, but it's not enough for me still.
Yes, that's known. In .23 even more were (silently) ignored though. Since .24-rc8 you should at least get just 1 warning (per resource type) and if all's well .25 should kill the static limit completely.
Rene.
Quoted 6 lines · Rene Herman
Quoted 2 lines · Dave Young
I noticed the port number changed to 40 in 2.6.24-rc8, but it's not enough for me still.
Yes, that's known. In .23 even more were (silently) ignored though. Since .24-rc8 you should at least get just 1 warning (per resource type)
Assuming, that is, that Linus would've applied Len's trivial fix here:
http://lkml.org/lkml/2008/1/14/251
Quoted 1 line
and if all's well .25 should kill the static limit completely.
Rene.
Quoted 2 lines · Dave Young
I noticed the port number changed to 40 in 2.6.24-rc8, but it's not enough for me still.
Same here, though the extreme noise has gone.
Quoted 1 line
From
/proc/ioportsand dmesg it looks like I'm short by either 1, or 3 :-(
Cheers,
FJP
Quoted 6 lines · Frans Pop
Quoted 2 lines · Dave Young
I noticed the port number changed to 40 in 2.6.24-rc8, but it's not enough for me still.
Same here, though the extreme noise has gone.
From/proc/ioportsand dmesg it looks like I'm short by either 1, or 3 :-(
Yup. It should be no worse than in 2.6.23, where we silently ignored excess resources. We plan to fix it for real in 2.6.25.