Skip to contentSkip to conversation

Fix compiler warning noise with FORE200E driver

PATCH Applied Tom "spot" Callaway 2 participants 2 messages Dec 13, 2007 ATM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix compiler warning noise with FORE200E driver

gcc throws these warnings with:

CONFIG_ATM_FORE200E=m
# CONFIG_ATM_FORE200E_PCA is not set

drivers/atm/fore200e.c:2695: warning: 'fore200e_pca_detect' defined but not used
drivers/atm/fore200e.c:2748: warning: 'fore200e_pca_remove_one' defined but not used

By moving the #ifdef CONFIG_ATM_FORE200E_PCA around those two functions, the compiler warnings are silenced.

(btw, I'm not subscribed to lkml, so please CC me on any responses, although this is a wholly trivial patch, so I'm not expecting any.)

drivers/atm/fore200e.c renamed from drivers/atm/fore200e.c.BAD +1 -2
@@ -2689,7 +2689,7 @@
     return 0;
 }
 
-
+#ifdef CONFIG_ATM_FORE200E_PCA
 static int __devinit
 fore200e_pca_detect(struct pci_dev *pci_dev, const struct pci_device_id *pci_ent)
 {
@@ -2756,7 +2756,6 @@
 }
 
 
-#ifdef CONFIG_ATM_FORE200E_PCA
 static struct pci_device_id fore200e_pca_tbl[] = {
     { PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E, PCI_ANY_ID, PCI_ANY_ID,
       0, 0, (unsigned long) &fore200e_bus[0] },
Applied
#1 lore raw

From: "Tom \"spot\" Callaway" <[email protected]>
Date: Thu, 13 Dec 2007 11:21:40 -0500

Quoted 10 lines

gcc throws these warnings with:

CONFIG_ATM_FORE200E=m
# CONFIG_ATM_FORE200E_PCA is not set

drivers/atm/fore200e.c:2695: warning: 'fore200e_pca_detect' defined but not used
drivers/atm/fore200e.c:2748: warning: 'fore200e_pca_remove_one' defined but not used

Quoted 7 lines

By moving the #ifdef CONFIG_ATM_FORE200E_PCA around those two functions, the compiler warnings are silenced.

(btw, I'm not subscribed to lkml, so please CC me on any responses, although this is a wholly trivial patch, so I'm not expecting any.)

Applied, thanks Tom.