Skip to contentSkip to conversation

mxser, remove it

PATCH In review Jiri Slaby 3 participants 4 messages Dec 27, 2007

Subsystems (3)
lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

PATCH 1/1 mxser, remove it

(Old) mxser is obsoleted by mxser_new and scheduled for removal on Dec 2007. Remove it.

---
 Documentation/feature-removal-schedule.txt |    8 -
 drivers/char/Kconfig                       |   11 -
 drivers/char/Makefile                      |    1 -
 drivers/char/mxser.c                       | 3141 ----------------------------
 drivers/char/mxser.h                       |  441 ----
 5 files changed, 0 insertions(+), 3602 deletions(-)
 delete mode 100644 drivers/char/mxser.c
 delete mode 100644 drivers/char/mxser.h
Documentation/feature-removal-schedule.txt +0 -8
index 5092585..165c664 100644
@@ -6,14 +6,6 @@ be removed from this file.
 
 ---------------------------
 
-What:	MXSER
-When:	December 2007
-Why:	Old mxser driver is obsoleted by the mxser_new. Give it some time yet
-	and remove it.
-Who:	Jiri Slaby <[email protected]>
-
----------------------------
-
 What:	dev->power.power_state
 When:	July 2007
 Why:	Broken design for runtime control over driver power states, confusing
drivers/char/Kconfig +0 -11
index 967bfc2..4df801b 100644
@@ -193,17 +193,6 @@ config MOXA_INTELLIO
 	  To compile this driver as a module, choose M here: the
 	  module will be called moxa.
 
-config MOXA_SMARTIO
-	tristate "Moxa SmartIO support (OBSOLETE)"
-	depends on SERIAL_NONSTANDARD
-	help
-	  Say Y here if you have a Moxa SmartIO multiport serial card.
-
-	  This driver can also be built as a module ( = code which can be
-	  inserted in and removed from the running kernel whenever you want).
-	  The module will be called mxser. If you want to do that, say M
-	  here.
-
 config MOXA_SMARTIO_NEW
 	tristate "Moxa SmartIO support v. 2.0"
 	depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA)
drivers/char/Makefile +0 -1
index 2f02662..ed40670 100644
@@ -32,7 +32,6 @@ obj-$(CONFIG_SPECIALIX)		+= specialix.o
 obj-$(CONFIG_MOXA_INTELLIO)	+= moxa.o
 obj-$(CONFIG_A2232)		+= ser_a2232.o generic_serial.o
 obj-$(CONFIG_ATARI_DSP56K)	+= dsp56k.o
-obj-$(CONFIG_MOXA_SMARTIO)	+= mxser.o
 obj-$(CONFIG_MOXA_SMARTIO_NEW)	+= mxser_new.o
 obj-$(CONFIG_COMPUTONE)		+= ip2/
 obj-$(CONFIG_RISCOM8)		+= riscom8.o
drivers/char/mxser.c deleted +0 -3141

2,962 lines not on this page · raw message

drivers/char/mxser.h deleted +0 -441

441 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
1.5.3.6

Part of the diff is not shown here. View the raw message.

#1 lore raw
Quoted 4 lines · Jiri Slaby

(Old) mxser is obsoleted by mxser_new and scheduled for removal on Dec 2007. Remove it.

Quoted 9 lines
---
 Documentation/feature-removal-schedule.txt |    8 -
 drivers/char/Kconfig                       |   11 -
 drivers/char/Makefile                      |    1 -
 drivers/char/mxser.c                       | 3141 ----------------------------
 drivers/char/mxser.h                       |  441 ----
 5 files changed, 0 insertions(+), 3602 deletions(-)
 delete mode 100644 drivers/char/mxser.c
 delete mode 100644 drivers/char/mxser.h

While we're at it, how about adding a modalias for mxser_new module with old (being removed) name, so that users who're using the old module will not scream? I mean, in order for `modprobe mxser' to load mxser_new module.

/mjt

#2 lore raw
Quoted 15 lines · Michael Tokarev
Quoted 4 lines · Jiri Slaby

(Old) mxser is obsoleted by mxser_new and scheduled for removal on Dec 2007. Remove it.

Quoted 9 lines
---
 Documentation/feature-removal-schedule.txt |    8 -
 drivers/char/Kconfig                       |   11 -
 drivers/char/Makefile                      |    1 -
 drivers/char/mxser.c                       | 3141 ----------------------------
 drivers/char/mxser.h                       |  441 ----
 5 files changed, 0 insertions(+), 3602 deletions(-)
 delete mode 100644 drivers/char/mxser.c
 delete mode 100644 drivers/char/mxser.h
Quoted 4 lines

While we're at it, how about adding a modalias for mxser_new module with old (being removed) name, so that users who're using the old module will not scream? I mean, in order for `modprobe mxser' to load mxser_new module.

It might even make sense to rename the mxser_new module to mxser and do it the other way round - it's e.g. not clear whether a _new driver is for new hardware or a new driver for old hardware.

Quoted 1 line

/mjt

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#3 lore raw
Quoted 15 lines · Adrian Bunk
Quoted 14 lines · Michael Tokarev
Quoted 13 lines · Jiri Slaby

(Old) mxser is obsoleted by mxser_new and scheduled for removal on Dec 2007. Remove it.

---
 Documentation/feature-removal-schedule.txt |    8 -
 drivers/char/Kconfig                       |   11 -
 drivers/char/Makefile                      |    1 -
 drivers/char/mxser.c                       | 3141 ----------------------------
 drivers/char/mxser.h                       |  441 ----
 5 files changed, 0 insertions(+), 3602 deletions(-)
 delete mode 100644 drivers/char/mxser.c
 delete mode 100644 drivers/char/mxser.h
Quoted 8 lines
Quoted 4 lines

While we're at it, how about adding a modalias for mxser_new module with old (being removed) name, so that users who're using the old module will not scream? I mean, in order for `modprobe mxser' to load mxser_new module.

It might even make sense to rename the mxser_new module to mxser and do it the other way round - it's e.g. not clear whether a _new driver is for new hardware or a new driver for old hardware.

Makes sense, if no other suggestions, I will post v2 tomorrow.

thanks,
--js