Skip to contentSkip to conversation

SUNRPC Crash Fix

PATCH Tom Tucker 1 participant 1 message Dec 30, 2007

Subsystems (3)
lore
Share & tools
lore

Tom Tucker

author
#0 lore raw

Bruce/Aime:

Here is what I believe to be the fix for the crashes/svc_xprt BUG_ON that people are seeing. It would be great if those who have seen this problem could apply this patch and see if it resolves their problem.

The common code calls svc_xprt_received on behalf of the transport. Since the provider was calling it as well, this resulted in clearing the busy bit/resetting xpt_pool when the BUSY bit wasn't held.

net/sunrpc/svcsock.c +0 -1
index 4628881..4d39db1 100644
@@ -1272,7 +1272,6 @@ static struct svc_xprt *svc_create_socket(struct svc_serv *serv,
 
 	if ((svsk = svc_setup_socket(serv, sock, &error, flags)) != NULL) {
 		svc_xprt_set_local(&svsk->sk_xprt, newsin, newlen);
-		svc_xprt_received(&svsk->sk_xprt);
 		return (struct svc_xprt *)svsk;
 	}