Skip to contentSkip to conversation

common: Suppress the warning 'p_buf'

PATCH New Dave Liu 3 participants 4 messages Jan 10, 2008 – Jan 12, 2008

lore
Share & tools
lore

Dave Liu

author
#0 lore raw

PATCH 1/8 common: Suppress the warning 'p_buf'

clear the warning: unused variable 'p_buf'

Signed-off-by Dave Liu <[email protected]>
---
 common/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
common/main.c +1 -1
index ad2a386..4687c83 100644
@@ -924,7 +924,6 @@ int readline (const char *const prompt)
 int readline_into_buffer (const char *const prompt, char * buffer)
 {
 	char *p = buffer;
-	char * p_buf = p;
 #ifdef CONFIG_CMDLINE_EDITING
 	unsigned int len=MAX_CMDBUF_SIZE;
 	int rc;

@@ -940,6 +939,7 @@ int readline_into_buffer (const char *const prompt, char * buffer)
 	rc = cread_line(prompt, p, &len);
 	return rc < 0 ? rc : len;
 #else
+	char *p_buf = p;
 	int	n = 0;				/* buffer index		*/
 	int	plen = 0;			/* prompt length	*/
 	int	col;				/* output column cnt	*/
Signature · 1 line
1.5.3.5.643.g40e25
#1 lore raw

PATCH 1/8 common: Suppress the warning 'p_buf'

Quoted 6 lines · On Thu, 10 Jan 2008 23:01:53 +0800 Dave Liu <[email protected]> wrote:

clear the warning: unused variable 'p_buf'

Signed-off-by Dave Liu <[email protected]>
---
 common/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applied 2 through 8 out of 8, since Kumar beat you to this p_buf patch (and is in common/ anyway, so it's for WD to apply directly).

Kim

#2 lore raw

PATCH 1/8 common: Suppress the warning 'p_buf'

So, Wolfgang, please apply the patch to your tree directly.

Thanks,
Dave

Quoted 22 lines

-----Original Message-----
From: Phillips Kim
Sent: 2008?1?11? 12:02 PM
To: Liu Dave
Cc: Wolfgang Denk; u-boot-external
Subject: Re: [PATCH 1/8] common: Suppress the warning 'p_buf'

Quoted 6 lines · On Thu, 10 Jan 2008 23:01:53 +0800 Dave Liu <[email protected]> wrote:

clear the warning: unused variable 'p_buf'

Signed-off-by Dave Liu <[email protected]>
---
 common/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applied 2 through 8 out of 8, since Kumar beat you to this p_buf patch (and is in common/ anyway, so it's for WD to apply directly).

Kim

#3 lore raw

PATCH 1/8 common: Suppress the warning 'p_buf'

In reply to Kim Phillips
Quoted 9 lines
Quoted 6 lines

clear the warning: unused variable 'p_buf'

Signed-off-by Dave Liu <[email protected]>
---
 common/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applied 2 through 8 out of 8, since Kumar beat you to this p_buf patch (and is in common/ anyway, so it's for WD to apply directly).

Sorry for that, I didn't notice Kumar's patch for it.

Dave