Skip to contentSkip to conversation

Version and Functional FRU fields for motherboard and membuf

DISCUSSION Alexander A. Filippov 4 participants 7 messages Apr 19, 2018 – Sep 21, 2018

lore
Share & tools
lore
#0 lore raw

Hello everyone,

We get a failure running the "Validate FRU Properties Fields" test because in our system we do not have "Version" and "Functional" properties in the following nodes:

/xyz/openbmc_project/inventory/system/chassis/motherboard /xyz/openbmc_project/inventory/system/chassis/motherboard/membuf*

However, we've examined the corresponding yaml files available in the master branch for palmetto and witherspoon, and have not been able to locate any mentions of those properties either.

Assuming that the aforementioned test passes for those systems, our question is: where do those properties come from for them?

--
Alexander

#1 lore raw
Quoted 8 lines · Lei KM Yu

Hi Alexander,

Quoted 3 lines · Alexander A. Filippov

Hello everyone,

We get a failure running the "Validate FRU Properties Fields" test

May I ask what "Validate FRU Properties Fields" test is?

It's actually "Verify FRU Properties" and it's a part of openbmc-test-automation test suite, see here:

https://github.com/openbmc/openbmc-test-automation/blob/ac687c43ddc7f639a4607ad89dd5ae462dcf65c9/tests/test_inventory.robot#L184

Quoted 6 lines
Quoted 6 lines

because in our system we do not have "Version" and "Functional" properties in the following nodes:

    /xyz/openbmc_project/inventory/system/chassis/motherboard /xyz/openbmc_project/inventory/system/chassis/motherboard/membuf*

As I see, in the current version of the test you don't anymore look for "Functional" property for those nodes, but "Version" is still checked.

Quoted 11 lines
Quoted 6 lines

However, we've examined the corresponding yaml files available in the master branch for palmetto and witherspoon, and have not been able to locate any mentions of those properties either.

Assuming that the aforementioned test passes for those systems, our question is: where do those properties come from for them?


As I see, Palmetto's yaml config does not have Version or Functional property for motherboard and membuf, so I do not think they will have such properties.

So, does the test case pass for Palmetto?

#2 lore raw
Quoted 7 lines

It's actually "Verify FRU Properties" and it's a part of openbmc-test-automation test suite, see here:

https://github.com/openbmc/openbmc-test-automation/blob/ac687c43ddc7f639a4607ad89dd5ae462dcf65c9/tests/test_inventory.robot#L184

As I see, Palmetto's yaml config does not have Version or Functional property for motherboard and membuf, so I do not think they will have such properties.

So, does the test case pass for Palmetto?

@Sivas Srr Could you check this?

#3 lore raw
Quoted 9 lines
Quoted 7 lines

It's actually "Verify FRU Properties" and it's a part of openbmc-test-automation test suite, see here:

https://github.com/openbmc/openbmc-test-automation/blob/ac687c43ddc7f639a4607ad89dd5ae462dcf65c9/tests/test_inventory.robot#L184

As I see, Palmetto's yaml config does not have Version or Functional property for motherboard and membuf, so I do not think they will have such properties.

So, does the test case pass for Palmetto?

@Sivas Srr Could you check this?

Sivas, Lei? Any chance to get an answer to this? The test still fails for us and we can't decide whether we should disable the test or add thos properties to motherboard and membuf objects.

By the way, what is at all the meaning and purpose of the 'Functional' property? Is it an indicator of a component functioning properly, or is it a 'handle' to turn a component off before hot removal/replacement? There is no description anywhere that we could find.

Thank you.
Alexander.

#4 lore raw
Quoted 6 lines · Alexander Amelkin

Sivas, Lei? Any chance to get an answer to this? The test still fails for us and we can't decide whether we should disable the test or add thos properties to motherboard and membuf objects.

By the way, what is at all the meaning and purpose of the 'Functional' property? Is it an indicator of a component functioning properly, or is it a 'handle' to turn a component off before hot removal/replacement? There is no description anywhere that we could find.

The Functional property means if a FRU is functional or not, e.g. if a DIMM is plugged but has problem, it will be garded. At that time, the DIMM is Present, but not Functional.

For this case, I think the test code shall be updated to skip the checks for Functional, Version on specific FRU items.

Ping @Sivas again for comment.

#5 lore raw
Quoted 1 line

By the way, what is at all the meaning and purpose of the 'Functional'

property? Is it an indicator of a component functioning properly, or is it a 'handle' to turn a component off before hot removal/replacement?

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Correct, the Field 'Functional' indicates the component is

functioning. so Functional is a 'status' and not a 'control'.

Quoted 3 lines

There is no description anywhere that we could find.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

You can look at the YAML state/ namespace for it

https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/State/Decorator/OperationalStatus.interface.yaml

The Functional property means if a FRU is functional or not, e.g. if a DIMM
is plugged but has problem, it will be garded. At that time, the DIMM is Present, but not Functional.

For this case, I think the test code shall be updated to skip the checks for
Functional, Version on specific FRU items.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

I looked at the code, so it expect if its present , its needs to be

functional at least, but yes for the use case where it leads to Present, but not Functional, there is no skipping logic for a given particular FRU's.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Thinking out loud myself on this, test to add smarter logic checks to

detect the garded FRU if there is standard method before its run and skip it.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

If you open could up a ticket on

https://github.com/openbmc/openbmc-test-automation/issues and describe more so that the test community can look at this and address the changes it may need.

Thanks and Regards,
George Keishing

From:   Lei YU <[email protected]>
To:     Alexander Amelkin <[email protected]>
Cc OpenBMC Maillist <[email protected]>
Date:   09/21/2018 12:17 PM
Subject:        Re: Version and Functional FRU fields for motherboard and 

membuf
Sent by: "openbmc"
<[email protected]>

Quoted 3 lines · Alexander Amelkin

Sivas, Lei? Any chance to get an answer to this? The test still fails

for us and we can't decide whether we should disable the test or add thos properties to motherboard and membuf objects.

Quoted 2 lines

By the way, what is at all the meaning and purpose of the 'Functional'

property? Is it an indicator of a component functioning properly, or is it a 'handle' to turn a component off before hot removal/replacement?

Quoted 1 line

There is no description anywhere that we could find.

The Functional property means if a FRU is functional or not, e.g. if a DIMM
is plugged but has problem, it will be garded. At that time, the DIMM is Present, but not Functional.

For this case, I think the test code shall be updated to skip the checks for
Functional, Version on specific FRU items.

Ping @Sivas again for comment.

#6 lore raw
Quoted 6 lines · George Keishing
Quoted 6 lines

By the way, what is at all the meaning and purpose of the 'Functional' property? Is it an indicator of a component functioning properly, or is it a 'handle' to turn a component off before hot removal/replacement?

Quoted 1 line
Quoted 1 line
Quoted 1 line

Correct, the Field 'Functional' indicates the component is functioning.  so Functional is a 'status' and not a 'control'.

There is no description anywhere that we could find.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

You can look at the YAML state/ namespace for it
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/State/Decorator/OperationalStatus.interface.yaml

Yes, I've seen that. That's exactly what I call "no description". "Implement to indicate the operational status of the object" is not a decent description IMO as it's too sepulkarian (https://en.wikipedia.org/wiki/Sepulka).

Alex.