Skip to contentSkip to conversation

hrtimer.c devinit vs. cpuinit

DISCUSSION Johannes Berg 2 participants 2 messages Jan 15, 2008

lore
Share & tools
lore
#0 lore raw

Hi,

Looking through hrtimer.c I noticed

static void __devinit init_hrtimers_cpu(int cpu)

static int __cpuinit hrtimer_cpu_notify(struct notifier_block *self,
unsigned long action, void *hcpu)

Couldn't the first be __cpuinit as well?

johannes

#1 lore raw
Quoted 11 lines · Johannes Berg

Hi,

Looking through hrtimer.c I noticed

static void __devinit init_hrtimers_cpu(int cpu)

static int __cpuinit hrtimer_cpu_notify(struct notifier_block *self,
unsigned long action, void *hcpu)

Couldn't the first be __cpuinit as well?

As the only user of init_hrtimers_cpu is __cpuinit then it is a bug that init_hrtimers_cpu is __devinit today.

So you are correct and it must be fixed.

Sam