Skip to contentSkip to conversation

dlm: close othercons

PATCH In review David Teigland 1 participant 1 message Jan 24, 2008 Distributed lock manager (DLM)

lore
Share & tools
lore

David Teigland

author maintainer
#0 lore raw

PATCH 5/19 dlm: close othercons

From: Patrick Caulfeld <[email protected]>

This patch addresses a problem introduced with the last round of lowcomms patches where the 'othercon' connections do not get freed when the DLM shuts down.

This results in the error message
"slab error in kmem_cache_destroy(): cache `dlm_conn': Can't free all objects"

and the DLM cannot be restarted without a system reboot.

See bz#428119

---
 fs/dlm/lowcomms.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
fs/dlm/lowcomms.c +2 -0
index 5772844..7c1e5e5 100644
@@ -1437,6 +1437,8 @@ void dlm_lowcomms_stop(void)
 		con = __nodeid2con(i, 0);
 		if (con) {
 			close_connection(con, true);
+			if (con->othercon)
+				kmem_cache_free(con_cache, con->othercon);
 			kmem_cache_free(con_cache, con);
 		}
 	}
Signature · 1 line
1.5.3.3