Skip to contentSkip to conversation

: Dont use kobjsize on the area belonging to a VMA

PATCH In review Bryan Wu 3 participants 4 messages Jan 30, 2008

Subsystems (2)
lore
Share & tools
lore

Bryan Wu

author
#0 lore raw

PATCH 1/1 : Dont use kobjsize on the area belonging to a VMA

From: Bernd Schmidt <[email protected]>

Dont use kobjsize on the area belonging to a VMA, as it's allocated with get_free_pages.

---
 fs/proc/task_nommu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/proc/task_nommu.c +2 -2
index 1932c2c..1d0513e 100644
@@ -76,7 +76,7 @@ unsigned long task_vsize(struct mm_struct *mm)
 	down_read(&mm->mmap_sem);
 	for (tbp = mm->context.vmlist; tbp; tbp = tbp->next) {
 		if (tbp->vma)
-			vsize += kobjsize((void *) tbp->vma->vm_start);
+			vsize += tbp->vma->vm_end - tbp->vma->vm_start;
 	}
 	up_read(&mm->mmap_sem);
 	return vsize;
@@ -93,7 +93,7 @@ int task_statm(struct mm_struct *mm, int *shared, int *text,
 		size += kobjsize(tbp);
 		if (tbp->vma) {
 			size += kobjsize(tbp->vma);
-			size += kobjsize((void *) tbp->vma->vm_start);
+			size += tbp->vma->vm_end - tbp->vma->vm_start;
 		}
 	}
 
Signature · 1 line
1.5.3.4
#1 lore raw
Quoted 4 lines · Bryan Wu

From: Bernd Schmidt <[email protected]>

Dont use kobjsize on the area belonging to a VMA, as it's allocated with get_free_pages.

As far as I remember, that's the case only in our tree with the patches in nommu.c. So this patch probably shouldn't go upstream yet.

Bernd

Signature · 4 lines
This footer brought to you by insane German lawmakers.
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 40368
Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif
#2 lore raw
Quoted 9 lines · Bernd Schmidt
Quoted 4 lines · Bryan Wu

From: Bernd Schmidt <[email protected]>

Dont use kobjsize on the area belonging to a VMA, as it's allocated with get_free_pages.

As far as I remember, that's the case only in our tree with the patches in nommu.c. So this patch probably shouldn't go upstream yet.

Oh, I picked up a wrong one. Could you please tell me which nommu.c pathes does this one depends on?
I am sorting out all our nommu changes and try to send them out.

Thanks
-Bryan

#3 lore raw
Quoted 6 lines · Bryan Wu
Quoted 5 lines · Bernd Schmidt
Quoted 4 lines · Bryan Wu

From: Bernd Schmidt <[email protected]>

Dont use kobjsize on the area belonging to a VMA, as it's allocated with get_free_pages.

Quoted 7 lines
Quoted 3 lines

As far as I remember, that's the case only in our tree with the patches in nommu.c. So this patch probably shouldn't go upstream yet.

Oh, I picked up a wrong one. Could you please tell me which nommu.c pathes does this one depends on?
I am sorting out all our nommu changes and try to send them out.

Leave them out for now. I think David half-nacked them last time I posted them, so we'll need to work something out.

Bernd

Signature · 4 lines
This footer brought to you by insane German lawmakers.
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 40368
Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif