Skip to contentSkip to conversation

ppc4xx: Fix problem with init-ram bigger than 4k on 440 platforms

PATCH New Stefan Roese 2 participants 3 messages Feb 1, 2008 – Feb 14, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: Fix problem with init-ram bigger than 4k on 440 platforms

---
 cpu/ppc4xx/start.S         |    4 ++++
 include/configs/pcs440ep.h |    2 +-
 include/configs/yosemite.h |    2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)
cpu/ppc4xx/start.S +4 -0
index 77c2aa4..0638024 100644
@@ -110,6 +110,10 @@
 # endif
 #endif /* CFG_INIT_DCACHE_CS */
 
+#if (defined(CFG_INIT_RAM_DCACHE) && (CFG_INIT_RAM_END > (4 << 10)))
+#error Only 4k of init-ram is supported - please adjust CFG_INIT_RAM_END!
+#endif
+
 #define function_prolog(func_name)	.text; \
 					.align 2; \
 					.globl func_name; \
include/configs/pcs440ep.h +1 -1
index d66f4bd..07fc23e 100644
@@ -66,7 +66,7 @@
  *----------------------------------------------------------------------*/
 #define CFG_INIT_RAM_DCACHE	1		/* d-cache as init ram	*/
 #define CFG_INIT_RAM_ADDR	0x70000000		/* DCache       */
-#define CFG_INIT_RAM_END	(8 << 10)
+#define CFG_INIT_RAM_END	(4 << 10)
 #define CFG_GBL_DATA_SIZE	256			/* num bytes initial data*/
 #define CFG_GBL_DATA_OFFSET	(CFG_INIT_RAM_END - CFG_GBL_DATA_SIZE)
 #define CFG_INIT_SP_OFFSET	CFG_GBL_DATA_OFFSET
include/configs/yosemite.h +1 -1
index a8eeff9..4c86bc5 100644
@@ -75,7 +75,7 @@
  *----------------------------------------------------------------------*/
 #define CFG_INIT_RAM_DCACHE	1		/* d-cache as init ram	*/
 #define CFG_INIT_RAM_ADDR	0x70000000		/* DCache       */
-#define CFG_INIT_RAM_END	(8 << 10)
+#define CFG_INIT_RAM_END	(4 << 10)
 #define CFG_GBL_DATA_SIZE	256			/* num bytes initial data*/
 #define CFG_GBL_DATA_OFFSET	(CFG_INIT_RAM_END - CFG_GBL_DATA_SIZE)
 #define CFG_INIT_SP_OFFSET	CFG_GBL_DATA_OFFSET
Signature · 1 line
1.5.4.rc5
#1 lore raw

PATCH 1/1 ppc4xx: Fix problem with init-ram bigger than 4k on 440 platforms

Dear Stefan,

Quoted 6 lines · in message <[email protected]> you wrote:
---
 cpu/ppc4xx/start.S         |    4 ++++
 include/configs/pcs440ep.h |    2 +-
 include/configs/yosemite.h |    2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)

Do you intend to send a pull request any time soon?

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"In the face of entropy and nothingness, you kind of have to  pretend
it's  not  there  if  you  want  to  keep writing good code."
- Karl Lehenbauer
#2 lore raw

PATCH 1/1 ppc4xx: Fix problem with init-ram bigger than 4k on 440 platforms

Hi Wolfgang,

Quoted 9 lines · Wolfgang Denk
Quoted 6 lines · in message <[email protected]> you wrote:
---
 cpu/ppc4xx/start.S         |    4 ++++
 include/configs/pcs440ep.h |    2 +-
 include/configs/yosemite.h |    2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)

Do you intend to send a pull request any time soon?

Yes. I have to apply a few other bug fix patches and will send the pull request then. I'll try to do it today.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================