latencytop: optimize LT_BACKTRACEDEPTH loops a bit
Subject: latencytop: optimize LT_BACKTRACEDEPTH loops a bit.
It looks like there is no need to loop any longer when 'same == 0'.
Signed-off-by Dmitry Adamushko <[email protected]>
kernel/latencytop.c +13 -12
@@ -64,8 +64,8 @@ account_global_scheduler_latency(struct task_struct *tsk, struct latency_recordreturn ;for (i =0 ; i <MAXLR ; i++) { -int q; -int same =1 ; +int q, same =1 ; +/* Nothing stored: */ if (!latency_record[i].backtrace[0 ]) {if (firstnonnull > i)
@@ -73,12 +73,12 @@ account_global_scheduler_latency(struct task_struct *tsk, struct latency_recordcontinue ; }for (q =0 ; q <LT_BACKTRACEDEPTH ; q++) { -if (latency_record[i].backtrace[q] != - lat->backtrace[q]) +unsigned long record = lat->backtrace[q]; + +if (latency_record[i].backtrace[q] != record) same =0 ; -if (same && lat->backtrace[q] ==0 ) -break ; -if (same && lat->backtrace[q] ==ULONG_MAX ) + +if (!same || record ==0 || record ==ULONG_MAX )break ; }if (same) {
@@ -143,14 +143,15 @@ account_scheduler_latency(struct task_struct *tsk, int usecs, int inter)for (i =0 ; i <LT_SAVECOUNT ; i++) {struct latency_record *mylat;int same =1 ; + mylat = &tsk->latency_record[i];for (q =0 ; q <LT_BACKTRACEDEPTH ; q++) { -if (mylat->backtrace[q] != - lat.backtrace[q]) +unsigned long record = lat.backtrace[q]; + +if (mylat->backtrace[q] != record) same =0 ; -if (same && lat.backtrace[q] ==0 ) -break ; -if (same && lat.backtrace[q] ==ULONG_MAX ) + +if (!same || record ==0 || record ==ULONG_MAX )break ; }if (same) {
Quoted 3 lines · Dmitry Adamushko
Subject: latencytop: optimize
LT_BACKTRACEDEPTHloops a bit.It looks like there is no need to loop any longer when 'same == 0'.
thanks for the contribution!
while I like your patch, I wonder if we should go even a little further in cleaning this up
Quoted 7 lines
kernel/latencytop.c +1
-2@@ -73,12 +73,12 @@ account_global_scheduler_latency(struct task_struct *tsk, struct latency_recordcontinue ; }for (q =0 ; q <LT_BACKTRACEDEPTH ; q++) { -if (latency_record[i].backtrace[q] != - lat->backtrace[q]) +unsigned long record = lat->backtrace[q];
kernel/latencytop.c account_global_scheduler_latency(struct task_struct *tsk, struct latency_record · line 83
Quoted 10 lines
kernel/latencytop.c +4
-3+ +if (latency_record[i].backtrace[q] != record) same =0 ; -if (same && lat->backtrace[q] ==0 ) -break ; -if (same && lat->backtrace[q] ==ULONG_MAX ) + +if (!same || record ==0 || record ==ULONG_MAX )break ; }
I mean, we could make it look like this:
if (latency_record[i].backtrace[q] != record) {
same = 0;
break;
}
/* 0 and ULONG_MAX entries denote the end of backtrace */
if (record == 0)
break;
if (record == ULONG_MAX)
break;to me at least this is a bit more readable/simple than the good first step you've already taken..
Do you want to do it this way? I'd sure encourage/endorse such a patch...