Skip to contentSkip to conversation

x86: dubious one-bit signed bitfield in cpuidle.h

PATCH New Harvey Harrison 1 participant 1 message Feb 5, 2008 CPU idle time management framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: dubious one-bit signed bitfield in cpuidle.h

This is a minimal, stupid, fix, move to unsigned bitfield. These errors are hiding sparse warnings in any file that includes it....below is a sample.

CHECK arch/x86/kernel/acpi/cstate.c
include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield
CHECK arch/x86/kernel/acpi/processor.c
include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield
CHECK arch/x86/kernel/cpu/cpufreq/powernow-k7.c
include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield
CHECK arch/x86/kernel/cpu/cpufreq/powernow-k8.c
include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield
CHECK arch/x86/kernel/cpu/cpufreq/longhaul.c
include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield
CHECK arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield

---
 include/linux/cpuidle.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/cpuidle.h +1 -1
index c4e0016..b0fd85a 100644
@@ -79,7 +79,7 @@ struct cpuidle_state_kobj {
 };
 
 struct cpuidle_device {
-	int			enabled:1;
+	unsigned int		enabled:1;
 	unsigned int		cpu;
 
 	int			last_residency;
Signature · 1 line
1.5.4.rc5.1138.g2602