Skip to contentSkip to conversation

ACPI patches for 2.6.25-rc0 (more)

PATCH In review Len Brown 3 participants 12 messages Feb 8, 2008

Subsystems (4)
Documentation ACPI Char and misc drivers Thermal
lore
Share & tools
lore
author reviewer
#3 lore raw

PATCH 3/8 ACPI: build WMI on X86 only

In reply to Len Brown

From: Len Brown <[email protected]>

Signed-off-by Len Brown <[email protected]>
---
 drivers/acpi/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/acpi/Kconfig +1 -0
index 7ef172c..65da19b 100644
@@ -204,6 +204,7 @@ config ACPI_NUMA
 
 config ACPI_WMI
 	tristate "WMI (EXPERIMENTAL)"
+	depends on X86
 	depends on EXPERIMENTAL
 	help
 	  This driver adds support for the ACPI-WMI mapper device (PNP0C14)
Signature · 1 line
1.5.4.34.g053d9
author reviewer
#5 lore raw

PATCH 4/8 intel_menlo: build on X86 only

In reply to Len Brown

From: Len Brown <[email protected]>

Signed-off-by Len Brown <[email protected]>
---
 drivers/misc/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/misc/Kconfig +1 -0
index 78cd338..218c65a 100644
@@ -279,6 +279,7 @@ config ATMEL_SSC
 config INTEL_MENLOW
 	tristate "Thermal Management driver for Intel menlow platform"
 	depends on ACPI_THERMAL
+	depends on X86
 	---help---
 	  ACPI thermal management enhancement driver on
 	  Intel Menlow platform.
Signature · 1 line
1.5.4.34.g053d9
author reviewer
#7 lore raw

PATCH 6/8 ACPI: DMI: add Panasonic CF-52 and Thinpad X61

In reply to Len Brown

From: Len Brown <[email protected]>

Add Lenovo X61
Add Panasonic Toughbook CF-52

Signed-off-by Len Brown <[email protected]>
---
 drivers/acpi/blacklist.c |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
drivers/acpi/blacklist.c +20 -0
index 6dbaa2d..9ce983e 100644
@@ -445,6 +445,8 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 	 * DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T61"),
 	 * _OSI(Linux) is a NOP:
 	 * DMI_MATCH(DMI_PRODUCT_VERSION, "3000 N100"),
+	 * _OSI(Linux) effect unknown
+	 * DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X61"),
 	 */
 	{
 	.callback = dmi_enable_osi_linux,

@@ -464,6 +466,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 	},
 	{
 	.callback = dmi_unknown_osi_linux,
+	.ident = "Lenovo ThinkPad X61",
+	.matches = {
+		     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		     DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X61"),
+		},
+	},
+	{
+	.callback = dmi_unknown_osi_linux,
 	.ident = "Lenovo 3000 V100",
 	.matches = {
 		     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),

@@ -505,6 +515,16 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "NEC VERSA M360"),
 		},
 	},
+	/* Panasonic */
+	{
+	.callback = dmi_unknown_osi_linux,
+	.ident = "Panasonic",
+	.matches = {
+		     DMI_MATCH(DMI_SYS_VENDOR, "Matsushita"),
+			/* Toughbook CF-52 */
+		     DMI_MATCH(DMI_PRODUCT_NAME, "CF-52CCABVBG"),
+		},
+	},
 	/*
 	 * Disable OSI(Linux) warnings on all "Samsung Electronics"
 	 *
Signature · 1 line
1.5.4.34.g053d9
author reviewer
#2 lore raw

PATCH 2/8 ACPI: cpufreq: Print _PPC changes via cpufreq debug layer

In reply to Len Brown

From: Thomas Renninger <[email protected]>

enabled with CPU_FREQ_DEBUG

Signed-off-by Thomas Renninger <[email protected]>
Signed-off-by Len Brown <[email protected]>
---
 drivers/acpi/processor_perflib.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
drivers/acpi/processor_perflib.c +7 -0
index f32010b..b477a4b 100644
@@ -50,6 +50,10 @@ ACPI_MODULE_NAME("processor_perflib");
 
 static DEFINE_MUTEX(performance_mutex);
 
+/* Use cpufreq debug layer for _PPC changes. */
+#define cpufreq_printk(msg...) cpufreq_debug_printk(CPUFREQ_DEBUG_CORE, \
+						"cpufreq-core", msg)
+
 /*
  * _PPC support is implemented as a CPUfreq policy notifier:
  * This means each time a CPUfreq driver registered also with

@@ -131,6 +135,9 @@ static int acpi_processor_get_platform_limit(struct acpi_processor *pr)
 		return -ENODEV;
 	}
 
+	cpufreq_printk("CPU %d: _PPC is %d - frequency %s limited\n", pr->id,
+		       (int)ppc, ppc ? "" : "not");
+
 	pr->performance_platform_limit = (int)ppc;
 
 	return 0;
Signature · 1 line
1.5.4.34.g053d9
author reviewer
#8 lore raw

PATCH 7/8 ACPI: WMI: Improve Kconfig description

In reply to Len Brown

From: Carlos Corbacho <[email protected]>

As Pavel Machek has pointed out, the Kconfig entry for WMI is pretty non-descriptive.

Rewrite it so that it explains what ACPI-WMI is, and why anyone would want to enable it.

Many thanks to Ray Lee for ideas on this.

Signed-off-by Carlos Corbacho <[email protected]>
CC Pavel Machek <[email protected]>
CC Ray Lee <[email protected]>
Signed-off-by Len Brown <[email protected]>
---
 drivers/acpi/Kconfig |   19 +++++++++++++++----
 1 files changed, 15 insertions(+), 4 deletions(-)
drivers/acpi/Kconfig +15 -4
index 65da19b..f688c21 100644
@@ -207,11 +207,22 @@ config ACPI_WMI
 	depends on X86
 	depends on EXPERIMENTAL
 	help
-	  This driver adds support for the ACPI-WMI mapper device (PNP0C14)
-	  found on some systems.
+	  This driver adds support for the ACPI-WMI (Windows Management
+	  Instrumentation) mapper device (PNP0C14) found on some systems.
 
-	  NOTE: You will need another driver or userspace application on top of
-	  this to actually use anything defined in the ACPI-WMI mapper.
+	  ACPI-WMI is a proprietary extension to ACPI to expose parts of the
+	  ACPI firmware to userspace - this is done through various vendor
+	  defined methods and data blocks in a PNP0C14 device, which are then
+	  made available for userspace to call.
+
+	  The implementation of this in Linux currently only exposes this to
+	  other kernel space drivers.
+
+	  This driver is a required dependency to build the firmware specific
+	  drivers needed on many machines, including Acer and HP laptops.
+
+	  It is safe to enable this driver even if your DSDT doesn't define
+	  any ACPI-WMI devices.
 
 config ACPI_ASUS
         tristate "ASUS/Medion Laptop Extras"
Signature · 1 line
1.5.4.34.g053d9
author reviewer
#10 lore raw

PATCH 8/8 acer-wmi, tc1100-wmi: select ACPI_WMI

In reply to Len Brown

From: Len Brown <[email protected]>

It is safe for these Kconfig entries to use select because they select ACPI_WMI, which already has its dependencies satisfied. This makes Kconfig more user friendly, since the user selects the driver they want and the dependency is met for them. Otherwise, the user would have to find and enable ACPI_WMI to make enabling these drivers possible.

Signed-off-by Len Brown <[email protected]>
---
 drivers/misc/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/misc/Kconfig +2 -2
index 218c65a..e19343e 100644
@@ -97,9 +97,9 @@ config ACER_WMI
 	depends on X86
 	depends on EXPERIMENTAL
 	depends on ACPI
-	depends on ACPI_WMI
 	depends on LEDS_CLASS
 	depends on BACKLIGHT_CLASS_DEVICE
+	select ACPI_WMI
 	---help---
 	  This is a driver for newer Acer (and Wistron) laptops. It adds
 	  wireless radio and bluetooth control, and on some laptops,

@@ -146,7 +146,7 @@ config TC1100_WMI
 	tristate "HP Compaq TC1100 Tablet WMI Extras"
 	depends on X86 && !X86_64
 	depends on ACPI
-	depends on ACPI_WMI
+	select ACPI_WMI
 	---help---
 	  This is a driver for the WMI extensions (wireless and bluetooth power
 	  control) of the HP Compaq TC1100 tablet.
Signature · 1 line
1.5.4.34.g053d9

Len Brown

author reviewer
#0 lore raw

a couple more for 2.6.25-rc0...

author reviewer
#1 lore raw

PATCH 1/8 ACPI: add newline to printk

From: Len Brown <[email protected]>

Signed-off-by Len Brown <[email protected]>
---
 drivers/acpi/osl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/osl.c +1 -1
index 27ccd68..a14501c 100644
@@ -343,7 +343,7 @@ struct acpi_table_header *acpi_find_dsdt_initrd(void)
 	struct kstat stat;
 	char *ramfs_dsdt_name = "/DSDT.aml";
 
-	printk(KERN_INFO PREFIX "Checking initramfs for custom DSDT");
+	printk(KERN_INFO PREFIX "Checking initramfs for custom DSDT\n");
 
 	/*
 	 * Never do this at home, only the user-space is allowed to open a file.
Signature · 1 line
1.5.4.34.g053d9
author reviewer
#6 lore raw

PATCH 5/8 ACPI: thermal: syntax, spelling, kernel-doc

In reply to Len Brown

From: Len Brown <[email protected]>

Reviewed-by Randy Dunlap <[email protected]>
Signed-off-by Len Brown <[email protected]>
---
 Documentation/thermal/sysfs-api.txt |   23 ++++++++--------
 drivers/thermal/Kconfig             |    4 +-
 drivers/thermal/thermal.c           |   49 ++++++++++++++++++++---------------
 3 files changed, 41 insertions(+), 35 deletions(-)
Documentation/thermal/sysfs-api.txt +11 -12
index 5776e09..ba9c2da 100644
@@ -14,7 +14,7 @@ The generic thermal sysfs provides a set of interfaces for thermal zone devices
 and thermal cooling devices (fan, processor...) to register with the thermal management
 solution and to be a part of it.
 
-This how-to focusses on enabling new thermal zone and cooling devices to participate
+This how-to focuses on enabling new thermal zone and cooling devices to participate
 in thermal management.
 This solution is platform independent and any type of thermal zone devices and
 cooling devices should be able to make use of the infrastructure.

@@ -41,9 +41,9 @@ and throttle appropriate devices.
 	name: the thermal zone name.
 	trips: the total number of trip points this thermal zone supports.
 	devdata: device private data
-	ops: thermal zone device callbacks.
+	ops: thermal zone device call-backs.
 		.bind: bind the thermal zone device with a thermal cooling device.
-		.unbind: unbing the thermal zone device with a thermal cooling device.
+		.unbind: unbind the thermal zone device with a thermal cooling device.
 		.get_temp: get the current temperature of the thermal zone.
 		.get_mode: get the current mode (user/kernel) of the thermal zone.
 			   "kernel" means thermal management is done in kernel.

@@ -69,7 +69,7 @@ and throttle appropriate devices.
 	It tries to bind itself to all the thermal zone devices register at the same time.
 	name: the cooling device name.
 	devdata: device private data.
-	ops: thermal cooling devices callbacks.
+	ops: thermal cooling devices call-backs.
 		.get_max_state: get the Maximum throttle state of the cooling device.
 		.get_cur_state: get the Current throttle state of the cooling device.
 		.set_cur_state: set the Current throttle state of the cooling device.

@@ -109,7 +109,6 @@ RO	read only value
 RW	read/write value
 
 All thermal sysfs attributes will be represented under /sys/class/thermal
-/sys/class/thermal/
 
 Thermal zone device sys I/F, created once it's registered:
 |thermal_zone[0-*]:

@@ -129,7 +128,7 @@ Thermal cooling device sys I/F, created once it's registered:
 These two dynamic attributes are created/removed in pairs.
 They represent the relationship between a thermal zone and its associated cooling device.
 They are created/removed for each
-thermal_zone_bind_cooling_device/thermal_zone_unbind_cooling_device successful exection.
+thermal_zone_bind_cooling_device/thermal_zone_unbind_cooling_device successful execution.
 
 |thermal_zone[0-*]
 	|-----cdev[0-*]:		The [0-*]th cooling device in the current thermal zone

@@ -147,11 +146,11 @@ type				Strings which represent the thermal zone type.
 				Optional
 
 temp				Current temperature as reported by thermal zone (sensor)
-				Unit: degree celsius
+				Unit: degree Celsius
 				RO
 				Required
 
-mode				One of the predifned values in [kernel, user]
+mode				One of the predefined values in [kernel, user]
 				This file gives information about the algorithm
 				that is currently managing the thermal zone.
 				It can be either default kernel based algorithm

@@ -164,12 +163,12 @@ mode				One of the predifned values in [kernel, user]
 					  charge of the thermal management.
 
 trip_point_[0-*]_temp		The temperature above which trip point will be fired
-				Unit: degree celsius
+				Unit: degree Celsius
 				RO
 				Optional
 
 trip_point_[0-*]_type 		Strings which indicate the type of the trip point
-				Eg. it can be one of critical, hot, passive,
+				E.g. it can be one of critical, hot, passive,
 				    active[0-*] for ACPI thermal zone.
 				RO
 				Optional

@@ -179,7 +178,7 @@ cdev[0-*]			Sysfs link to the thermal cooling device node where the sys I/F
 				RO
 				Optional
 
-cdev[0-*]_trip_point		The trip point with which cdev[0-*] is assocated in this thermal zone
+cdev[0-*]_trip_point		The trip point with which cdev[0-*] is associated in this thermal zone
 				-1 means the cooling device is not associated with any trip point.
 				RO
 				Optional

@@ -211,7 +210,7 @@ cur_state			The current cooling state of this cooling device.
 
 ACPI thermal zone may support multiple trip points like critical/hot/passive/active.
 If an ACPI thermal zone supports critical, passive, active[0] and active[1] at the same time,
-it may register itself as a thermale_zone_device (thermal_zone1) with 4 trip points in all.
+it may register itself as a thermal_zone_device (thermal_zone1) with 4 trip points in all.
 It has one processor and one fan, which are both registered as thermal_cooling_device.
 If the processor is listed in _PSL method, and the fan is listed in _AL0 method,
 the sys I/F structure will be built like this:
drivers/thermal/Kconfig +2 -2
index 9b3f612..69f19f2 100644
@@ -9,7 +9,7 @@ menuconfig THERMAL
 	  Generic Thermal Sysfs driver offers a generic mechanism for
 	  thermal management. Usually it's made up of one or more thermal
 	  zone and cooling device.
-	  each thermal zone contains its own temperature, trip points,
+	  Each thermal zone contains its own temperature, trip points,
 	  cooling devices.
 	  All platforms with ACPI thermal support can use this driver.
-	  If you want this support, you should say Y here
+	  If you want this support, you should say Y here.
drivers/thermal/thermal.c +28 -21

171 lines not on this page · raw message

Signature · 1 line
1.5.4.34.g053d9
Acked-by on v1 8/8
#11 lore raw

Re: [PATCH 8/8] acer-wmi, tc1100-wmi: select ACPI_WMI

In reply to Len Brown
Quoted 10 lines · On Friday 08 February 2008 06:29:24 Len Brown wrote:

From: Len Brown <[email protected]>

It is safe for these Kconfig entries to use select because they select ACPI_WMI, which already has its dependencies satisfied. This makes Kconfig more user friendly, since the user selects the driver they want and the dependency is met for them. Otherwise, the user would have to find and enable ACPI_WMI to make enabling these drivers possible.

Signed-off-by Len Brown <[email protected]>
Acked-by Carlos Corbacho <[email protected]>

-Carlos

Signature · 3 lines
E-Mail: [email protected]
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
#9 lore raw

Re: [PATCH 7/8] ACPI: WMI: Improve Kconfig description

In reply to Len Brown
Quoted 5 lines · Len Brown

From: Carlos Corbacho <[email protected]>

As Pavel Machek has pointed out, the Kconfig entry for WMI is pretty non-descriptive.

Quoted 7 lines

Rewrite it so that it explains what ACPI-WMI is, and why anyone would want to enable it.

Many thanks to Ray Lee for ideas on this.

Signed-off-by Carlos Corbacho <[email protected]>
CC Pavel Machek <[email protected]>

ACK... and thanks.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html