SCSI bug fixes for 2.6.25-rc1
James Bottomley
maintainerPATCH 1/1 SCSI bug fixes for 2.6.25-rc1
This one's not too bad given the number of patches we had in the merge window. We have the advansys fix, a gdth severe problem fix (wouldn't scan any devices) a bug fix series for lpfc and a few other odds and ends.
The patch is available here:
master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git
The short changelog is:
Boaz Harrosh (3):
gdth: scan for scsi devices
aic94xx: fix ABORT_TASK define conflict
fas216: Use scsi_eh API for REQUEST_SENSE invocation
FUJITA Tomonori (1):
advansys: fix overrun_buf aligned bug
James Bottomley (2):
sym53c416: fix module parameters
update SG_ALL to avoid causing chaining
James Smart (6):
lpfc 8.2.5 : Update lpfc driver version to 8.2.5 lpfc 8.2.5 : Fix buffer leaks
lpfc 8.2.5 : Miscellaneous discovery Fixes lpfc 8.2.5 : Add MSI-X single message support lpfc 8.2.5 : Miscellaneous Fixes
lpfc 8.2.5 : Correct ndlp referencing issues
Prakash, Sathya (2):
mpt fusion: Request I/O resources only when required
mpt fusion: Avoid racing when mptsas and mptcl module are loaded in parall
Salyzyn, Mark (3):
aacraid: informational sysfs value corrections
aacraid: ignore adapter reset check polarity
aacraid: add optional MSI support
Sergio Luis (1):
gdth: update deprecated pci_find_device
Thomas Horsten (1):
MegaRAID driver management char device moved to misc
Yinghai Lu (1):
ses: fix memory leaks
And the diffstat:
drivers/message/fusion/mptbase.c | 54 ++++- drivers/message/fusion/mptbase.h | 1 drivers/scsi/Kconfig | 2 drivers/scsi/aacraid/aachba.c | 70 ++++-- drivers/scsi/aacraid/aacraid.h | 2 drivers/scsi/aacraid/commsup.c | 2 drivers/scsi/aacraid/linit.c | 47 ++-- drivers/scsi/aacraid/rx.c | 5 drivers/scsi/aacraid/sa.c | 5 drivers/scsi/advansys.c | 13 + drivers/scsi/aic94xx/aic94xx_sas.h | 2 drivers/scsi/aic94xx/aic94xx_tmf.c | 2 drivers/scsi/arm/fas216.c | 16 - drivers/scsi/arm/fas216.h | 3 drivers/scsi/gdth.c | 16 + drivers/scsi/lpfc/lpfc.h | 19 + drivers/scsi/lpfc/lpfc_attr.c | 19 + drivers/scsi/lpfc/lpfc_crtn.h | 6 drivers/scsi/lpfc/lpfc_ct.c | 41 ++- drivers/scsi/lpfc/lpfc_disc.h | 66 ++++-- drivers/scsi/lpfc/lpfc_els.c | 384 +++++++++++++++++++++++++----------- drivers/scsi/lpfc/lpfc_hbadisc.c | 328 +++++++++++++++++++++++++----- drivers/scsi/lpfc/lpfc_hw.h | 18 + drivers/scsi/lpfc/lpfc_init.c | 154 ++++++++++++-- drivers/scsi/lpfc/lpfc_logmsg.h | 10 drivers/scsi/lpfc/lpfc_mem.c | 13 + drivers/scsi/lpfc/lpfc_nportdisc.c | 55 +++-- drivers/scsi/lpfc/lpfc_scsi.c | 4 drivers/scsi/lpfc/lpfc_sli.c | 105 +++++++++ drivers/scsi/lpfc/lpfc_version.h | 2 drivers/scsi/lpfc/lpfc_vport.c | 70 ++++++ drivers/scsi/megaraid/megaraid_mm.c | 20 + drivers/scsi/megaraid/megaraid_mm.h | 1 drivers/scsi/ses.c | 23 +- drivers/scsi/sym53c416.c | 16 - include/scsi/scsi_host.h | 8 36 files changed, 1232 insertions(+), 370 deletions(-)
James
Quoted 8 lines · On Wed, 13 Feb 2008 18:02:44 -0600 James Bottomley…
This one's not too bad given the number of patches we had in the merge window. We have the advansys fix, a gdth severe problem fix (wouldn't scan any devices) a bug fix series for lpfc and a few other odds and ends.
The patch is available here:
master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git
I have scsi patches!
mptbase-reset-ioc-initiator-during-pci-resume.patch
Fixes suspend/resume on all of Darrick's MPT cards. I first merged it in September 2007.
kill-warnings-in-mptbaseh-on-parisc64.patch
Warning fixes.
dell-cerc-support-for-megaraid_mbox.patch
Turns non-booting machiens into booting ones. Merged in -mm in November 2007.
3w-raid-drivers-memset-not-needed-in-probe.patch
Small optimisation
scsi-aic94xx-cleanups.patch
cleanups only.
scsi-qlogicptic-section-fixes.patch
Fixes a reference from .text into .init.text and hence might fix a machine crash when this driver is build into vmlinux. Merged a week ago.
megaraid-outb_p-extermination.patch
Cleanup
gdth-convert-to-pci-hotplug-api.patch
Just merged
So several of these patches address quite seriosu bugs, and have been stuck in my tree for far too long.
James Bottomley
maintainerQuoted 12 lines · Andrew Morton
Quoted 8 lines · On Wed, 13 Feb 2008 18:02:44 -0600 James Bottomley…
This one's not too bad given the number of patches we had in the merge window. We have the advansys fix, a gdth severe problem fix (wouldn't scan any devices) a bug fix series for lpfc and a few other odds and ends.
The patch is available here:
master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git
Quoted 8 lines
I have scsi patches!
mptbase-reset-ioc-initiator-during-pci-resume.patch
Fixes suspend/resume on all of Darrick's MPT cards. I first merged it in September 2007.
Patch presented by LSI but has gone back with comments
Quoted 3 lines
kill-warnings-in-mptbaseh-on-parisc64.patch
Warning fixes.
Not sure ... LSI is supposed to be processing this.
Quoted 1 line
dell-cerc-support-for-megaraid_mbox.patch
I need megaraid to sign off (and test) this one.
Quoted 7 lines
Turns non-booting machiens into booting ones. Merged in -mm in November 2007.
3w-raid-drivers-memset-not-needed-in-probe.patch
Small optimisation
Quoted 8 lines
scsi-aic94xx-cleanups.patch
cleanups only.
scsi-qlogicptic-section-fixes.patch
Fixes a reference from .text into .init.text and hence might fix a machine crash when this driver is build into vmlinux. Merged a week ago.
This was the one we had the alternative fix for, wasn't it ... ?
Quoted 7 lines
megaraid-outb_p-extermination.patch
Cleanup
gdth-convert-to-pci-hotplug-api.patch
Just merged
That's not a bug fix necessarily ... We do have an outstanding gdth bug fix that did have a patch in your tree, though ... But we're arguing over doing it properly.
Quoted 3 lines
So several of these patches address quite seriosu bugs, and have been stuck in my tree for far too long.
James
From: James Bottomley <[email protected]>
Date: Wed, 13 Feb 2008 19:11:53 -0600
Quoted 7 lines · Andrew Morton
Quoted 3 lines
kill-warnings-in-mptbaseh-on-parisc64.patch
Warning fixes.
Not sure ... LSI is supposed to be processing this.
James, please don't push build warning fixes and the like back to the driver maintainers.
This is your domain as SCSI maintainer, and you should integrate these kinds of things directly and as promptly as possible.
This is doubly true if the "driver maintainer" can't be bothered to ACK or fixup the patch for months.
Otherwise this kind of stuff rots, and diligent people like Andrew (and the patch submitter, whoever that might be) get extremely frustrated.
James Bottomley
maintainerQuoted 17 lines · David Miller
From: James Bottomley <[email protected]>
Date: Wed, 13 Feb 2008 19:11:53 -0600Quoted 7 lines · Andrew Morton
Quoted 3 lines
kill-warnings-in-mptbaseh-on-parisc64.patch
Warning fixes.
Not sure ... LSI is supposed to be processing this.
James, please don't push build warning fixes and the like back to the driver maintainers.
This is your domain as SCSI maintainer, and you should integrate these kinds of things directly and as promptly as possible.
Quoted 6 lines
This is doubly true if the "driver maintainer" can't be bothered to ACK or fixup the patch for months.
Otherwise this kind of stuff rots, and diligent people like Andrew (and the patch submitter, whoever that might be) get extremely frustrated.
LSI did ask to merge through their patch process, but I agree this one's been hanging around for a bit long.
James
Quoted 6 lines · On Wed, 13 Feb 2008 19:11:53 -0600 James Bottomley…
Quoted 4 lines
mptbase-reset-ioc-initiator-during-pci-resume.patch
Fixes suspend/resume on all of Darrick's MPT cards. I first merged it in September 2007.
Patch presented by LSI but has gone back with comments
Five months is too long to fix a bug when someone has already sent us a patch. If they insist on being this sluggish I'd suggest that you review the patch yourself then just merge it. That will get their attention. Maybe.
Quoted 3 lines
Quoted 1 line
dell-cerc-support-for-megaraid_mbox.patch
I need megaraid to sign off (and test) this one.
Two months, same story.
Quoted 6 lines
Quoted 4 lines
scsi-qlogicptic-section-fixes.patch
Fixes a reference from .text into .init.text and hence might fix a machine crash when this driver is build into vmlinux. Merged a week ago.
This was the one we had the alternative fix for, wasn't it ... ?
In current mainline, __devinit qpti_sbus_probe() still is calling __init qpti_chain_add() (for example). So in a CONFIG_HOTPLUG kernel, hotplugging a new device (on sbus, ok, bad example ;)) will crash.
But Adrian has fixed six such bugs in there, maybe one of them can hit. I don't think we've fixed these by alternative means, unless we've disabled __devinit?
Still, we can discuss specific patches all day. I think there is a _general_ problem getting bugfixes, warning fixes and cleanups into scsi drivers within reasonable amounts of time?