Skip to contentSkip to conversation

debugfs: fix sparse warnings

PATCH Applied Harvey Harrison 2 participants 2 messages Feb 14, 2008 – Feb 19, 2008 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 debugfs: fix sparse warnings

extern does not belong in C files, move declaration to linux/debugfs.h fs/debugfs/file.c:42:30: warning: symbol 'debugfs_file_operations' was not declared. Should it be static? fs/debugfs/file.c:54:31: warning: symbol 'debugfs_link_operations' was not declared. Should it be static?

---
 fs/debugfs/inode.c      |    4 ----
 include/linux/debugfs.h |    5 +++++
 2 files changed, 5 insertions(+), 4 deletions(-)
fs/debugfs/inode.c +0 -4
index d26e282..e9602d8 100644
@@ -29,10 +29,6 @@
 
 #define DEBUGFS_MAGIC	0x64626720
 
-/* declared over in file.c */
-extern struct file_operations debugfs_file_operations;
-extern struct inode_operations debugfs_link_operations;
-
 static struct vfsmount *debugfs_mount;
 static int debugfs_mount_count;
 
include/linux/debugfs.h +5 -0
index f592d6d..7266124 100644
@@ -27,6 +27,11 @@ struct debugfs_blob_wrapper {
 };
 
 #if defined(CONFIG_DEBUG_FS)
+
+/* declared over in file.c */
+extern const struct file_operations debugfs_file_operations;
+extern const struct inode_operations debugfs_link_operations;
+
 struct dentry *debugfs_create_file(const char *name, mode_t mode,
 				   struct dentry *parent, void *data,
 				   const struct file_operations *fops);
Signature · 1 line
1.5.4.1.1278.gc75be
#1 lore raw

patch debugfs-fix-sparse-warnings.patch added to gregkh-2.6 tree

This is a note to let you know that I've just added the patch titled

Subject: debugfs: fix sparse warnings

to my gregkh-2.6 tree. Its filename is

debugfs-fix-sparse-warnings.patch

This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/

Quoted 1 line

From [email protected] Wed Feb 13 17:08:21 2008

From: Harvey Harrison <[email protected]>
Date: Wed, 13 Feb 2008 17:08:16 -0800
Subject: debugfs: fix sparse warnings
To: Greg KH <[email protected]>, Andrew Morton <[email protected]>
Cc: LKML <[email protected]>
Message-ID: <1202951296.18204.39.camel@brick>

extern does not belong in C files, move declaration to linux/debugfs.h fs/debugfs/file.c:42:30: warning: symbol 'debugfs_file_operations' was not declared. Should it be static? fs/debugfs/file.c:54:31: warning: symbol 'debugfs_link_operations' was not declared. Should it be static?

---
 fs/debugfs/inode.c      |    4 ----
 include/linux/debugfs.h |    5 +++++
 2 files changed, 5 insertions(+), 4 deletions(-)
fs/debugfs/inode.c +0 -4
@@ -29,10 +29,6 @@
 
 #define DEBUGFS_MAGIC	0x64626720
 
-/* declared over in file.c */
-extern struct file_operations debugfs_file_operations;
-extern struct inode_operations debugfs_link_operations;
-
 static struct vfsmount *debugfs_mount;
 static int debugfs_mount_count;
 
include/linux/debugfs.h +5 -0
@@ -27,6 +27,11 @@ struct debugfs_blob_wrapper {
 };
 
 #if defined(CONFIG_DEBUG_FS)
+
+/* declared over in file.c */
+extern const struct file_operations debugfs_file_operations;
+extern const struct inode_operations debugfs_link_operations;
+
 struct dentry *debugfs_create_file(const char *name, mode_t mode,
 				   struct dentry *parent, void *data,
 				   const struct file_operations *fops);

Patches currently in gregkh-2.6 which might be from [email protected] are

driver/debugfs-fix-sparse-warnings.patch