fuse: shadowed variable warning
fs/fuse/dir.c:909:7: warning: symbol 'err' shadows an earlier one fs/fuse/dir.c:893:6: originally declared here
This means that an error between lines 909 and 923 will not be returned.
---
Miklos, could you confirm whether or not you want the err from lines 909-923 returned or not. If so, I can respin this patch changing the variable name instead which would preserve the current behavior. This patch changes behavior.
fs/fuse/dir.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fs/fuse/dir.c +1 -1
@@ -906,7 +906,7 @@ static int fuse_permission(struct inode *inode, int mask, struct nameidata *nd) }if (fc->flags &FUSE_DEFAULT_PERMISSIONS ) { -int err =generic_permission (inode, mask,NULL ); + err =generic_permission (inode, mask,NULL );/* If permission is denied, try to refresh file attributes. This is also needed, because the root
Signature · 1 line
1.5.4.1.1278.gc75be
Miklos Szeredi
maintainerQuoted 6 lines
fs/fuse/dir.c:909:7: warning: symbol 'err' shadows an earlier onefs/fuse/dir.c:893:6: originally declared hereThis means that an error between lines 909 and 923 will not be returned.
Right. Just submitted the exact same patch this morning :)
Thanks,
Miklos
Quoted 30 lines
Signed-off-by Harvey Harrison <[email protected]>---
Miklos, could you confirm whether or not you want the err from lines 909-923 returned or not. If so, I can respin this patch changing the variable name instead which would preserve the current behavior. This patch changes behavior.fs/fuse/dir.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)fs/fuse/dir.c +1
-1@@ -906,7 +906,7 @@ static int fuse_permission(struct inode *inode, int mask, struct nameidata *nd) }if (fc->flags &FUSE_DEFAULT_PERMISSIONS ) { -int err =generic_permission (inode, mask,NULL ); + err =generic_permission (inode, mask,NULL );/* If permission is denied, try to refresh file attributes. This is also needed, because the root Signature · 1 line
1.5.4.1.1278.gc75be
Quoted 4 lines · Miklos Szeredi
Quoted 4 lines
fs/fuse/dir.c:909:7: warning: symbol 'err' shadows an earlier onefs/fuse/dir.c:893:6: originally declared here
Quoted 8 lines
Quoted 2 lines
This means that an error between lines 909 and 923 will not be returned.
Right. Just submitted the exact same patch this morning :)
Thanks,
Miklos
Well, as long as someone did :)
Havey