Skip to contentSkip to conversation

nfsd: fix sparse warning in vfs.c

PATCH Applied Harvey Harrison 2 participants 2 messages Feb 20, 2008 NFS server

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 nfsd: fix sparse warning in vfs.c

fs/nfsd/vfs.c:991:27: warning: Using plain integer as NULL pointer

---
 fs/nfsd/vfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/nfsd/vfs.c +1 -1
index 0265310..17ac51b 100644
@@ -988,7 +988,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
 	 * flushing the data to disk is handled separately below.
 	 */
 
-	if (file->f_op->fsync == 0) {/* COMMIT3 cannot work */
+	if (!file->f_op->fsync) {/* COMMIT3 cannot work */
 	       stable = 2;
 	       *stablep = 2; /* FILE_SYNC */
 	}
Signature · 1 line
1.5.4.2.200.g99e75
#1 lore raw
Quoted 6 lines · Harvey Harrison

fs/nfsd/vfs.c:991:27: warning: Using plain integer as NULL pointer

---
 fs/nfsd/vfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Also applied, thanks.--b.

Quoted 17 lines
fs/nfsd/vfs.c +1 -1
index 0265310..17ac51b 100644
@@ -988,7 +988,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
 	 * flushing the data to disk is handled separately below.
 	 */
 
-	if (file->f_op->fsync == 0) {/* COMMIT3 cannot work */
+	if (!file->f_op->fsync) {/* COMMIT3 cannot work */
 	       stable = 2;
 	       *stablep = 2; /* FILE_SYNC */
 	}
Signature · 1 line
1.5.4.2.200.g99e75