Skip to contentSkip to conversation

acpi: new sparse warnings in 2.6.25-rc2

DISCUSSION Harvey Harrison 2 participants 2 messages Feb 21, 2008 ACPI

lore
Share & tools
lore
#0 lore raw

Introduced between 2.6.25-rc1 and -rc2.

drivers/acpi/executer/exregion.c:369:8: warning: incorrect type in argument 3 (different type sizes)
drivers/acpi/executer/exregion.c:369:8: expected unsigned int [usertype] *value
drivers/acpi/executer/exregion.c:369:8: got unsigned long long [usertype] *value
drivers/acpi/executer/exregion.c: In function ‘acpi_ex_pci_config_space_handler’:
drivers/acpi/executer/exregion.c:369: warning: passing argument 3 of ‘acpi_os_read_pci_configuration’ from incompatible pointer type

Cheers,

Harvey

reviewer
#1 lore raw
Quoted 8 lines · Harvey Harrison

Introduced between 2.6.25-rc1 and -rc2.

drivers/acpi/executer/exregion.c:369:8: warning: incorrect type in argument 3 (different type sizes)
drivers/acpi/executer/exregion.c:369:8: expected unsigned int [usertype] *value
drivers/acpi/executer/exregion.c:369:8: got unsigned long long [usertype] *value
drivers/acpi/executer/exregion.c: In function ‘acpi_ex_pci_config_space_handler’:
drivers/acpi/executer/exregion.c:369: warning: passing argument 3 of ‘acpi_os_read_pci_configuration’ from incompatible pointer type

Subject: ACPI: fix build warning
From: Ming Lin <[email protected]>

CC drivers/acpi/executer/exregion.o
drivers/acpi/executer/exregion.c: In function ‘acpi_ex_pci_config_space_handler’:
drivers/acpi/executer/exregion.c:369: attention : passing argument 3 of ‘acpi_os_read_pci_configuration’ from incompatible pointer type

exposed by 10270d4838bdc493781f5a1cf2e90e9c34c9142f

http://bugzilla.kernel.org/show_bug.cgi?id=9989

---

drivers/acpi/executer/exregion.c +3 -2
index 2e9ce94..3f51b7e 100644
@@ -338,6 +338,7 @@ acpi_ex_pci_config_space_handler(u32 function,
 	acpi_status status = AE_OK;
 	struct acpi_pci_id *pci_id;
 	u16 pci_register;
+	u32 value32;
 
 	ACPI_FUNCTION_TRACE(ex_pci_config_space_handler);
 
@@ -364,9 +365,9 @@ acpi_ex_pci_config_space_handler(u32 function,
 	switch (function) {
 	case ACPI_READ:
 
-		*value = 0;
 		status = acpi_os_read_pci_configuration(pci_id, pci_register,
-							value, bit_width);
+							&value32, bit_width);
+		*value = value32;
 		break;
 
 	case ACPI_WRITE: