libsas: correctly flush the LU queue on error recovery

PATCH James Bottomley 1 participant 1 message Feb 22, 2008

Subsystems (2)

SCSI SCSI libsas

lore

Share & tools

lore

James Bottomley

author maintainer

2008-02-22 23:07 UTC #0 lore raw

The current sas_scsi_clear_queue_lu() is wrongly checking for commands which match the pointer to the one passed in. It should be checking for commands which are on the same logical unit as the one passed in. Fix this by checking target pointer and LUN for equality.

Signed-off-by James Bottomley <[email protected]>

---

drivers/scsi/libsas/sas_scsi_host.c +2 -1

index b796d99..57ba99f 100644
@@ -282,7 +282,8 @@ static void sas_scsi_clear_queue_lu(struct list_head *error_q, struct scsi_cmnd
 	struct scsi_cmnd *cmd, *n;
 
 	list_for_each_entry_safe(cmd, n, error_q, eh_entry) {
-		if (cmd == my_cmd)
+		if (cmd->device->sdev_target == my_cmd->device->sdev_target &&
+		    cmd->device->lun == my_cmd->device->lun)
 			sas_eh_finish_cmd(cmd);
 	}
 }