Skip to contentSkip to conversation

mm/slab.c - use angle brackets for include

PATCH In review Joe Perches 2 participants 3 messages Mar 5, 2008 4 messages not in the archive

Subsystems (2)
Memory management netfilter
lore
Share & tools
lore

Joe Perches

author
#0 lore raw

PATCH 1/1 mm/slab.c - use angle brackets for include

mm/slab.c | 2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
mm/slab.c +1 -1
index 473e6c2..a37f897 100644
@@ -333,7 +333,7 @@ static __always_inline int index_of(const size_t size)
 		return i; \
 	else \
 		i++;
-#include "linux/kmalloc_sizes.h"
+#include <linux/kmalloc_sizes.h>
 #undef CACHE
 		__bad_size();
 	} else

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

author
#5 lore raw
In reply to a message not in the archive
Quoted 3 lines · Christoph Lameter
Quoted 1 line · Joe Perches

net/netfilter/nf_conntrack_extend.c:26:#include <linux/kmalloc_sizes.h>

Urgh look at that:

:) at least it's noted as "horrible".

Quoted 2 lines

Guess we need to define a constant KMALLC_MIN_SIZE in include/sl?b_def.h to get rid of this hack?

Seems a likely idea, but maybe netfilter shouldn't bother with a minimum?

#6 lore raw
Quoted 2 lines · Joe Perches

Seems a likely idea, but maybe netfilter shouldn't bother with a minimum?

Agreed and sent a patch to do just that.