Skip to contentSkip to conversation

add vendor and product pair for SQN1130

PATCH In review Andy Shevchenko 3 participants 3 messages Mar 7, 2008 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add vendor and product pair for SQN1130

Add the vendor and product ids for Sequans SQN1130 WiMAX chipset.

---
 include/linux/mmc/sdio_ids.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
include/linux/mmc/sdio_ids.h +3 -0
index ea1bf5b..d1b9883 100644
@@ -26,4 +26,7 @@
 #define SDIO_VENDOR_ID_MARVELL			0x02df
 #define SDIO_DEVICE_ID_MARVELL_LIBERTAS		0x9103
 
+#define SDIO_VENDOR_ID_SEQUANS			0x039d
+#define SDIO_DEVICE_ID_SEQUANS_SQN1130		0x046a
+
 #endif
Signature · 1 line
1.5.2.5
#1 lore raw
Quoted 10 lines · On Fri, 7 Mar 2008 10:08:30 +0200 Andy Shevchenko <[email protected]> wrote:

Add the vendor and product ids for Sequans SQN1130 WiMAX chipset.

---
 include/linux/mmc/sdio_ids.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
include/linux/mmc/sdio_ids.h +0 -0
index ea1bf5b..d1b9883 100644

include/linux/mmc/sdio_ids.h line 31

Quoted 6 lines
include/linux/mmc/sdio_ids.h +3 -0
@@ -26,4 +26,7 @@
 #define SDIO_VENDOR_ID_MARVELL			0x02df
 #define SDIO_DEVICE_ID_MARVELL_LIBERTAS		0x9103
 
+#define SDIO_VENDOR_ID_SEQUANS			0x039d
+#define SDIO_DEVICE_ID_SEQUANS_SQN1130		0x046a
+

There's no point in adding these unless there's actually some code there which _uses_ them?

#2 lore raw
Quoted 15 lines · On Fri, 7 Mar 2008 02:45:26 -0800 Andrew Morton <[email protected]>…
Quoted 13 lines · On Fri, 7 Mar 2008 10:08:30 +0200 Andy Shevchenko <[email protected]> wrote:

Add the vendor and product ids for Sequans SQN1130 WiMAX chipset.

---
 include/linux/mmc/sdio_ids.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
include/linux/mmc/sdio_ids.h +0 -0
index ea1bf5b..d1b9883 100644
@@ -26,4 +26,7 @@
 #define SDIO_VENDOR_ID_MARVELL			0x02df
 #define SDIO_DEVICE_ID_MARVELL_LIBERTAS		0x9103
 
Quoted 6 lines

include/linux/mmc/sdio_ids.h line 31

Quoted 3 lines
include/linux/mmc/sdio_ids.h +3 -0
+#define SDIO_VENDOR_ID_SEQUANS			0x039d
+#define SDIO_DEVICE_ID_SEQUANS_SQN1130		0x046a
+

There's no point in adding these unless there's actually some code there which _uses_ them?

Agreed. This is just noise.

Signature · 5 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org