Skip to contentSkip to conversation

arm: Remove redundant display of free swap space in show_mem()

PATCH In review Johannes Weiner 2 participants 16 messages Mar 10, 2008 – Mar 11, 2008

Subsystems (12)
Arm (32-bit) x86 PowerPC MIPS +8 more subsystems
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: Remove redundant display of free swap space in show_mem()

---
 arch/arm/mm/init.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/arm/mm/init.c +0 -2
index ec00f26..b657f17 100644
@@ -48,8 +48,6 @@ void show_mem(void)
 
 	printk("Mem-info:\n");
 	show_free_areas();
-	printk("Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
-
 	for_each_online_node(node) {
 		pg_data_t *n = NODE_DATA(node);
 		struct page *map = n->node_mem_map - n->node_start_pfn;
Signature · 1 line
1.5.2.2
#1 lore raw

PATCH 1/1 cris: Remove redundant display of free swap space in show_mem()

---
 arch/cris/mm/init.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/cris/mm/init.c +0 -1
index 4207a2b..5b06ffa 100644
@@ -27,7 +27,6 @@ show_mem(void)
 
 	printk("\nMem-info:\n");
 	show_free_areas();
-	printk("Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
 	i = max_mapnr;
 	while (i-- > 0) {
 		total++;
Signature · 1 line
1.5.2.2
#2 lore raw

PATCH 1/1 m32r: Remove redundant display of free swap space in show_mem()

In reply to Johannes Weiner
---
 arch/m32r/mm/init.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/m32r/mm/init.c +0 -2
index bbd97c8..a08ac3e 100644
@@ -47,7 +47,6 @@ void show_mem(void)
 
 	printk("Mem-info:\n");
 	show_free_areas();
-	printk("Free swap:       %6ldkB\n",nr_swap_pages<<(PAGE_SHIFT-10));
 	for_each_online_pgdat(pgdat) {
 		unsigned long flags;
 		pgdat_resize_lock(pgdat, &flags);
@@ -252,4 +251,3 @@ void free_initrd_mem(unsigned long start, unsigned long end)
 	printk (KERN_INFO "Freeing initrd memory: %ldk freed\n", (end - start) >> 10);
 }
 #endif
-
Signature · 1 line
1.5.2.2
#3 lore raw

PATCH 1/1 m68k: Remove redundant display of free swap space in show_mem()

In reply to Johannes Weiner
---
 arch/m68k/mm/init.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/m68k/mm/init.c +0 -1
index f42caa7..a2bb01f 100644
@@ -79,7 +79,6 @@ void show_mem(void)
 
 	printk("\nMem-info:\n");
 	show_free_areas();
-	printk("Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
 	for_each_online_pgdat(pgdat) {
 		for (i = 0; i < pgdat->node_spanned_pages; i++) {
 			struct page *page = pgdat->node_mem_map + i;
Signature · 1 line
1.5.2.2
#4 lore raw

PATCH 1/1 mips: Remove redundant display of free swap space in show_mem()

In reply to Johannes Weiner
---
 arch/mips/mm/pgtable.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/mips/mm/pgtable.c +0 -1
index 57df1c3..7dfa579 100644
@@ -12,7 +12,6 @@ void show_mem(void)
 
 	printk("Mem-info:\n");
 	show_free_areas();
-	printk("Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
 	pfn = max_mapnr;
 	while (pfn-- > 0) {
 		if (!pfn_valid(pfn))
Signature · 1 line
1.5.2.2
#5 lore raw

PATCH 1/1 powerpc: Remove redundant display of free swap space in show_mem()

In reply to Johannes Weiner
---
 arch/powerpc/mm/mem.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/powerpc/mm/mem.c +0 -1
index be5c506..b891b1f 100644
@@ -175,7 +175,6 @@ void show_mem(void)
 
 	printk("Mem-info:\n");
 	show_free_areas();
-	printk("Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
 	for_each_online_pgdat(pgdat) {
 		unsigned long flags;
 		pgdat_resize_lock(pgdat, &flags);
Signature · 1 line
1.5.2.2
#6 lore raw

PATCH 1/1 ppc: Remove redundant display of free swap space in show_mem()

In reply to Johannes Weiner
---
 arch/ppc/mm/init.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/ppc/mm/init.c +0 -1
index 7444df3..1a63711 100644
@@ -109,7 +109,6 @@ void show_mem(void)
 
 	printk("Mem-info:\n");
 	show_free_areas();
-	printk("Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
 	i = max_mapnr;
 	while (i-- > 0) {
 		total++;
Signature · 1 line
1.5.2.2
#7 lore raw

PATCH 1/1 s390: Remove redundant display of free swap space in show_mem()

In reply to Johannes Weiner
---
 arch/s390/mm/init.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/s390/mm/init.c +0 -1
index 8053245..202c952 100644
@@ -50,7 +50,6 @@ void show_mem(void)
 
 	printk("Mem-info:\n");
 	show_free_areas();
-	printk("Free swap:       %6ldkB\n", nr_swap_pages << (PAGE_SHIFT - 10));
 	i = max_mapnr;
 	while (i-- > 0) {
 		if (!pfn_valid(i))
Signature · 1 line
1.5.2.2
#8 lore raw

PATCH 1/1 sh: Remove redundant display of free swap space in show_mem()

In reply to Johannes Weiner
---
 arch/sh/mm/init.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/sh/mm/init.c +0 -1
index 53dde06..409e4f0 100644
@@ -55,7 +55,6 @@ void show_mem(void)
 		pgdat_resize_unlock(pgdat, &flags);
 	}
 
-	printk("Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
 	printk("%d pages of RAM\n", total);
 	printk("%d free pages\n", free);
 	printk("%d reserved pages\n", reserved);
Signature · 1 line
1.5.2.2
#9 lore raw

PATCH 1/1 x86: Remove redundant display of free swap space in show_mem()

In reply to Johannes Weiner
---
 arch/x86/mm/init_64.c    |    3 ---
 arch/x86/mm/pgtable_32.c |    1 -
 2 files changed, 0 insertions(+), 4 deletions(-)
arch/x86/mm/init_64.c +0 -3
index a02a14f..37b688d 100644
@@ -69,9 +69,6 @@ void show_mem(void)
 
 	printk(KERN_INFO "Mem-info:\n");
 	show_free_areas();
-	printk(KERN_INFO "Free swap:       %6ldkB\n",
-		nr_swap_pages << (PAGE_SHIFT-10));
-
 	for_each_online_pgdat(pgdat) {
 		for (i = 0; i < pgdat->node_spanned_pages; ++i) {
 			/*
arch/x86/mm/pgtable_32.c +0 -1
index 73aba71..21b7543 100644
@@ -36,7 +36,6 @@ void show_mem(void)
 
 	printk(KERN_INFO "Mem-info:\n");
 	show_free_areas();
-	printk(KERN_INFO "Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
 	for_each_online_pgdat(pgdat) {
 		pgdat_resize_lock(pgdat, &flags);
 		for (i = 0; i < pgdat->node_spanned_pages; ++i) {
Signature · 1 line
1.5.2.2
#10 lore raw

PATCH 1/1 xtensa: Remove redundant display of free swap space in show_mem()

In reply to Johannes Weiner
---
 arch/xtensa/mm/init.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/xtensa/mm/init.c +0 -1
index 81d0560..323b548 100644
@@ -287,7 +287,6 @@ void show_mem(void)
 
 	printk("Mem-info:\n");
 	show_free_areas();
-	printk("Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
 	i = max_mapnr;
 	while (i-- > 0) {
 		total++;
Signature · 1 line
1.5.2.2
#11 lore raw

PATCH 1/1 parisc: Remove redundant display of free swap space in show_mem()

In reply to Johannes Weiner
---
 arch/parisc/mm/init.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/parisc/mm/init.c +0 -2
index eb80f5e..2c721e1 100644
@@ -555,8 +555,6 @@ void show_mem(void)
 
 	printk(KERN_INFO "Mem-info:\n");
 	show_free_areas();
-	printk(KERN_INFO "Free swap:	 %6ldkB\n",
-				nr_swap_pages<<(PAGE_SHIFT-10));
 #ifndef CONFIG_DISCONTIGMEM
 	i = max_mapnr;
 	while (i-- > 0) {
Signature · 1 line
1.5.2.2
#12 lore raw

PATCH 1/1 um: Remove redundant display of free swap space in show_mem()

In reply to Johannes Weiner
---
 arch/um/kernel/mem.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/um/kernel/mem.c +0 -2
index 2eea1ff..6a961b9 100644
@@ -304,8 +304,6 @@ void show_mem(void)
 
 	printk(KERN_INFO "Mem-info:\n");
 	show_free_areas();
-	printk(KERN_INFO "Free swap:       %6ldkB\n",
-	       nr_swap_pages<<(PAGE_SHIFT-10));
 	pfn = max_mapnr;
 	while (pfn-- > 0) {
 		page = pfn_to_page(pfn);
Signature · 1 line
1.5.2.2
#13 lore raw

PATCH 1/1 ia64: Remove redundant display of free swap space in show_mem()

In reply to Johannes Weiner
---
 arch/ia64/mm/contig.c    |    2 --
 arch/ia64/mm/discontig.c |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)
arch/ia64/mm/contig.c +0 -2
index 344f64e..0479661 100644
@@ -45,8 +45,6 @@ void show_mem(void)
 
 	printk(KERN_INFO "Mem-info:\n");
 	show_free_areas();
-	printk(KERN_INFO "Free swap:       %6ldkB\n",
-	       nr_swap_pages<<(PAGE_SHIFT-10));
 	printk(KERN_INFO "Node memory in pages:\n");
 	for_each_online_pgdat(pgdat) {
 		unsigned long present;
arch/ia64/mm/discontig.c +0 -2
index ee5e68b..ffee1ea 100644
@@ -522,8 +522,6 @@ void show_mem(void)
 
 	printk(KERN_INFO "Mem-info:\n");
 	show_free_areas();
-	printk(KERN_INFO "Free swap:       %6ldkB\n",
-	       nr_swap_pages<<(PAGE_SHIFT-10));
 	printk(KERN_INFO "Node memory in pages:\n");
 	for_each_online_pgdat(pgdat) {
 		unsigned long present;
Signature · 1 line
1.5.2.2
Reviewed-by on v1 1/1
#14 lore raw

Re: [PATCH] ia64: Remove redundant display of free swap space in show_mem()

nice.
Thanks.

Quoted 39 lines
---
 arch/ia64/mm/contig.c    |    2 --
 arch/ia64/mm/discontig.c |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)
arch/ia64/mm/contig.c +0 -2
index 344f64e..0479661 100644
@@ -45,8 +45,6 @@ void show_mem(void)
 
 	printk(KERN_INFO "Mem-info:\n");
 	show_free_areas();
-	printk(KERN_INFO "Free swap:       %6ldkB\n",
-	       nr_swap_pages<<(PAGE_SHIFT-10));
 	printk(KERN_INFO "Node memory in pages:\n");
 	for_each_online_pgdat(pgdat) {
 		unsigned long present;
arch/ia64/mm/discontig.c +0 -2
index ee5e68b..ffee1ea 100644
@@ -522,8 +522,6 @@ void show_mem(void)
 
 	printk(KERN_INFO "Mem-info:\n");
 	show_free_areas();
-	printk(KERN_INFO "Free swap:       %6ldkB\n",
-	       nr_swap_pages<<(PAGE_SHIFT-10));
 	printk(KERN_INFO "Node memory in pages:\n");
 	for_each_online_pgdat(pgdat) {
 		unsigned long present;
Signature · 6 lines
1.5.2.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
#15 lore raw
In reply to Johannes Weiner

Hi,

apologies to the arm people who got the full thing now. I obviously failed the git-send-email test.

-- original introduction

show_mem() has no need to print the amount of free swap space manually in show_mem(), show_free_areas() does this already.

I have only x86 boxen to test on but the patches are trivial.

 arch/alpha/mm/init.c     |    1 -
 arch/alpha/mm/numa.c     |    1 -
 arch/arm/mm/init.c       |    2 --
 arch/cris/mm/init.c      |    1 -
 arch/ia64/mm/contig.c    |    2 --
 arch/ia64/mm/discontig.c |    2 --
 arch/m32r/mm/init.c      |    2 --
 arch/m68k/mm/init.c      |    1 -
 arch/mips/mm/pgtable.c   |    1 -
 arch/parisc/mm/init.c    |    2 --
 arch/powerpc/mm/mem.c    |    1 -
 arch/ppc/mm/init.c       |    1 -
 arch/s390/mm/init.c      |    1 -
 arch/sh/mm/init.c        |    1 -
 arch/sparc/mm/init.c     |    2 --
 arch/sparc64/mm/init.c   |    2 --
 arch/um/kernel/mem.c     |    2 --
 arch/x86/mm/init_64.c    |    3 ---
 arch/x86/mm/pgtable_32.c |    1 -
 arch/xtensa/mm/init.c    |    1 -
 20 files changed, 0 insertions(+), 30 deletions(-)

Hannes