Warn if packages with invalid references are evaluated

PATCH Applied Thomas Renninger 1 participant 1 message Mar 12, 2008 ACPI

lore

Share & tools

lore

Thomas Renninger

author

2008-03-12 00:06 UTC #0 lore raw

PATCH 2/3 Warn if packages with invalid references are evaluated

Warn if packages with invalid references are evaluated

And return an error to avoid NULL pointer access by the caller Lin Ming's patch avoids corrupted mem access when BIOS has invalid references included, the handle is now zero instead of corrupted.

Signed-off-by Thomas Renninger <[email protected]>

Signed-off-by Lin Ming <[email protected]>

---

drivers/acpi/utils.c +6 -0

Index: linux-2.6.24/drivers/acpi/utils.c
===================================================================
@@ -407,6 +407,12 @@ acpi_evaluate_reference(acpi_handle hand
 			break;
 		}
 
+		if (!element->reference.handle) {
+			printk(KERN_WARNING PREFIX "Invalid reference in"
+			       " package %s\n", pathname);
+			status = AE_NULL_ENTRY;
+			break;
+		}
 		/* Get the  acpi_handle. */
 
 		list->handles[i] = element->reference.handle;