Blackfin I2C TWI driver: ADSP-BF52x arch/mach support
PATCH 6/6 Blackfin I2C TWI driver: ADSP-BF52x arch/mach support
From: Michael Hennerich <[email protected]>
--- drivers/i2c/busses/Kconfig | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/i2c/busses/Kconfig +3 -3
@@ -100,10 +100,10 @@ config I2C_AU1550 config I2C_BLACKFIN_TWI tristate "Blackfin TWI I2C support" - depends on BF534 || BF536 || BF537 || BF54x + depends on BF534 || BF536 || BF537 || BF54x || BF522 || BF525 || BF527 help - This is the TWI I2C device driver for Blackfin 534/536/537/54x. - This driver can also be built as a module. If so, the module + This is the TWI I2C device driver for Blackfin 522/525/527/534/536/537/54x. + This driver can also be built as a module. If so, the module will be called i2c-bfin-twi. config I2C_BLACKFIN_TWI_CLK_KHZ
Signature · 7 lines
1.5.4.3 _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
A message that is not in the archive (sent off-list or not yet received): 1205479360-25240-7-git-send-email-cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Quoted 15 lines · Bryan Wu
From: Michael Hennerich <[email protected]>
Signed-off-by Michael Hennerich <[email protected]>Signed-off-by Bryan Wu <[email protected]>Signed-off-by Bryan Wu <[email protected]>--- drivers/i2c/busses/Kconfig | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/i2c/busses/Kconfig +0
-0@@ -100,10 +100,10 @@ config I2C_AU1550
drivers/i2c/busses/Kconfig config I2C_AU1550 · line 107
Quoted 10 lines
drivers/i2c/busses/Kconfig +3
-3config I2C_BLACKFIN_TWI tristate "Blackfin TWI I2C support" - depends on BF534 || BF536 || BF537 || BF54x + depends on BF534 || BF536 || BF537 || BF54x || BF522 || BF525 || BF527 help - This is the TWI I2C device driver for Blackfin 534/536/537/54x. - This driver can also be built as a module. If so, the module + This is the TWI I2C device driver for Blackfin 522/525/527/534/536/537/54x. + This driver can also be built as a module. If so, the module will be called i2c-bfin-twi.
Now that the i2c-bfin-twi driver no longer requires special defines in the arch/mach header files, wouldn't it be more simple to just make it depend on BLACKFIN? Otherwise we'll have to update the "depends on" statement over and over again with every new machine.
Signature · 6 lines
Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 17 lines · Jean Delvare
Quoted 15 lines · Bryan Wu
From: Michael Hennerich <[email protected]>
Signed-off-by Michael Hennerich <[email protected]>Signed-off-by Bryan Wu <[email protected]>Signed-off-by Bryan Wu <[email protected]>--- drivers/i2c/busses/Kconfig | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/i2c/busses/Kconfig +0
-0@@ -100,10 +100,10 @@ config I2C_AU1550
Quoted 16 lines
drivers/i2c/busses/Kconfig config I2C_AU1550 · line 107
Quoted 10 lines
drivers/i2c/busses/Kconfig +3
-3config I2C_BLACKFIN_TWI tristate "Blackfin TWI I2C support" - depends on BF534 || BF536 || BF537 || BF54x + depends on BF534 || BF536 || BF537 || BF54x || BF522 || BF525 || BF527 help - This is the TWI I2C device driver for Blackfin 534/536/537/54x. - This driver can also be built as a module. If so, the module + This is the TWI I2C device driver for Blackfin 522/525/527/534/536/537/54x. + This driver can also be built as a module. If so, the module will be called i2c-bfin-twi.Now that the i2c-bfin-twi driver no longer requires special defines in the
arch/machheader files, wouldn't it be more simple to just make it depend on BLACKFIN? Otherwise we'll have to update the "depends on" statement over and over again with every new machine.
Unfortunately, 2 important Blackfin processor family BF533 and BF561 do not integrate on-chip i2c twi controller.
They can use this driver. I plan to define HAVE_BFIN_I2C_TWI in each Blackfin family, then Blackfin I2C TWI driver just "depends on BLACKFIN && HAVE_BFIN_I2C_TWI". We don't change this configuration again when new machine born.
Thanks
-Bryan
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
A message that is not in the archive (sent off-list or not yet received): 386072610803242055h648bc250sa27f7193044f18d5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quoted 35 lines · Bryan Wu
Quoted 17 lines · Jean Delvare
Quoted 15 lines · Bryan Wu
From: Michael Hennerich <[email protected]>
Signed-off-by Michael Hennerich <[email protected]>Signed-off-by Bryan Wu <[email protected]>Signed-off-by Bryan Wu <[email protected]>--- drivers/i2c/busses/Kconfig | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/i2c/busses/Kconfig +0
-0@@ -100,10 +100,10 @@ config I2C_AU1550Quoted 16 lines
drivers/i2c/busses/Kconfig config I2C_AU1550 · line 107
Quoted 10 lines
drivers/i2c/busses/Kconfig +3
-3config I2C_BLACKFIN_TWI tristate "Blackfin TWI I2C support" - depends on BF534 || BF536 || BF537 || BF54x + depends on BF534 || BF536 || BF537 || BF54x || BF522 || BF525 || BF527 help - This is the TWI I2C device driver for Blackfin 534/536/537/54x. - This driver can also be built as a module. If so, the module + This is the TWI I2C device driver for Blackfin 522/525/527/534/536/537/54x. + This driver can also be built as a module. If so, the module will be called i2c-bfin-twi.Now that the i2c-bfin-twi driver no longer requires special defines in the
arch/machheader files, wouldn't it be more simple to just make it depend on BLACKFIN? Otherwise we'll have to update the "depends on" statement over and over again with every new machine.
Quoted 3 lines
Unfortunately, 2 important Blackfin processor family BF533 and BF561 do not integrate on-chip i2c twi controller.
They can use this driver. I plan to defineHAVE_BFIN_I2C_TWIin each
I guess you meant "they can NOT use this driver"?
Quoted 3 lines
Blackfin family, then Blackfin I2C TWI driver just "depends on BLACKFIN &&
HAVE_BFIN_I2C_TWI". We don't change this configuration again when new machine born.
Well, there's nothing wrong with letting people build this driver even if the platform doesn't have any supported device. As long as it doesn't cause a build failure, it's alright. So you could simply use "depends on BLACKFIN" (which is technically correct) and just document which machines have the device (as you already did).
But if you prefer to introduce HAVE_BFIN_I2C_TWI, that's fine with me, it's really as you prefer.
Out of curiosity, isn't it possible to build a single kernel that would support more than just one Blackfin machine? I wonder if this is something people could be interested in - I have seen such requirements for other platforms already.
Signature · 6 lines
Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c