kvmppc_relay: select required relay in
Subsystems (2)
PATCH 1/1 kvmppc_relay: select required relay in
Subject: [PATCH] kvmppc_relay: select required relay in config
From: Christian Ehrhardt <[email protected]>
When using the kvmppc_relay patch we need CONFIG_RELAY to compile. The simple solution to fold into our relay patch is in here which selects RELAY for us. If preferred we might implement as well a CONFIG_KVMPPC_TLBDEBUG which selects RELAY and ifdef's our code using relay elements.
---
Kconfig | 1 + 1 files changed, 1 insertion(+)
arch/powerpc/kvm/Kconfig +1 -0
@@ -38,6 +38,7 @@ config KVM_POWERPC_440 tristate "KVM guest support for PowerPC 440" depends on KVM && 44x select KVM_POWERPC + select RELAY ---help--- Provides support for KVM on 440 processors.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel
Re: [kvm-ppc-devel] [PATCH] kvmppc_relay: select required relay
Quoted 20 lines · On Thu, 2008-03-20 at 11:17 +0100, [email protected] wrote:
Subject: [PATCH]
kvmppc_relay: select required relay in configFrom: Christian Ehrhardt <[email protected]>
When using the
kvmppc_relaypatch we needCONFIG_RELAYto compile. The simple solution to fold into our relay patch is in here which selects RELAY for us. If preferred we might implement as well aCONFIG_KVMPPC_TLBDEBUGwhich selects RELAY and ifdef's our code using relay elements.Signed-off-by Christian Ehrhardt <[email protected]>---
Kconfig | 1 + 1 files changed, 1 insertion(+)
arch/powerpc/kvm/Kconfig config KVM_POWERPC_440 · line 43
Quoted 6 lines
arch/powerpc/kvm/Kconfig +1
-0@@ -38,6 +38,7 @@ config KVM_POWERPC_440 tristate "KVM guest support for PowerPC 440" depends on KVM && 44x select KVM_POWERPC + select RELAY ---help--- Provides support for KVM on 440 processors.
I'm worried about applying this now and then forgetting to change it before submitting.
I think the right solution is the ifdef idea, but honestly I'm not even sure I want to adhere to this naming scheme ("44x_tlb") and data format. I'm also not sure it matters: it's supposed to be debug info only, so not a stable ABI?
I think it might be better to call into 44x_tlb.c to create the channel too, instead of sharing it between powerpc.c and 44x_tlb.c. At that point the ifdefs become more localized too. Want to put together a patch for that?
Signature · 12 lines
Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-ppc-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel