Skip to contentSkip to conversation

Blackfin SPI Driver: Fix peripheral pins initialization bug in SPI probe

PATCH New Bryan Wu 1 participant 1 message Mar 26, 2008 SPI

lore
Share & tools
lore

Bryan Wu

author
#0 lore raw

PATCH 2/3 Blackfin SPI Driver: Fix peripheral pins initialization bug in SPI probe

From: Vitja Makarov <[email protected]>

Fix bug in SPI probe: first initialize peripheral pins, and just after register spi master device. This fixes problems with SPI drivers built-in kernel.

Singed-off-by Vitja Makarov <[email protected]>
Signed-off-by Bryan Wu <[email protected]>
---
 drivers/spi/spi_bfin5xx.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
drivers/spi/spi_bfin5xx.c +6 -6
index c93c9d6..a4bf3af 100644
@@ -1294,6 +1294,12 @@ static int __init bfin5xx_spi_probe(struct platform_device *pdev)
 		goto out_error_queue_alloc;
 	}
 
+	status = peripheral_request_list(drv_data->pin_req, DRV_NAME);
+	if (status != 0) {
+		dev_err(&pdev->dev, ": Requesting Peripherals failed\n");
+		goto out_error_queue_alloc;
+	}
+
 	/* Register with the SPI framework */
 	platform_set_drvdata(pdev, drv_data);
 	status = spi_register_master(master);

@@ -1302,12 +1308,6 @@ static int __init bfin5xx_spi_probe(struct platform_device *pdev)
 		goto out_error_queue_alloc;
 	}
 
-	status = peripheral_request_list(drv_data->pin_req, DRV_NAME);
-	if (status != 0) {
-		dev_err(&pdev->dev, ": Requesting Peripherals failed\n");
-		goto out_error;
-	}
-
 	dev_info(dev, "%s, Version %s, regs_base@%p, dma channel@%d\n",
 		DRV_DESC, DRV_VERSION, drv_data->regs_base,
 		drv_data->dma_channel);
Signature · 1 line
1.5.4.3