Skip to contentSkip to conversation

drivers: code clean up

PATCH New Dave Liu 2 participants 2 messages Mar 27, 2008 – Apr 13, 2008 Block layer

lore
Share & tools
lore

Dave Liu

author
#0 lore raw

PATCH 3/3 drivers: code clean up

Signed-off-by Dave Liu <[email protected]>
---
 drivers/block/libata.c |   36 ++++++++++++++++++------------------
 include/sata.h         |    5 +++++
 2 files changed, 23 insertions(+), 18 deletions(-)
drivers/block/libata.c +18 -18
index bbe16a2..90e9a43 100644
@@ -109,39 +109,39 @@ void ata_dump_id(u16 *id)
 	n_sectors = ata_id_n_sectors(id);
 	printf("Capablity: %d sectors\n\r", n_sectors);
 
-	printf ("id[49]: capabilities ==0x%04x\n"
-		"id[53]: field valid ==0x%04x\n"
-		"id[63]: mwdma ==0x%04x\n"
-		"id[64]: pio ==0x%04x\n"
-		"id[75]: queue depth ==0x%04x\n",
+	printf ("id[49]: capabilities = 0x%04x\n"
+		"id[53]: field valid = 0x%04x\n"
+		"id[63]: mwdma = 0x%04x\n"
+		"id[64]: pio = 0x%04x\n"
+		"id[75]: queue depth = 0x%04x\n",
 		id[49],
 		id[53],
 		id[63],
 		id[64],
 		id[75]);
 
-	printf ("id[76]: sata capablity ==0x%04x\n"
-		"id[78]: sata features supported ==0x%04x\n"
-		"id[79]: sata features enable ==0x%04x\n",
+	printf ("id[76]: sata capablity = 0x%04x\n"
+		"id[78]: sata features supported = 0x%04x\n"
+		"id[79]: sata features enable = 0x%04x\n",
 		id[76],
 		id[78],
 		id[79]);
 
-	printf ("id[80]: major version ==0x%04x\n"
-		"id[81]: minor version ==0x%04x\n"
-		"id[82]: command set supported 1 ==0x%04x\n"
-		"id[83]: command set supported 2 ==0x%04x\n"
-		"id[84]: command set extension ==0x%04x\n",
+	printf ("id[80]: major version = 0x%04x\n"
+		"id[81]: minor version = 0x%04x\n"
+		"id[82]: command set supported 1 = 0x%04x\n"
+		"id[83]: command set supported 2 = 0x%04x\n"
+		"id[84]: command set extension = 0x%04x\n",
 		id[80],
 		id[81],
 		id[82],
 		id[83],
 		id[84]);
-	printf ("id[85]: command set enable 1 ==0x%04x\n"
-		"id[86]: command set enable 2 ==0x%04x\n"
-		"id[87]: command set default ==0x%04x\n"
-		"id[88]: udma ==0x%04x\n"
-		"id[93]: hardware reset result ==0x%04x\n",
+	printf ("id[85]: command set enable 1 = 0x%04x\n"
+		"id[86]: command set enable 2 = 0x%04x\n"
+		"id[87]: command set default = 0x%04x\n"
+		"id[88]: udma = 0x%04x\n"
+		"id[93]: hardware reset result = 0x%04x\n",
 		id[85],
 		id[86],
 		id[87],
include/sata.h +5 -0
index b4b7029..57ee9ac 100644
@@ -1,6 +1,11 @@
+#ifndef __SATA_H__
+#define __SATA_H__
+
 int init_sata(int dev);
 int scan_sata(int dev);
 ulong sata_read(int dev, ulong blknr, ulong blkcnt, void *buffer);
 ulong sata_write(int dev, ulong blknr, ulong blkcnt, const void *buffer);
 
 int sata_initialize(void);
+
+#endif
Signature · 1 line
1.5.4.rc4
Applied
#1 lore raw

PATCH 3/3 drivers: code clean up

Quoted 5 lines · In message <[email protected]> you wrote:
Signed-off-by Dave Liu <[email protected]>
---
 drivers/block/libata.c |   36 ++++++++++++++++++------------------
 include/sata.h         |    5 +++++
 2 files changed, 23 insertions(+), 18 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would be illogical to assume that all conditions remain stable
	-- Spock, "The Enterprise" Incident", stardate 5027.3