Skip to contentSkip to conversation

broken DTS syntax

kvm-ppc-devel Hollis Blanchard 1 participant 1 message Mar 28, 2008

lore
Share & tools
lore
#0 lore raw
Quoted 17 lines · Jerone Young
Quoted 1 line

paelzer@HeliosPrime

~/Desktop/KVM/ppc_port/kvm-userspace-vio/qemu/pc-bios $ dtc -I dts -O dtb -o bamboo.dtb2 bamboo.dts

Quoted 5 lines

DTC: dts->dtb on file "bamboo.dts"
bamboo.dts:20 syntax error
FATAL ERROR: Couldn't read input tree

Is this correct/expected atm or do we have to fix something here

before this goes upstream ?

Quoted 1 line

This must be a dtc versioning issue. My version of dtc compiles the code
fine without issue. But you may have a really older version. Hollis had
spotted a bit of the same problem yesterday.

Quoted 7 lines

I am using dtc version:
dtc -v
Version: DTC 1.1.0-g2512a7eb

Are you using an older version then this one. If so time for everyone to upgrade.

Interesting, I didn't realize the syntax had changed.

However, since it's just a matter of 4 characters, I think it's not too much trouble to support the older DTC versions as well.

For reference, this is the fix:

qemu/pc-bios/bamboo.dts +2 -2
diff -u b/qemu/pc-bios/bamboo.dts b/qemu/pc-bios/bamboo.dts
@@ -17,8 +17,8 @@
        dcr-parent = <&/cpus/cpu@0>;
 
        aliases {
-               serial0 = &UART0;
-               serial1 = &UART1;   
+               serial0 = <&UART0>;
+               serial1 = <&UART1>;   
        };
 
        cpus {
Signature · 13 lines
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
kvm-ppc-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel