Skip to contentSkip to conversation

ppc4xx: Fix problem with DIMMs with 8 banks in 44x_spd_ddr2.c

PATCH New Stefan Roese 1 participant 1 message Apr 30, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: Fix problem with DIMMs with 8 banks in 44x_spd_ddr2.c

This patch fixes a problem with DIMMs that have 8 banks. Now the MCIF0_MBxCF register will be setup correctly for this setup too.

This was noticed with the 512MB DIMM on Canyonlands/Glacier.

---
 cpu/ppc4xx/44x_spd_ddr2.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
cpu/ppc4xx/44x_spd_ddr2.c +5 -2
index 5b5de48..ec76b71 100644
@@ -1,7 +1,10 @@
 /*
  * cpu/ppc4xx/44x_spd_ddr2.c
  * This SPD SDRAM detection code supports AMCC PPC44x cpu's with a
- * DDR2 controller (non Denali Core). Those are 440SP/SPe.
+ * DDR2 controller (non Denali Core). Those currently are:
+ *
+ * 405:		405EX
+ * 440/460:	440SP/440SPe/460EX/460GT
  *
  * (C) Copyright 2007-2008
  * Stefan Roese, DENX Software Engineering, sr at denx.de.
@@ -2078,7 +2081,7 @@ static void program_bxcf(unsigned long *dimm_populated,
 				if (num_banks == 4)
 					ind = 0;
 				else
-					ind = 5;
+					ind = 5 << 8;
 				switch (num_col_addr) {
 				case 0x08:
 					mode |= (SDRAM_BXCF_M_AM_0 + ind);
Signature · 1 line
1.5.5.1