Skip to contentSkip to conversation

drivers: fix returning void-valued expression warnings

PATCH Applied Harvey Harrison 1 participant 1 message Apr 30, 2008

Subsystems (5)
Block layer virtio core Real time clock (RTC) Xen hypervisor interface +1 more subsystems
lore
Share & tools
lore

Harvey Harrison

author
#0 lore raw

PATCH 8/10 drivers: fix returning void-valued expression warnings

drivers/block/xen-blkfront.c:1011:2: warning: returning void-valued expression drivers/isdn/i4l/isdn_net.c:1986:3: warning: returning void-valued expression drivers/rtc/rtc-ds1511.c:648:2: warning: returning void-valued expression drivers/rtc/rtc-stk17ta8.c:416:2: warning: returning void-valued expression drivers/virtio/virtio_pci.c:148:2: warning: returning void-valued expression drivers/virtio/virtio_pci.c:155:2: warning: returning void-valued expression

Signed-off-by Harvey Harrison <[email protected]>
---
 drivers/block/xen-blkfront.c |    2 +-
 drivers/isdn/i4l/isdn_net.c  |    2 +-
 drivers/rtc/rtc-ds1511.c     |    2 +-
 drivers/rtc/rtc-stk17ta8.c   |    2 +-
 drivers/virtio/virtio_pci.c  |    4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)
drivers/block/xen-blkfront.c +1 -1
index f2fff57..cf92742 100644
@@ -1008,7 +1008,7 @@ module_init(xlblk_init);
 
 static void xlblk_exit(void)
 {
-	return xenbus_unregister_driver(&blkfront);
+	xenbus_unregister_driver(&blkfront);
 }
 module_exit(xlblk_exit);
drivers/isdn/i4l/isdn_net.c +1 -1
index ef1a300..ac37041 100644
@@ -1983,7 +1983,7 @@ static void isdn_header_cache_update(struct hh_cache *hh,
 {
 	isdn_net_local *lp = dev->priv;
 	if (lp->p_encap == ISDN_NET_ENCAP_ETHER)
-		return eth_header_cache_update(hh, dev, haddr);
+		eth_header_cache_update(hh, dev, haddr);
 }
 
 static const struct header_ops isdn_header_ops = {
drivers/rtc/rtc-ds1511.c +1 -1
index a83a40b..d1dbdfe 100644
@@ -645,7 +645,7 @@ ds1511_rtc_init(void)
  static void __exit
 ds1511_rtc_exit(void)
 {
-	return platform_driver_unregister(&ds1511_rtc_driver);
+	platform_driver_unregister(&ds1511_rtc_driver);
 }
 
 module_init(ds1511_rtc_init);
drivers/rtc/rtc-stk17ta8.c +1 -1
index 31d3c8c..62dace3 100644
@@ -413,7 +413,7 @@ static __init int stk17ta8_init(void)
 
 static __exit void stk17ta8_exit(void)
 {
-	return platform_driver_unregister(&stk17ta8_rtc_driver);
+	platform_driver_unregister(&stk17ta8_rtc_driver);
 }
 
 module_init(stk17ta8_init);
drivers/virtio/virtio_pci.c +2 -2
index c0df924..de102a6 100644
@@ -145,14 +145,14 @@ static void vp_set_status(struct virtio_device *vdev, u8 status)
 	struct virtio_pci_device *vp_dev = to_vp_device(vdev);
 	/* We should never be setting status to 0. */
 	BUG_ON(status == 0);
-	return iowrite8(status, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
+	iowrite8(status, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
 }
 
 static void vp_reset(struct virtio_device *vdev)
 {
 	struct virtio_pci_device *vp_dev = to_vp_device(vdev);
 	/* 0 status means a reset. */
-	return iowrite8(0, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
+	iowrite8(0, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
 }
 
 /* the notify function used when creating a virt queue */
Signature · 1 line
1.5.5.1.305.g7c84