Make one-bit signed bitfields unsigned

PATCH Applied Harvey Harrison 1 participant 1 message Apr 30, 2008

Subsystems (3)

MMC, SD and SDIO Input drivers Secure digital host controller interface (SDHCI) driver

lore

Share & tools

lore

Harvey Harrison

author

2008-04-30 22:07 UTC #0 lore raw

PATCH 10/10 Make one-bit signed bitfields unsigned

Otherwise it can only take the values 0/-1 which doesn't seem to have been intended.

drivers/input/tablet/wacom.h:108:12: error: dubious one-bit signed bitfield drivers/mmc/host/sdhci.h:190:20: error: dubious one-bit signed bitfield

Signed-off-by Harvey Harrison <[email protected]>

---
 drivers/input/tablet/wacom.h |    2 +-
 drivers/mmc/host/sdhci.h     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/input/tablet/wacom.h +1 -1

index 706619d..ca62ec6 100644
@@ -105,7 +105,7 @@ struct wacom {
 	struct urb *irq;
 	struct wacom_wac * wacom_wac;
 	struct mutex lock;
-	int open:1;
+	unsigned int open:1;
 	char phys[32];
 };

drivers/mmc/host/sdhci.h +1 -1

index 7fb02e1..299118d 100644
@@ -187,7 +187,7 @@ struct sdhci_host {
 	struct mmc_request	*mrq;		/* Current request */
 	struct mmc_command	*cmd;		/* Current command */
 	struct mmc_data		*data;		/* Current data request */
-	int			data_early:1;	/* Data finished before cmd */
+	unsigned int		data_early:1;	/* Data finished before cmd */
 
 	struct scatterlist	*cur_sg;	/* We're working on this */
 	int			num_sg;		/* Entries left */

Signature · 1 line

1.5.5.1.305.g7c84