linux/a.out.h is not exported to userspace
Hi,
Looking for a compile failure for a package on uclibc system using kernel-headers from 2.6.25 I found that linux/a.out.h is no more exported to userland anymore.
This commit below has disabled it from being exported. The commit Do not export asm/page.h during make headers_install so I was wondering if it was intended to unexport linux/a.out.h or not.
Looking at the patch from lkml post
http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-10/msg08913.html
second hunk to include/linux/Kbuild was not applied which caused this problem.
I think I do not fall into Signed-off-by definition. I tested the following patch on 2.6.25.
Thanks
-Khem
include/linux/Kbuild +1 -0
@@ -168,6 +168,7 @@ unifdef-y += acct.h unifdef-y += adb.h unifdef-y += adfs_fs.h unifdef-y += agpgart.h +unifdef-y += a.out.h unifdef-y += apm_bios.h unifdef-y += atalk.h unifdef-y += atmdev.h
Stefan Hellermann
Tested-byQuoted 13 lines
Hi,
Looking for a compile failure for a package on uclibc system using kernel-headers from 2.6.25 I found that
linux/a.out.his no more exported to userland anymore.This commit below has disabled it from being exported. The commit Do not export
asm/page.hduring makeheaders_installso I was wondering if it was intended to unexportlinux/a.out.hor not.
Quoted 7 lines
Looking at the patch from lkml post
http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-10/msg08913.html
second hunk to
include/linux/Kbuildwas not applied which caused this problem.
I saw this problem, too. The patch fixes this.
Quoted 8 lines
I think I do not fall into Signed-off-by definition. I tested the following patch on 2.6.25.
Thanks
-Khem
Tested-by Khem Raj <[email protected]>
Quoted 14 lines
include/linux/Kbuild +1
-0@@ -168,6 +168,7 @@ unifdef-y += acct.h unifdef-y += adb.h unifdef-y += adfs_fs.h unifdef-y += agpgart.h +unifdef-y += a.out.h unifdef-y += apm_bios.h unifdef-y += atalk.h unifdef-y += atmdev.h
(adding cc)
Quoted 31 lines · Khem Raj
Looking for a compile failure for a package on uclibc system using kernel-headers from 2.6.25 I found that
linux/a.out.his no more exported to userland anymore.This commit below has disabled it from being exported. The commit Do not export
asm/page.hduring makeheaders_installso I was wondering if it was intended to unexportlinux/a.out.hor not.Looking at the patch from lkml post
http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-10/msg08913.html
second hunk to
include/linux/Kbuildwas not applied which caused this problem.I think I do not fall into Signed-off-by definition. I tested the following patch on 2.6.25.
Thanks
-Khem
Tested-by Khem Raj <[email protected]>include/linux/Kbuild +0
-0
include/linux/Kbuild unifdef-y += acct.h · line 174
Quoted 7 lines
include/linux/Kbuild +1
-0@@ -168,6 +168,7 @@ unifdef-y += acct.h unifdef-y += adb.h unifdef-y += adfs_fs.h unifdef-y += agpgart.h +unifdef-y += a.out.h unifdef-y += apm_bios.h unifdef-y += atalk.h unifdef-y += atmdev.h
It's usually a good idea to cc the patch author(s) if you want something fixed....
Quoted 34 lines · Khem Raj
Hi,
Looking for a compile failure for a package on uclibc system using kernel-headers from 2.6.25 I found that
linux/a.out.his no more exported to userland anymore.This commit below has disabled it from being exported. The commit Do not export
asm/page.hduring makeheaders_installso I was wondering if it was intended to unexportlinux/a.out.hor not.Looking at the patch from lkml post
http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-10/msg08913.html
second hunk to
include/linux/Kbuildwas not applied which caused this problem.I think I do not fall into Signed-off-by definition. I tested the following patch on 2.6.25.
Thanks
-Khem
Tested-by Khem Raj <[email protected]>include/linux/Kbuild +0
-0
include/linux/Kbuild unifdef-y += acct.h · line 174
Quoted 7 lines
include/linux/Kbuild +1
-0@@ -168,6 +168,7 @@ unifdef-y += acct.h unifdef-y += adb.h unifdef-y += adfs_fs.h unifdef-y += agpgart.h +unifdef-y += a.out.h unifdef-y += apm_bios.h unifdef-y += atalk.h unifdef-y += atmdev.h
That'll export <linux/a.out.h> even on architectures where <asm/a.out.h> doesn't exist -- which will cause headers_check to fail.
Perhaps we could do it something like this:
include/linux/Kbuild +3 -0
@@ -168,6 +168,9 @@ unifdef-y += acct.h unifdef-y += adb.h unifdef-y += adfs_fs.h unifdef-y += agpgart.h +ifeq ($(wildcard include/asm-$(SRCARCH)/a.out.h),include/asm-$(SRCARCH)/a.out.h) +unifdef-y += a.out.h +endif unifdef-y += apm_bios.h unifdef-y += atalk.h unifdef-y += atmdev.h
In fact, perhaps we could do <linux/kvm.h> that way too -- I believe I objected to using a CONFIG symbol, but the mere existence of the file would be fine. I don't think we thought of that at the time.
Signature · 1 line
dwmw2
Quoted 34 lines · On Fri, 16 May 2008 17:13:57 -0700 Khem Raj <[email protected]> wrote:
Hi,
Looking for a compile failure for a package on uclibc system using kernel-headers from 2.6.25 I found that
linux/a.out.his no more exported to userland anymore.This commit below has disabled it from being exported. The commit Do not export
asm/page.hduring makeheaders_installso I was wondering if it was intended to unexportlinux/a.out.hor not.Looking at the patch from lkml post
http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-10/msg08913.html
second hunk to
include/linux/Kbuildwas not applied which caused this problem.I think I do not fall into Signed-off-by definition. I tested the following patch on 2.6.25.
Thanks
-Khem
Tested-by Khem Raj <[email protected]>include/linux/Kbuild +0
-0
include/linux/Kbuild unifdef-y += acct.h · line 174
Quoted 7 lines
include/linux/Kbuild +1
-0@@ -168,6 +168,7 @@ unifdef-y += acct.h unifdef-y += adb.h unifdef-y += adfs_fs.h unifdef-y += agpgart.h +unifdef-y += a.out.h unifdef-y += apm_bios.h unifdef-y += atalk.h unifdef-y += atmdev.h
This breaks `make headerscheck' on s390:
/usr/src/devel/usr/include/linux/a.out.h requires asm/a.out.h, which does not exist in exported headers
which might be an s390 problem.
Quoted 6 lines · Andrew Morton
This breaks `make headerscheck' on s390:
/usr/src/devel/usr/include/linux/a.out.hrequiresasm/a.out.h, which does not exist in exported headerswhich might be an s390 problem.
There was also this patch that David proposed here
http://lkml.org/lkml/2008/5/18/46
this patch also takes care of the architectures that do not have asm/a.out.h. I tried this patch on s390 and arm one with and one without asm/a.out.h
Thanks
-Khem
include/linux/Kbuild +3 -0
@@ -166,6 +166,9 @@ unifdef-y += acct.h unifdef-y += adb.h unifdef-y += adfs_fs.h unifdef-y += agpgart.h +ifeq ($(wildcard include/asm-$(SRCARCH)/a.out.h),include/asm-$(SRCARCH)/a.out.h) +unifdef-y += a.out.h +endif unifdef-y += apm_bios.h unifdef-y += atalk.h unifdef-y += atmdev.h
Quoted 8 lines · Andrew Morton
On Fri, 16 May 2008 17:13:57 -0700 Khem Raj <[email protected]> wrote:
This breaks `make headerscheck' on s390:
/usr/src/devel/usr/include/linux/a.out.hrequiresasm/a.out.h, which does not exist in exported headerswhich might be an s390 problem.
The attached patch from David is a replacement patch. I have tested this patch by running make headers_install on every architecture under arch/ It works for all (except 'um' and 'ppc' which do not export headers)
Thanks
-Khem
include/linux/Kbuild +3 -0
@@ -166,6 +166,9 @@ unifdef-y += acct.h unifdef-y += adb.h unifdef-y += adfs_fs.h unifdef-y += agpgart.h +ifeq ($(wildcard include/asm-$(SRCARCH)/a.out.h),include/asm-$(SRCARCH)/a.out.h) +unifdef-y += a.out.h +endif unifdef-y += apm_bios.h unifdef-y += atalk.h unifdef-y += atmdev.h
Quoted 6 lines · Khem Raj
Quoted 5 lines · Andrew Morton
On Fri, 16 May 2008 17:13:57 -0700 Khem Raj <[email protected]> wrote:
This breaks `make headerscheck' on s390:
Quoted 7 lines
Quoted 3 lines
/usr/src/devel/usr/include/linux/a.out.hrequiresasm/a.out.h, which does not exist in exported headerswhich might be an s390 problem.
The attached patch from David is a replacement patch. I have tested this patch by running make
headers_installon every architecture underarch/It works for all (except 'um' and 'ppc' which do not export headers)
We also need to remove the instance of #ifdef CONFIG_something which David sneaked in to <linux/a.out.h>.
And make a 'headers_check' test for it :)
Signature · 1 line
dwmw2