Skip to contentSkip to conversation

ehci-mxc: Fix host power mask bit for i.MX25

PATCH New Benoît Thébaudeau 2 participants 2 messages Nov 16, 2012 – Nov 19, 2012 1 message not in the archive

Subsystems (3)
USB Arm i.MX and Layerscape USB ehci driver
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Benoît Thébaudeau

author
#1 lore raw

PATCH 1/1 ehci-mxc: Fix host power mask bit for i.MX25

The correct bit for H1_PM is 16, not 8, which is the DP pull-up impedance selection bit.

This issue has been reported by Eric B?nard <[email protected]> and fixed by Christoph Fritz <[email protected]> on Linux, from which these #define-s had been copied.

Signed-off-by Beno?t Th?baudeau <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Marek Vasut <[email protected]>
---
 .../drivers/usb/host/ehci-mxc.c                                      |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/ehci-mxc.c +1 -1
index 7c5f71c..352ad86 100644
@@ -37,7 +37,7 @@
 #define MX25_H1_SIC_SHIFT	21
 #define MX25_H1_SIC_MASK	(0x3 << MX25_H1_SIC_SHIFT)
 #define MX25_H1_PP_BIT		(1 << 18)
-#define MX25_H1_PM_BIT		(1 << 8)
+#define MX25_H1_PM_BIT		(1 << 16)
 #define MX25_H1_IPPUE_UP_BIT	(1 << 7)
 #define MX25_H1_IPPUE_DOWN_BIT	(1 << 6)
 #define MX25_H1_TLL_BIT		(1 << 5)
#2 lore raw

PATCH 1/1 ehci-mxc: Fix host power mask bit for i.MX25

Quoted 20 lines · Beno?t Th?baudeau

The correct bit for H1_PM is 16, not 8, which is the DP pull-up impedance selection bit.

This issue has been reported by Eric B?nard <[email protected]> and fixed by Christoph Fritz <[email protected]> on Linux, from which these #define-s had been copied.

Signed-off-by Beno?t Th?baudeau <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Marek Vasut <[email protected]>
---
 .../drivers/usb/host/ehci-mxc.c                                      |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/ehci-mxc.c +0 -0
index 7c5f71c..352ad86 100644

drivers/usb/host/ehci-mxc.c line 43

Quoted 8 lines
drivers/usb/host/ehci-mxc.c +1 -1
@@ -37,7 +37,7 @@
 #define MX25_H1_SIC_SHIFT	21
 #define MX25_H1_SIC_MASK	(0x3 << MX25_H1_SIC_SHIFT)
 #define MX25_H1_PP_BIT		(1 << 18)
-#define MX25_H1_PM_BIT		(1 << 8)
+#define MX25_H1_PM_BIT		(1 << 16)
 #define MX25_H1_IPPUE_UP_BIT	(1 << 7)
 #define MX25_H1_IPPUE_DOWN_BIT	(1 << 6)
 #define MX25_H1_TLL_BIT		(1 << 5)

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================