Skip to contentSkip to conversation

Make x86 latest boot with non-discontig boxes

PATCH In review Glauber Costa 4 participants 6 messages Jun 4, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Make x86 latest boot with non-discontig boxes

Commit 0596152388e234efebce464355186ad9e16c8cb6 broke my box, since it removes completely the call to memory_present() at e820 setup.

It seems to be really not needed with discontig memory, but with flat and sparse, I get an early crash. The proposed patch moves the call memory_present() to setup_memory, the one present in setup_32.c.

---
 arch/x86/kernel/setup_32.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/x86/kernel/setup_32.c +2 -0
index 2901042..841eb2f 100644
@@ -388,6 +388,8 @@ static unsigned long __init setup_memory(void)
 #ifdef CONFIG_FLATMEM
 	max_mapnr = num_physpages;
 #endif
+	memory_present(0, 0, max_pfn);
+
 	printk(KERN_NOTICE "%ldMB LOWMEM available.\n",
 			pages_to_mb(max_low_pfn));
 
Signature · 1 line
1.5.4.5
#1 lore raw
Quoted 20 lines · Glauber Costa

Commit 0596152388e234efebce464355186ad9e16c8cb6 broke my box, since it removes completely the call to memory_present() at e820 setup.

It seems to be really not needed with discontig memory, but with flat and sparse, I get an early crash. The proposed patch moves the call memory_present() to setup_memory, the one present in setup_32.c.

---
 arch/x86/kernel/setup_32.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/x86/kernel/setup_32.c +0 -0
index 2901042..841eb2f 100644

arch/x86/kernel/setup_32.c static unsigned long __init setup_memory(void)

Quoted 9 lines
arch/x86/kernel/setup_32.c +2 -1
@@ -388,6 +388,8 @@ static unsigned long __init setup_memory(void)
 #ifdef CONFIG_FLATMEM
       max_mapnr = num_physpages;
 #endif
+       memory_present(0, 0, max_pfn);
+
       printk(KERN_NOTICE "%ldMB LOWMEM available.\n",
                       pages_to_mb(max_low_pfn));
 
--

thanks

http://lkml.org/lkml/2008/6/3/229
[PATCH] x86: change propagate_e820_map back to find_max_pfn -32bit - fix

already address that.

YH

#2 lore raw
Quoted 32 lines · Yinghai Lu
Quoted 20 lines · Glauber Costa

Commit 0596152388e234efebce464355186ad9e16c8cb6 broke my box, since it removes completely the call to memory_present() at e820 setup.

It seems to be really not needed with discontig memory, but with flat and sparse, I get an early crash. The proposed patch moves the call memory_present() to setup_memory, the one present in setup_32.c.

---
 arch/x86/kernel/setup_32.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/x86/kernel/setup_32.c +0 -0
index 2901042..841eb2f 100644

arch/x86/kernel/setup_32.c static unsigned long __init setup_memory(void)

Quoted 9 lines
arch/x86/kernel/setup_32.c +2 -1
@@ -388,6 +388,8 @@ static unsigned long __init setup_memory(void)
 #ifdef CONFIG_FLATMEM
       max_mapnr = num_physpages;
 #endif
+       memory_present(0, 0, max_pfn);
+
       printk(KERN_NOTICE "%ldMB LOWMEM available.\n",
                       pages_to_mb(max_low_pfn));
 
--

thanks

Quoted 6 lines

http://lkml.org/lkml/2008/6/3/229
[PATCH] x86: change propagate_e820_map back to find_max_pfn -32bit - fix

already address that.

YH

Great.

I guess it was not on the tree yet, then.

Signature · 5 lines
Glauber Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."
#3 lore raw
Quoted 36 lines · Glauber Costa
Quoted 35 lines · Yinghai Lu
Quoted 20 lines · Glauber Costa

Commit 0596152388e234efebce464355186ad9e16c8cb6 broke my box, since it removes completely the call to memory_present() at e820 setup.

It seems to be really not needed with discontig memory, but with flat and sparse, I get an early crash. The proposed patch moves the call memory_present() to setup_memory, the one present in setup_32.c.

---
 arch/x86/kernel/setup_32.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/x86/kernel/setup_32.c +0 -0
index 2901042..841eb2f 100644

arch/x86/kernel/setup_32.c static unsigned long __init setup_memory(void)

Quoted 9 lines
arch/x86/kernel/setup_32.c +2 -1
@@ -388,6 +388,8 @@ static unsigned long __init setup_memory(void)
 #ifdef CONFIG_FLATMEM
       max_mapnr = num_physpages;
 #endif
+       memory_present(0, 0, max_pfn);
+
       printk(KERN_NOTICE "%ldMB LOWMEM available.\n",
                       pages_to_mb(max_low_pfn));
 
--

thanks

http://lkml.org/lkml/2008/6/3/229
[PATCH] x86: change propagate_e820_map back to find_max_pfn -32bit - fix

Quoted 8 lines
Quoted 3 lines

already address that.

YH

Great.

I guess it was not on the tree yet, then.

yes

today sent out several

[PATCH] x86: change propagate_e820_map back to find_max_pfn -32bit - fix [PATCH] x86: early check if one system is numaq v2
[PATCH] x86: remove all active before register them again after trimming - 64bit [PATCH] x86: numa32 make sure get kva space
[PATCH] x86: move e820_register_active to e820.c
[PATCH] x86: 32 bit use e820_register_active_regions

YH

#4 lore raw
In reply to Glauber Costa
Quoted 6 lines · Glauber Costa

Commit 0596152388e234efebce464355186ad9e16c8cb6 broke my box, since it removes completely the call to memory_present() at e820 setup.

It seems to be really not needed with discontig memory, but with flat and sparse, I get an early crash. The proposed patch moves the call memory_present() to setup_memory, the one present in setup_32.c.

thanks for tracking it down. Could you check whether the latest x86/master tree works fine now?

Ingo

#5 lore raw
Quoted 6 lines · Ingo Molnar
Quoted 3 lines · Glauber Costa

Commit 0596152388e234efebce464355186ad9e16c8cb6 broke my box, since it removes completely the call to memory_present() at e820 setup.

Quoted 6 lines
Quoted 3 lines

It seems to be really not needed with discontig memory, but with flat and sparse, I get an early crash. The proposed patch moves the call memory_present() to setup_memory, the one present in setup_32.c.

thanks for tracking it down. Could you check whether the latest x86/master tree works fine now?

boots beautifully.

Signature · 5 lines
Glauber Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."