Add sysfs removable attribute for hotplug memory remove
Subsystems (3)
PATCH 1/1 Add sysfs removable attribute for hotplug memory remove
Hi Andrew,
Recently realized that this patch came out of -mm tree and never made it back in. I was supposed to update the description & comments and add documentation for API.
Here is the updated version. Could you please include it in -mm ?
Thanks,
Badari
Memory may be hot-removed on a per-memory-block basis, particularly on POWER where the SPARSEMEM section size often matches the memory-block size. A user-level agent must be able to identify which sections of memory are likely to be removable before attempting the potentially expensive operation. This patch adds a file called "removable" to the memory directory in sysfs to help such an agent. In this patch, a memory block is considered removable if;
o It contains only MOVABLE pageblocks
o It contains only pageblocks with free pages regardless of pageblock type
On the other hand, a memory block starting with a PageReserved() page will never be considered removable. Without this patch, the user-agent is forced to choose a memory block to remove randomly.
Sample output of the sysfs files:
./memory/memory0/removable: 0
./memory/memory1/removable: 0
./memory/memory2/removable: 0
./memory/memory3/removable: 0
./memory/memory4/removable: 0
./memory/memory5/removable: 0
./memory/memory6/removable: 0
./memory/memory7/removable: 1
./memory/memory8/removable: 0
./memory/memory9/removable: 0
./memory/memory10/removable: 0
./memory/memory11/removable: 0
./memory/memory12/removable: 0
./memory/memory13/removable: 0
./memory/memory14/removable: 0
./memory/memory15/removable: 0
./memory/memory16/removable: 0
./memory/memory17/removable: 1
./memory/memory18/removable: 1
./memory/memory19/removable: 1
./memory/memory20/removable: 1
./memory/memory21/removable: 1
./memory/memory22/removable: 1
--- Documentation/ABI/testing/sysfs-devices-memory | 24 ++++++++++ drivers/base/memory.c | 19 +++++++ include/linux/memory_hotplug.h | 12 +++++ mm/memory_hotplug.c | 60 +++++++++++++++++++++++++ 4 files changed, 115 insertions(+)
drivers/base/memory.c +19 -0
@@ -100,6 +100,21 @@ static ssize_t show_mem_phys_index(struc }/* +* Show whether the section of memory is likely to be hot-removable +*/ +static ssize_t show_mem_removable (struct sys_device *dev,char *buf) +{ +unsigned long start_pfn; +int ret; +struct memory_block *mem = + container_of(dev, struct memory_block, sysdev); + + start_pfn =section_nr_to_pfn (mem->phys_index); + ret =is_mem_section_removable (start_pfn,PAGES_PER_SECTION ); +return sprintf (buf,"%d\n" , ret); +} + +/* * online, offline, going offline, etc. */ static ssize_t show_mem_state (struct sys_device *dev,char *buf)
@@ -258,6 +273,7 @@ static ssize_t show_phys_device(struct s static SYSDEV_ATTR(phys_index, 0444, show_mem_phys_index, NULL); static SYSDEV_ATTR(state, 0644, show_mem_state, store_mem_state); static SYSDEV_ATTR(phys_device, 0444, show_phys_device, NULL); +static SYSDEV_ATTR(removable, 0444, show_mem_removable, NULL);#define mem_create_simple_file (mem, attr_name) \ sysdev_create_file(&mem->sysdev, &attr_##attr_name)
@@ -346,6 +362,8 @@ static int add_memory_block(unsigned lon ret =mem_create_simple_file (mem, state);if (!ret) ret =mem_create_simple_file (mem, phys_device); +if (!ret) + ret =mem_create_simple_file (mem, removable);return ret; }
@@ -390,6 +408,7 @@ int remove_memory_block(unsigned long nomem_remove_simple_file (mem, phys_index);mem_remove_simple_file (mem, state);mem_remove_simple_file (mem, phys_device); +mem_remove_simple_file (mem, removable);unregister_memory (mem, section);return 0 ;
include/linux/memory_hotplug.h +12 -0
@@ -199,6 +199,18 @@ extern int walk_memory_resource(unsigned unsigned long nr_pages, void *arg, int (*func)(unsigned long, unsigned long, void *)); +#ifdef CONFIG_MEMORY_HOTREMOVE + +extern int is_mem_section_removable (unsigned long pfn,unsigned long nr_pages); + +#else +static inline int is_mem_section_removable (unsigned long pfn, +unsigned long nr_pages) +{ +return 0 ; +} +#endif /* CONFIG_MEMORY_HOTREMOVE */ +extern int add_memory (int nid,u64 start,u64 size);extern int arch_add_memory (int nid,u64 start,u64 size);extern int remove_memory (u64 start,u64 size);
mm/memory_hotplug.c +60 -0
66 lines not on this page · raw message
Documentation/ABI/testing/sysfs-devices-memory new file +24 -0
@@ -0,0 +1,24 @@ +What: /sys/devices/system/memory +Date: June 2008 +Contact: Badari Pulavarty <[email protected]> +Description: + The /sys/devices/system/memory contains a snapshot of the + internal state of the kernel memory blocks. Files could be + added or removed dynamically to represent hot-add/remove + operations. + +Users: hotplug memory add/remove tools + https://w3.opensource.ibm.com/projects/powerpc-utils/ + +What: /sys/devices/system/memory/memoryX/removable +Date: June 2008 +Contact: Badari Pulavarty <[email protected]> +Description: + The file /sys/devices/system/memory/memoryX/removable + indicates whether this memory block is removable or not. + This is useful for a user-level agent to determine + identify removable sections of the memory before attempting + potentially expensive hot-remove memory operation + +Users: hotplug memory remove tools + https://w3.opensource.ibm.com/projects/powerpc-utils/